Modes

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'DEN-14252-system-self-test-failure-occurs-intermittently' into develop

DEN-14252: Another fix to pre-tx reservor mgmt state machine.

Merge branch 'DEN-14252-system-self-test-failure-occurs-intermittently' into develop

DEN-14252: Additional fix to reservoir mgmt state machine.

parameter0?

parameter0?

Please add comment.

Please add comment.

HD-DEN-14344_SW S85 MG Dpi Pwmflow Fix
HD-DEN-14344_SW S85 MG Dpi Pwmflow Fix
It seems strange to add a magic number here, from a defined constant. I'd assume (guess) the relation between 300->225 is maintaining a delta P along the flow path (or across the membrane?), but it...

It seems strange to add a magic number here, from a defined constant.
I'd assume (guess) the relation between 300->225 is maintaining a delta P along the flow path (or across the membrane?), but it might be worth spelling out, at the top with the defines, or as a macro function of the input flow rate.

Merge branch 'DEN-14252-system-self-test-failure-occurs-intermittently' into develop

DEN-14252 updated the pretreatment reservoirs state change condition and added the HD load cels events

Merged DEN-14252

  1. … 2 more files in changeset.
DEN-14344: DPI set pwm direction fix.

  1. … 1 more file in changeset.
DEN-14252: Candidate fix for DEN-14405.

DEN-14252: Candidate fix for DEN-14254 for syringe DAC issue.

  1. … 1 more file in changeset.
DEN-14252: Candidate fix for DEN-14252 bug.

DEN-14252 added an else in dry self test for the software configurations

DEN-14344: fixed sw config checks. Updated dry self test thresholds to handle air pump performance.

  1. … 1 more file in changeset.
DEN-14344: Air pump integration into air trap and dry self tests.

  1. … 2 more files in changeset.
DEN-14307 added PiSquare's VectorCAST

  1. … 3 more files in changeset.
RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

Alignment throughout the file. However, this file is auto-generated by HalCoGen.

Alignment throughout the file. However, this file is auto-generated by HalCoGen.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

HalCoGen is currently editing het.h, het.c, sys_link.cmd, HD.dil, and sys_selftest.c in this branch. Any and all the changes within those files are autogenerated from HaloCoGen.

HalCoGen is currently editing het.h, het.c, sys_link.cmd, HD.dil, and sys_selftest.c in this branch. Any and all the changes within those files are autogenerated from HaloCoGen.

Is this an output file from HalCoGen? If so seems like one shouldn't need to modify this file directly.

Is this an output file from HalCoGen? If so seems like one shouldn't need to modify this file directly.

Updated to reset valve position and flag.

Updated to reset valve position and flag.

Added define. There is no harm in closing valve if already closed. TODO comment below is a place holder for checking if closed too long. More testing by systems needed to determine if this is neces...

Added define. There is no harm in closing valve if already closed. TODO comment below is a place holder for checking if closed too long. More testing by systems needed to determine if this is necessary.

Updated to venous. Good catch.

Updated to venous. Good catch.

DEN-14099 Code review comment updates 1.

AirPump.h should be before AirTrap.h.

AirPump.h should be before AirTrap.h.