hdfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 07 Feb 2023
3:52 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

3:41 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:40 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:39 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:34 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:34 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:26 pm

jtaylor  (deleted user)

Done (By Darren).

Done (By Darren).

3:25 pm

jtaylor  (deleted user)

Done.

Done.

3:24 pm

jtaylor  (deleted user)

Done.

Done.

3:24 pm

jtaylor  (deleted user)

This turns off the trimmer hearter, to smooth heater control (as before). The switch state (next up) actually makes the reservoir switch, the next state.

This turns off the trimmer hearter, to smooth heater control (as before). The switch state (next up) actually makes the reservoir switch, the next state.

3:21 pm

jtaylor  (deleted user)

This works, even if the s.t. dry test is skipped.

This works, even if the s.t. dry test is skipped.

3:17 pm

jtaylor  (deleted user)

Done (By Darren)

Done (By Darren)

3:17 pm

jtaylor  (deleted user)

The normal value is too tight for the current hardware; it always fails this test, without the wider volume tolerance.

The normal value is too tight for the current hardware; it always fails this test, without the wider volume tolerance.

3:14 pm

jtaylor  (deleted user)

Done.

Done.

3:12 pm

jtaylor  (deleted user)

Done (by Darren)

Done (by Darren)

3:08 pm

jtaylor  (deleted user)

Comment Alignment

Comment Alignment

3:04 pm

wbracken  (deleted user)

Add pendingUFVolumeChange, pressTreatmentTimeSecs, pendingParamChangesTimer,

Add pendingUFVolumeChange, pressTreatmentTimeSecs, pendingParamChangesTimer,

1:53 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

1:52 pm

wbracken  (deleted user)

11:58 am

dcox  (deleted user)

Use SEC_PER_MIN instead of 60. Also comment says min, but really it is ms.

Use SEC_PER_MIN instead of 60. Also comment says min, but really it is ms.

Monday 06 Feb 2023
4:26 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

2:12 pm

Michael Garthwaite

it was a double include anyway. Fixed. Thanks!

it was a double include anyway. Fixed. Thanks!

1:50 pm

wbracken  (deleted user)

Alphabetical ordering.

Alphabetical ordering.

12:54 pm

Sean Nash

Saturday 04 Feb 2023
6:37 pm

Sean Nash

This is not going to work. Revisit. See code review for DEN-14749 for correct arrangement.

This is not going to work. Revisit. See code review for DEN-14749 for correct arrangement.

6:15 pm

Sean Nash

Friday 03 Feb 2023
3:01 pm

Dara Navaei

HD-DEN-14749_Syringe Pump Plunger Remains Extended During Pretreatment Causing HD Software Fault
HD-DEN-14749_Syringe Pump Plunger Remains Extended During Pretreatment Causing HD Software Fault
3:01 pm

Dara Navaei

HD-DEN-14763_DG HD Dev HD DG Dvt Update Part 10
HD-DEN-14763_DG HD Dev HD DG Dvt Update Part 10
10:59 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

9:47 am

Sean Nash

This math no longer works because we changed the displacement time from 1 minute (which allowed for this simplified approach) to 30 seconds. Generalize the math. Suggested approach: -integrate vol...

This math no longer works because we changed the displacement time from 1 minute (which allowed for this simplified approach) to 30 seconds.
Generalize the math.

Suggested approach:
-integrate volume above properly (don't just sum rates over time).
-Should be: fmdIntegratedVolume += ( getMeasuredDialInFlowRate() / (F32)( ( SEC_PER_MIN * MS_PER_SECOND ) / TASK_GENERAL_INTERVAL ) );
-Then we don't need to convert here at end of displacement - can just use fmdIntegratedVolume as is in verify state.