hdfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 13 Mar 2023
1:52 pm

Sean Nash

DEN-14888: Implemented user confirmation of treatment end response to alarm.

Options
    • -27
    • +0
    ./ModeStandby.c
    • -19
    • +18
    ./OperationModes.c
  3. … 4 more files in changeset.
9:38 am

Sean Nash

DEN-14888: Added events to log reservoir switch ultrafiltration metrics.

Options
    • -1
    • +2
    ./Dialysis.c
    • -0
    • +1
    ./Dialysis.h
9:20 am

Sean Nash

Did Blaine ask for this?

Did Blaine ask for this?

Sunday 12 Mar 2023
10:05 pm

wbracken  (deleted user)

Indent for reddability?

Indent for reddability?

10:01 pm

wbracken  (deleted user)

Don't see timeReservoirInUF being used?

Don't see timeReservoirInUF being used?

3:17 pm

Sean Nash

DEN-14888: Updated alarm 47 - UF rate accuracy alarm, to check after each reservoir switch during treatment.

Options
    • -43
    • +55
    ./Dialysis.c
    • -1
    • +0
    ./Dialysis.h
  3. … 2 more files in changeset.
Friday 10 Mar 2023
1:20 pm

wbracken  (deleted user)

Isn't deleted statement correct?

Isn't deleted statement correct?

1:19 pm

wbracken  (deleted user)

Isn't deleted statement correct?

Isn't deleted statement correct?

1:18 pm

wbracken  (deleted user)

Isn't deleted statement correct?

Isn't deleted statement correct?

1:17 pm

wbracken  (deleted user)

Isn't delete statement correct?

Isn't delete statement correct?

10:25 am

Sean Nash

DEN-14888: Lowered UF volume error threshold from 250 to 50 mL.

Options
    • -2
    • +2
    ./Dialysis.c
10:19 am

Sean Nash

I think that's true in calls to serialize function, but I don't think this function wants this kind of flag (i.e. it's not looking for whether to require ACK or not - it wants to know if we are ACK...

I think that's true in calls to serialize function, but I don't think this function wants this kind of flag (i.e. it's not looking for whether to require ACK or not - it wants to know if we are ACKing (TRUE) or NAKing (FALSE) this command). Here, we are NAKing the command, so FALSE was appropriate.

10:16 am

Sean Nash

Has DG check-in msg ID been made available for re-purpose? RESOLVED in CODE WALKTHROUGH.

Has DG check-in msg ID been made available for re-purpose?
RESOLVED in CODE WALKTHROUGH.

10:14 am

Michael Garthwaite

DG no longer sends this message. We determine DG check-in by receiving the DG op mode command.

DG no longer sends this message. We determine DG check-in by receiving the DG op mode command.

10:01 am

Dara Navaei

HD-DEN-14888_Unable TO Trigger Alarm 47 Ultrafiltration Rate IS Too High Error During Treatment
HD-DEN-14888_Unable TO Trigger Alarm 47 Ultrafiltration Rate IS Too High Error During Treatment
9:48 am

Sean Nash

Why removed?

Why removed?

Thursday 09 Mar 2023
11:35 am

wbracken  (deleted user)

Change cmd to prompt

Change cmd to prompt

11:08 am

Michael Garthwaite

How do we wish to handle the output of the automated script? It currently does not handle conditional statements to determine ack requiredness. If set to false, the output is: 0x4A MSG_ID_UI_PATI...

How do we wish to handle the output of the automated script? It currently does not handle conditional statements to determine ack requiredness.

If set to false, the output is:

0x4A MSG_ID_UI_PATIENT_DISCONNECTION_CONFIRM hdfirmware response COMM_BUFFER_OUT_CAN_HD_2_UI ACK_REQUIRED PAYLOAD

which is incorrect to what the code is doing. We have 2 different implementations of calling sendAckResponseMsg()


1. sendAckResponseMsg( (MSG_ID_T)message->hdr.msgID, COMM_BUFFER_OUT_CAN_HD_2_UI, FALSE );

  1. if we dont meet an expected condition. Later in the handler we will call a response message with the response message calling:
    serializeMessage( msg, COMM_BUFFER_OUT_CAN_DG_2_HD, ACK_REQUIRED );


2. sendAckResponseMsg( (MSG_ID_T)message->hdr.msgID, COMM_BUFFER_OUT_CAN_HD_2_UI, result );

  1. a conditional based on?


Please review the FW_Message_list.csv within latest develop & staging builds to understand how the automated script is determining "ack requireness"

Wednesday 08 Mar 2023
9:15 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:12 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:05 pm

Sean Nash

Remove blank line.

Remove blank line.

7:14 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

7:13 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

7:13 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

7:08 pm

Sean Nash

FALSE was right.

FALSE was right.

7:03 pm

Sean Nash

Add space after "(".

Add space after "(".

7:01 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

7:00 pm

Sean Nash

Add blank line before comment.

Add blank line before comment.

4:52 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

4:52 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!