hdfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 15 Mar 2023
8:34 am

Sean Nash

DEN-14888: Reduced time to treatment end escalation from 15 to 10 minutes per latest spec.

Options
    • -1
    • +1
    ./TreatmentEnd.c
Tuesday 14 Mar 2023
5:41 pm

Sean Nash

If we get interrupted by an alarm, how will these vars get reset?

If we get interrupted by an alarm, how will these vars get reset?

5:36 pm

Sean Nash

I don't think we can just shift into reverse here. I think I had last SRS written in a way that we would go tack to the dialysate pumps off state to ramp down again before moving to reprime state.

I don't think we can just shift into reverse here. I think I had last SRS written in a way that we would go tack to the dialysate pumps off state to ramp down again before moving to reprime state.

5:34 pm

Sean Nash

I suppose that could work.

I suppose that could work.

5:28 pm

Sean Nash

Switching valves to dialyzer with DPo stopped initially will be a shock and temporarily send a lot of dialysate to the patient while DPo ramps up. So I think DPi should be hard stopped first and th...

Switching valves to dialyzer with DPo stopped initially will be a shock and temporarily send a lot of dialysate to the patient while DPo ramps up. So I think DPi should be hard stopped first and then start both DPi and DPo at fast purge rate together.

5:28 pm

Steve Jarpe

The timer should have been 5 minutes, my mistake. The purpose is to prevent repeated triggering of the reprime after the 5 minute before treatment reprime is done, as you pointed out. If I change t...

The timer should have been 5 minutes, my mistake. The purpose is to prevent repeated triggering of the reprime after the 5 minute before treatment reprime is done, as you pointed out. If I change the 5 hours to 5 minutes, is that OK?

5:06 pm

Sean Nash

Recommend removing this else if and just commanding pumps to zero when transitioning to reprime state.

Recommend removing this else if and just commanding pumps to zero when transitioning to reprime state.

5:02 pm

Sean Nash

Timer counter is reset in both cases so should be done once before or after the in progress condition is checked.

Timer counter is reset in both cases so should be done once before or after the in progress condition is checked.

5:00 pm

Sean Nash

Need to command dialysate pumps to zero flow rate so they start ramping down.

Need to command dialysate pumps to zero flow rate so they start ramping down.

4:55 pm

Sean Nash

This check to see if it's time to do reprime should be moved to the handler for dialysis: ultrafiltration state (function just below this one) - because we would not want to start a reprime in the ...

This check to see if it's time to do reprime should be moved to the handler for dialysis: ultrafiltration state (function just below this one) - because we would not want to start a reprime in the middle of a saline bolus or a reprime and because we should only be incrementing the timer counter during actual treatment (when treatment time is not paused).

4:43 pm

Sean Nash

I don't understand what the timer > 5 hours is doing here. Timer counter should never get bigger than 30 minutes (resets to zero after reprime completes), so would never get to 5 hours anyway. I th...

I don't understand what the timer > 5 hours is doing here. Timer counter should never get bigger than 30 minutes (resets to zero after reprime completes), so would never get to 5 hours anyway.
I think we just do reprime if 30 min interval OR 5 minutes remaining in treatment. And once we do the reprime for 5 min before end of treatment, we need some way to not do it again (i.e. if we just say time remaining <= 5 minutes, we will keep doing reprimes over and over again for the last 5 minutes).

4:39 pm

Sean Nash

Comment doesn't match const name. This is essentially 5 hours. Why are we repriming after 5 hours? We have a #define below that seems to be better suited for the reprime 5 minutes before end of tre...

Comment doesn't match const name.
This is essentially 5 hours. Why are we repriming after 5 hours?
We have a #define below that seems to be better suited for the reprime 5 minutes before end of treatment. So why do we need this const?

4:27 pm

Sean Nash

Do we need something similar to this for dialyzer reprime?

Do we need something similar to this for dialyzer reprime?

4:26 pm

Sean Nash

Maybe state durations instead of function delays.

Maybe state durations instead of function delays.

4:03 pm

Sean Nash

I think the rest of these are durations, not intervals.

I think the rest of these are durations, not intervals.

2:54 pm

dcox  (deleted user)

Based on your comment in Teams: @ Qd = 450 in your data set... ~8 seconds spent between drain and fill that suggests maybe our just-in-time is a bit off - maybe should have started fill immediately.

Based on your comment in Teams:
@ Qd = 450 in your data set... ~8 seconds spent between drain and fill that suggests maybe our just-in-time is a bit off - maybe should have started fill immediately.

2:39 pm

dcox  (deleted user)

Updated.

Updated.

Monday 13 Mar 2023
2:55 pm

Steve Jarpe <sjarpe@diality.com>

DEN-14906-dialyzer-de-prime. Initial implementation of dialyzer reprime

Options
    • -5
    • +261
    ./Dialysis.c
  2. … 1 more file in changeset.
1:52 pm

Sean Nash

DEN-14888: Implemented user confirmation of treatment end response to alarm.

Options
    • -27
    • +0
    ./ModeStandby.c
    • -19
    • +18
    ./OperationModes.c
  3. … 4 more files in changeset.
9:38 am

Sean Nash

DEN-14888: Added events to log reservoir switch ultrafiltration metrics.

Options
    • -1
    • +2
    ./Dialysis.c
    • -0
    • +1
    ./Dialysis.h
9:20 am

Sean Nash

Did Blaine ask for this?

Did Blaine ask for this?

Sunday 12 Mar 2023
10:05 pm

wbracken  (deleted user)

Indent for reddability?

Indent for reddability?

10:01 pm

wbracken  (deleted user)

Don't see timeReservoirInUF being used?

Don't see timeReservoirInUF being used?

3:17 pm

Sean Nash

DEN-14888: Updated alarm 47 - UF rate accuracy alarm, to check after each reservoir switch during treatment.

Options
    • -43
    • +55
    ./Dialysis.c
    • -1
    • +0
    ./Dialysis.h
  3. … 2 more files in changeset.
Friday 10 Mar 2023
1:20 pm

wbracken  (deleted user)

Isn't deleted statement correct?

Isn't deleted statement correct?

1:19 pm

wbracken  (deleted user)

Isn't deleted statement correct?

Isn't deleted statement correct?

1:18 pm

wbracken  (deleted user)

Isn't deleted statement correct?

Isn't deleted statement correct?

1:17 pm

wbracken  (deleted user)

Isn't delete statement correct?

Isn't delete statement correct?

10:25 am

Sean Nash

DEN-14888: Lowered UF volume error threshold from 250 to 50 mL.

Options
    • -2
    • +2
    ./Dialysis.c
10:19 am

Sean Nash

I think that's true in calls to serialize function, but I don't think this function wants this kind of flag (i.e. it's not looking for whether to require ACK or not - it wants to know if we are ACK...

I think that's true in calls to serialize function, but I don't think this function wants this kind of flag (i.e. it's not looking for whether to require ACK or not - it wants to know if we are ACKing (TRUE) or NAKing (FALSE) this command). Here, we are NAKing the command, so FALSE was appropriate.