hdfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 15 Mar 2023
11:48 am

Sean Nash

Will do.

Will do.

11:47 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:47 am

Sean Nash

Just wondering whether a reset function was needed for reprime. Looks like you've added one. RESOLVED in CODE WALKTHROUGH.

Just wondering whether a reset function was needed for reprime. Looks like you've added one.
RESOLVED in CODE WALKTHROUGH.

11:43 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:39 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:39 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:37 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:36 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:36 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:34 am

Sean Nash

I think it would make more sense to set DPi rate to zero, set re-prime in progress flag to FALSE, and set state to dialysate pumps off which will then handle the ramp down and transition to reprime...

I think it would make more sense to set DPi rate to zero, set re-prime in progress flag to FALSE, and set state to dialysate pumps off which will then handle the ramp down and transition to reprime state.

11:27 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:22 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:20 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:19 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:16 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:15 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:12 am

Sean Nash

Comment should say with, not without.

Comment should say with, not without.

11:06 am

Steve Jarpe

Done.

Done.

10:52 am

Steve Jarpe

Need more info.

Need more info.

10:49 am

Steve Jarpe

Done

Done

10:48 am

Sean Nash

Let's add a build switch at top of HDCommon.h (where SIMULATE_UI is for example) to allow us to include or exclude this reprime feature from build (e.g. #define DIALYZER_REPRIME_ENABLED 1). Then, w...

Let's add a build switch at top of HDCommon.h (where SIMULATE_UI is for example) to allow us to include or exclude this reprime feature from build (e.g. #define DIALYZER_REPRIME_ENABLED 1). Then, wherever you have dialyzer reprime code, surround with #ifdef DIALYZER_REPRIME_ENABLED and #endif.

10:34 am

Steve Jarpe

Done.

Done.

10:32 am

Steve Jarpe

init function created for dialyzer reprime

init function created for dialyzer reprime

10:28 am

Steve Jarpe

Done

Done

10:21 am

Steve Jarpe

Done.

Done.

10:03 am

Sean Nash

Generally don't like static variables declared locally in function. Initialization is tricky. Would move to module level scope if needed at all. I don't think it is needed if you command pumps to z...

Generally don't like static variables declared locally in function. Initialization is tricky. Would move to module level scope if needed at all. I don't think it is needed if you command pumps to zero before you get to this state.

10:02 am

Sean Nash

Per our re-prime slide deck, we wanted to change minimum ultrafiltration volume from zero to X mL. X = treatment duration (in hrs) x 100 mL. I think changes are in order in ModeTreatmentParams.c an...

Per our re-prime slide deck, we wanted to change minimum ultrafiltration volume from zero to X mL. X = treatment duration (in hrs) x 100 mL. I think changes are in order in ModeTreatmentParams.c and perhaps elsewhere to implement that change.
Also, in Reservoirs.c, we will want to prevent dialysate use from being counted while in re-prime states.
Also, there were some alarms we wanted to exempt while performing re-prime.
Let me know if you'd like me to handle any of these parts of the implementation.

10:01 am

Steve Jarpe

Done.

Done.

10:01 am

Steve Jarpe

This was removed when the function was changed to solve other problems.

This was removed when the function was changed to solve other problems.

10:01 am

Sean Nash

Might want to include DialyzerRePrime in these state function names for clarity (similar to saline bolus state function names).

Might want to include DialyzerRePrime in these state function names for clarity (similar to saline bolus state function names).