hdfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 12 May 2023
2:03 pm

Dara Navaei

DEN-15274 added test configuration commands

Options
    • -3
    • +3
    ./ModeStandby.c
    • -6
    • +20
    ./SelfTests.c
1:30 pm

Darren Cox <darren_m@cox.net>

DEN-15229 No door open flag for UF set. Allow door open until user confirm.

Options
    • -7
    • +4
    ./ModePreTreat.c
1:07 pm

Sean Nash

I don't see these two functions in the .c file. Are they not yet implemented?

I don't see these two functions in the .c file. Are they not yet implemented?

1:06 pm

Sean Nash

Why 2 of these?

Why 2 of these?

1:02 pm

Sean Nash

What does this do? Why 64 (not 32)?

What does this do? Why 64 (not 32)?

12:52 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:49 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:09 pm

Darren Cox <darren_m@cox.net>

DEN-15229 Code review comment update.

Options
    • -0
    • +6
    ./ModePreTreat.c
11:42 am

Dara Navaei

HD-DEN-15196_DIAL-251
HD-DEN-15196_DIAL-251
11:38 am

Sean Nash

With that approach, we are likely to have pump/heater off for some time which will allow the dialysate to cool and perhaps cause a temperature alarm when we do start treatment. I think we should ha...

With that approach, we are likely to have pump/heater off for some time which will allow the dialysate to cool and perhaps cause a temperature alarm when we do start treatment.
I think we should have the pump/heater on when door is closed in patient connect states.

11:33 am

Sean Nash

Next state only requires door closed after confirm (when state is done). In meantime, door can be opened while pump is on and no alarm will occur and pump stays on I would think.

Next state only requires door closed after confirm (when state is done). In meantime, door can be opened while pump is on and no alarm will occur and pump stays on I would think.

10:55 am

dcox  (deleted user)

it is done in the next state - user confirm. May be a better idea to move this pump & heater on to that state after user confirm.

it is done in the next state - user confirm. May be a better idea to move this pump & heater on to that state after user confirm.

10:54 am

dcox  (deleted user)

I did not want to have the pump turning on/off if opened more than once. Stop while the user performs the action, then turn on when they are done. Maybe wait to turn on until user confirm.

I did not want to have the pump turning on/off if opened more than once. Stop while the user performs the action, then turn on when they are done. Maybe wait to turn on until user confirm.

10:46 am

Michael Garthwaite

DIAL-251: reworked events for operation status and operation state transitions

Options
    • -1
    • +1
    ./ConsumableSelfTest.c
    • -0
    • +3
    ./Dialysis.c
    • -0
    • +1
    ./ModeFault.c
    • -1
    • +2
    ./ModePostTreat.c
    • -0
    • +9
    ./ModePreTreat.c
    • -0
    • +1
    ./ModeService.c
    • -0
    • +2
    ./ModeStandby.c
    • -0
    • +1
    ./ModeTreatment.c
    • -5
    • +2
    ./ModeTreatmentParams.c
    • -4
    • +29
    ./OperationModes.c
    • -0
    • +3
    ./OperationModes.h
    • -0
    • +1
    ./PreTreatmentRecirc.c
    • -0
    • +1
    ./Prime.c
    • -0
    • +1
    ./Rinseback.c
    • -0
    • +1
    ./SampleWater.c
  16. … 4 more files in changeset.
10:25 am

Sean Nash

Should we have an else to turn pump and heater back on when door is closed?

Should we have an else to turn pump and heater back on when door is closed?

10:24 am

Sean Nash

Since pump is going to be on and next state is not calling your door check function, should we call doorClosedRequired( TRUE, TRUE ) here? Or next state could call your door check function to handl...

Since pump is going to be on and next state is not calling your door check function, should we call doorClosedRequired( TRUE, TRUE ) here? Or next state could call your door check function to handle it.

10:07 am

Sean Nash

I think this whole function should be moved down into test support functions section.

I think this whole function should be moved down into test support functions section.

10:03 am

Sean Nash

I think there are cases where rsrvrCmd is not set and so we should not be calling this function in those cases.

I think there are cases where rsrvrCmd is not set and so we should not be calling this function in those cases.

10:02 am

Sean Nash

case body should be indented.

case body should be indented.

10:00 am

Sean Nash

Use new #define from comment above.

Use new #define from comment above.

9:59 am

Sean Nash

If res 1 is active, you will not set rsrvrCmd to anything but you are still sending command below.

If res 1 is active, you will not set rsrvrCmd to anything but you are still sending command below.

9:57 am

Sean Nash

Use new #define (from comment above).

Use new #define (from comment above).

9:56 am

Sean Nash

FULL volume is 1500. Unlikely to be less than 1500 as fills tend to overshoot a little (they don't stop until at least 1500). Add new #define for a max start value - maybe 1575 and use that instead.

FULL volume is 1500. Unlikely to be less than 1500 as fills tend to overshoot a little (they don't stop until at least 1500). Add new #define for a max start value - maybe 1575 and use that instead.

9:49 am

Sean Nash

Update inputs

Update inputs

9:47 am

Sean Nash

Comment for what we're doing here.

Comment for what we're doing here.

9:43 am

Sean Nash

Put this prototype declaration last w/ blank line before.

Put this prototype declaration last w/ blank line before.

Thursday 11 May 2023
4:37 pm

wbracken  (deleted user)

Add comment

Add comment

1:45 pm

Dara Navaei

DEN-15274 updated the test configuration reservoir management

Options
    • -26
    • +14
    ./ModePreTreat.c
11:46 am

Dara Navaei

DEN-15274 added code to support the test configurations

Options
    • -0
    • +6
    ./BloodPrime.c
    • -13
    • +200
    ./ModePreTreat.c
  3. … 1 more file in changeset.
Wednesday 10 May 2023
3:17 pm

Dara Navaei