Modes

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DIAL-251: fixed payload preparation for operation status event. Fixed compiler warnings

Merge branch 'DEN-15229-fw-dpi-pump-on-during-inverted-dialyzer' into develop

DEN-15229 Only allow open door during dialyzer invert. Warn user of open door by enabling alarm before transition out of patient connect state.

Missing function header

Missing function header

DEN-15274 added test configuration commands

DEN-15229 No door open flag for UF set. Allow door open until user confirm.

I don't see these two functions in the .c file. Are they not yet implemented?

I don't see these two functions in the .c file. Are they not yet implemented?

Why 2 of these?

Why 2 of these?

What does this do? Why 64 (not 32)?

What does this do? Why 64 (not 32)?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-15229 Code review comment update.

HD-DEN-15196_DIAL-251
HD-DEN-15196_DIAL-251
With that approach, we are likely to have pump/heater off for some time which will allow the dialysate to cool and perhaps cause a temperature alarm when we do start treatment. I think we should ha...

With that approach, we are likely to have pump/heater off for some time which will allow the dialysate to cool and perhaps cause a temperature alarm when we do start treatment.
I think we should have the pump/heater on when door is closed in patient connect states.

Next state only requires door closed after confirm (when state is done). In meantime, door can be opened while pump is on and no alarm will occur and pump stays on I would think.

Next state only requires door closed after confirm (when state is done). In meantime, door can be opened while pump is on and no alarm will occur and pump stays on I would think.

it is done in the next state - user confirm. May be a better idea to move this pump & heater on to that state after user confirm.

it is done in the next state - user confirm. May be a better idea to move this pump & heater on to that state after user confirm.

I did not want to have the pump turning on/off if opened more than once. Stop while the user performs the action, then turn on when they are done. Maybe wait to turn on until user confirm.

I did not want to have the pump turning on/off if opened more than once. Stop while the user performs the action, then turn on when they are done. Maybe wait to turn on until user confirm.

DIAL-251: reworked events for operation status and operation state transitions

  1. … 4 more files in changeset.
Should we have an else to turn pump and heater back on when door is closed?

Should we have an else to turn pump and heater back on when door is closed?

Since pump is going to be on and next state is not calling your door check function, should we call doorClosedRequired( TRUE, TRUE ) here? Or next state could call your door check function to handl...

Since pump is going to be on and next state is not calling your door check function, should we call doorClosedRequired( TRUE, TRUE ) here? Or next state could call your door check function to handle it.

I think this whole function should be moved down into test support functions section.

I think this whole function should be moved down into test support functions section.

I think there are cases where rsrvrCmd is not set and so we should not be calling this function in those cases.

I think there are cases where rsrvrCmd is not set and so we should not be calling this function in those cases.

case body should be indented.

case body should be indented.

Use new #define from comment above.

Use new #define from comment above.

If res 1 is active, you will not set rsrvrCmd to anything but you are still sending command below.

If res 1 is active, you will not set rsrvrCmd to anything but you are still sending command below.

Use new #define (from comment above).

Use new #define (from comment above).

FULL volume is 1500. Unlikely to be less than 1500 as fills tend to overshoot a little (they don't stop until at least 1500). Add new #define for a max start value - maybe 1575 and use that instead.

FULL volume is 1500. Unlikely to be less than 1500 as fills tend to overshoot a little (they don't stop until at least 1500). Add new #define for a max start value - maybe 1575 and use that instead.

Update inputs

Update inputs

Comment for what we're doing here.

Comment for what we're doing here.

Put this prototype declaration last w/ blank line before.

Put this prototype declaration last w/ blank line before.