hdfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 14 May 2023
4:57 pm

Dara Navaei

DEN-15274 addressed the code review comments

Options
    • -0
    • +1
    ./ModePreTreat.c
    • -12
    • +13
    ./ModeStandby.c
    • -2
    • +2
    ./SelfTests.c
4:57 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:57 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:57 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:56 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:56 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:56 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:55 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:55 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:53 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:43 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

3:31 pm

Sean Nash

Should probably set confirm flag to FALSE here even though it probably gets reset at some point before next treatment.

Should probably set confirm flag to FALSE here even though it probably gets reset at some point before next treatment.

3:31 pm

Sean Nash

By this point, we've already accepted the confirm from user so we need to move on to next state even if door is open - not sure this could even happen if we require door closed for entirety of this...

By this point, we've already accepted the confirm from user so we need to move on to next state even if door is open - not sure this could even happen if we require door closed for entirety of this state.

3:27 pm

Sean Nash

Not needed if we do this in prior state.

Not needed if we do this in prior state.

3:25 pm

Sean Nash

Not sure we need this in this state if we require door to be closed in this state.

Not sure we need this in this state if we require door to be closed in this state.

3:21 pm

Sean Nash

Once we leave this state, we've done the door open/close that we were looking for - so should start requiring door to be closed from this point forward.

Once we leave this state, we've done the door open/close that we were looking for - so should start requiring door to be closed from this point forward.

3:17 pm

Sean Nash

I think we still want to get credit for opening the door in this state - and so need to be okay with door opening (not required to be closed) and so probably should be calling your door handler here.

I think we still want to get credit for opening the door in this state - and so need to be okay with door opening (not required to be closed) and so probably should be calling your door handler here.

12:40 pm

Dara Navaei

DEN-15274 addressed the code review comments

Options
    • -152
    • +157
    ./ModePreTreat.c
12:40 pm

Dara Navaei

Done

Done

12:40 pm

Dara Navaei

Done

Done

12:39 pm

Dara Navaei

Done

Done

12:37 pm

Dara Navaei

I changed the code.

I changed the code.

12:37 pm

Dara Navaei

Done

Done

12:37 pm

Dara Navaei

Done

Done

12:37 pm

Dara Navaei

I was thinking to send the command anyways. If the active reservoir is what we need, it will be ignored. But I changed the code.

I was thinking to send the command anyways. If the active reservoir is what we need, it will be ignored. But I changed the code.

12:32 pm

Dara Navaei

Done

Done

12:28 pm

Dara Navaei

Done. This indentation was picked by Code Composer Studios though.

Done. This indentation was picked by Code Composer Studios though.

12:27 pm

Dara Navaei

Done

Done

Saturday 13 May 2023
1:09 pm

Michael Garthwaite

DIAL-251: fixed payload preparation for operation status event. Fixed compiler warnings

Options
    • -8
    • +13
    ./OperationModes.c
    • -0
    • +18
    ./OperationModes.h
Friday 12 May 2023
3:55 pm

Darren Cox <darren_m@cox.net>

Merge branch 'DEN-15229-fw-dpi-pump-on-during-inverted-dialyzer' into develop

Options
    • -13
    • +38
    ./ModePreTreat.c