hdfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 15 May 2023
9:57 am

Sean Nash

DEN-15245: Fixed issue with syringe occlusion check potentially overriding a previously set stop pump flag.

Options
    • -1
    • +1
    ./SelfTests.c
  2. … 2 more files in changeset.
9:56 am

Michael Garthwaite

I want to keep the old sub state change events for dialin compatibility. I believe other tests use the sub state change event

I want to keep the old sub state change events for dialin compatibility. I believe other tests use the sub state change event

Sunday 14 May 2023
6:32 pm

Sean Nash

This is a 4th level state - not currently supported I think.

This is a 4th level state - not currently supported I think.

6:30 pm

Sean Nash

Should this be in transition function?

Should this be in transition function?

6:29 pm

Sean Nash

Is there any submode of treatment mode that does not have substates?

Is there any submode of treatment mode that does not have substates?

6:28 pm

Sean Nash

Not many submodes in pre-tx that don't have substates - maybe cartridge install. Should call this when entering a submode with no substates.

Not many submodes in pre-tx that don't have substates - maybe cartridge install. Should call this when entering a submode with no substates.

5:44 pm

Sean Nash

Post treatment starts in drain reservoirs submode which does have a substate. Once we leave drain reservoirs submode, then we should call this function with no substate for remainder of post treatm...

Post treatment starts in drain reservoirs submode which does have a substate. Once we leave drain reservoirs submode, then we should call this function with no substate for remainder of post treatment submodes.

5:41 pm

Sean Nash

In consumable self-test, you removed the old send substate change event. Why keep this one?

In consumable self-test, you removed the old send substate change event. Why keep this one?

5:40 pm

Sean Nash

This is a 4th level state. Currently not supported I think.

This is a 4th level state. Currently not supported I think.

5:40 pm

Sean Nash

This is a 4th level state. Currently not supported I think.

This is a 4th level state. Currently not supported I think.

5:39 pm

Sean Nash

Not clear to me which of the older events are still being supported. What's the plan?

Not clear to me which of the older events are still being supported. What's the plan?

5:38 pm

Sean Nash

Remove extra "}". Should be 2 blank lines above test support banner.

Remove extra "}". Should be 2 blank lines above test support banner.

5:36 pm

Sean Nash

What is d2?

What is d2?

5:36 pm

Sean Nash

should be "void sendOperationStatusEvent( void )"

should be "void sendOperationStatusEvent( void )"

5:36 pm

Sean Nash

Missing function header.

Missing function header.

5:34 pm

Sean Nash

Remove blank line.

Remove blank line.

5:31 pm

Sean Nash

Do we need to call this function on transition to consumables self-test so that op modes will get initial state? (Question applies throughout this code branch)

Do we need to call this function on transition to consumables self-test so that op modes will get initial state? (Question applies throughout this code branch)

5:00 pm

Sean Nash

Consider moving this declarations to top of function and then removing the outer {} for these cases.

Consider moving this declarations to top of function and then removing the outer {} for these cases.

4:57 pm

Dara Navaei

DEN-15274 addressed the code review comments

Options
    • -0
    • +1
    ./ModePreTreat.c
    • -12
    • +13
    ./ModeStandby.c
    • -2
    • +2
    ./SelfTests.c
4:57 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:57 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:57 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:56 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:56 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:56 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:55 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:55 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:53 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:43 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

3:31 pm

Sean Nash

Should probably set confirm flag to FALSE here even though it probably gets reset at some point before next treatment.

Should probably set confirm flag to FALSE here even though it probably gets reset at some point before next treatment.