hdfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 15 May 2023
5:25 pm

Sean Nash

DIAL-252: Update to standby mode to handle alarms w/ stop property (will close valves).

Options
    • -1
    • +30
    ./ModeStandby.c
4:40 pm

dcox  (deleted user)

Correct, no longer required. Removed.

Correct, no longer required. Removed.

4:35 pm

dcox  (deleted user)

Reset proper flag.

Reset proper flag.

4:32 pm

Darren Cox <darren_m@cox.net>

DEN-15229 Code review changes. Clear flag, no need to check door when required to be shut.

Options
    • -3
    • +1
    ./ModePreTreat.c
4:16 pm

Sean Nash

We are (I think now) allowing door open in first 2 states (UF and invert dialyzer), so should not be getting door open alarm when UI is prompting user to invert dialyzer. When we get to 3rd state (...

We are (I think now) allowing door open in first 2 states (UF and invert dialyzer), so should not be getting door open alarm when UI is prompting user to invert dialyzer. When we get to 3rd state (where we start requiring door to be closed), we are looking for user to connect patient and confirm. UI should be following along with our states and showing appropriate screens.
RESOLVED in CODE WALKTHROUGH.

4:06 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:06 pm

Sean Nash

Doesn't look removed. I'm talking about the call to handlePatientConnectionDoorOpened(). Do we need this now that door closed is required (as set in prior state)?

Doesn't look removed. I'm talking about the call to handlePatientConnectionDoorOpened(). Do we need this now that door closed is required (as set in prior state)?

4:01 pm

Sean Nash

Doesn't make sense to reset in previous state. You're resetting door opened flag there. I'm talking about patient connect confirm flag used in if statement above.

Doesn't make sense to reset in previous state. You're resetting door opened flag there. I'm talking about patient connect confirm flag used in if statement above.

3:59 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:59 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:51 pm

Dara Navaei

Merge branch 'DEN-15274-hd_dg_test_configuration_setup' into develop

Options
    • -2
    • +2
    ./ModePreTreat.c
3:43 pm

dcox  (deleted user)

Updated to do this. To me it seems counter intuitive. If the user opens door when UF or BP screen is showing, then Open door screen come up, user opens door and gets alarm. If they hit next, it sho...

Updated to do this. To me it seems counter intuitive. If the user opens door when UF or BP screen is showing, then Open door screen come up, user opens door and gets alarm. If they hit next, it shows flip dialyzer screen but still alarms if door opened.

3:40 pm

Dara Navaei

DEN-15274 added heating parameters set at the end of the pre-treatment reservoir management

Options
    • -2
    • +2
    ./ModePreTreat.c
3:38 pm

Darren Cox <darren_m@cox.net>

DEN-15229 Code review update.

Options
    • -2
    • +4
    ./ModePreTreat.c
2:42 pm

dcox  (deleted user)

Removed

Removed

2:41 pm

dcox  (deleted user)

Removed

Removed

2:40 pm

dcox  (deleted user)

Reset flag in previous state.

Reset flag in previous state.

2:40 pm

dcox  (deleted user)

Removed

Removed

2:39 pm

dcox  (deleted user)

Done. Reset door flag also.

Done. Reset door flag also.

2:37 pm

Darren Cox <darren_m@cox.net>

DEN-15229 Update based on code review comments.

Options
    • -5
    • +3
    ./ModePreTreat.c
2:27 pm

Dara Navaei

Merged DEN-15274

Options
    • -10
    • +195
    ./ModePreTreat.c
    • -14
    • +15
    ./ModeStandby.c
    • -6
    • +20
    ./SelfTests.c
  4. … 2 more files in changeset.
2:21 pm

Dara Navaei

DEN-15274 work in progress

Options
    • -5
    • +9
    ./ModePreTreat.c
11:43 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./SelfTests.c
  2. … 2 more files in changeset.
11:40 am

Sean Nash

11:32 am

Michael Garthwaite , dcox  (deleted user) and jtaylor  (deleted user)

11:24 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:19 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:18 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:18 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:18 am

Sean Nash

I don't see fix.

I don't see fix.