Modes

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'DEN-15229-fw-dpi-pump-on-during-inverted-dialyzer' into staging

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Merge branch 'DEN-15229-fw-dpi-pump-on-during-inverted-dialyzer' into develop

Merge branch 'staging' into DEN-15196-DIAL-251

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-15274 fixed a typo

Merge branch 'DEN-15274-hd_dg_test_configuration_setup' into develop

Merge branch 'staging' into DEN-15274-hd_dg_test_configuration_setup

  1. … 1 more file in changeset.
DEN-15274 addressed the code review comment

  1. … 1 more file in changeset.
Done

Done

Done

Done

HD-DIAL-252_Request Create Dialin Command TO Enable Air Bubble Alarm IN Service Mode Air Bubble
HD-DIAL-252_Request Create Dialin Command TO Enable Air Bubble Alarm IN Service Mode Air Bubble
Fixed merge conflicts from DIAL-252.

  1. … 1 more file in changeset.
DIAL-252: Update to standby mode to handle alarms w/ stop property (will close valves).

Correct, no longer required. Removed.

Correct, no longer required. Removed.

Reset proper flag.

Reset proper flag.

DEN-15229 Code review changes. Clear flag, no need to check door when required to be shut.

We are (I think now) allowing door open in first 2 states (UF and invert dialyzer), so should not be getting door open alarm when UI is prompting user to invert dialyzer. When we get to 3rd state (...

We are (I think now) allowing door open in first 2 states (UF and invert dialyzer), so should not be getting door open alarm when UI is prompting user to invert dialyzer. When we get to 3rd state (where we start requiring door to be closed), we are looking for user to connect patient and confirm. UI should be following along with our states and showing appropriate screens.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Doesn't look removed. I'm talking about the call to handlePatientConnectionDoorOpened(). Do we need this now that door closed is required (as set in prior state)?

Doesn't look removed. I'm talking about the call to handlePatientConnectionDoorOpened(). Do we need this now that door closed is required (as set in prior state)?

Doesn't make sense to reset in previous state. You're resetting door opened flag there. I'm talking about patient connect confirm flag used in if statement above.

Doesn't make sense to reset in previous state. You're resetting door opened flag there. I'm talking about patient connect confirm flag used in if statement above.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Merge branch 'DEN-15274-hd_dg_test_configuration_setup' into develop