hdfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 01 Aug 2023
12:38 pm

Sean Nash

I reviewed DEN-15741 which is re: desire to stop DPi if user stopped with button. Everything I see changed in this module seems like a very complicated way to achieve that using properties that I d...

I reviewed DEN-15741 which is re: desire to stop DPi if user stopped with button.
Everything I see changed in this module seems like a very complicated way to achieve that using properties that I don't think were intended for this.
I think all we needed to do was check if user stop alarm is active and, in that special case, stop DPi instead of recirculating dialysate like it usually does in the recirc stop state.

12:29 pm

Sean Nash

Why was all of this necessary?

Why was all of this necessary?

12:18 pm

Sean Nash

Comment is copy. What is this flag for? Is it user requested?

Comment is copy. What is this flag for? Is it user requested?

11:34 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:31 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:44 am

Sean Nash

Done.

Done.

10:42 am

Sean Nash

Done. dryPressureTestsCompleted is only set when test config is active so I don't want to include that in doxygen documentation.

Done. dryPressureTestsCompleted is only set when test config is active so I don't want to include that in doxygen documentation.

10:26 am

wbracken  (deleted user)

Add pressureSelfTestPreNormalStartTime, dryPressureTestsCompleted

Add pressureSelfTestPreNormalStartTime, dryPressureTestsCompleted

10:23 am

wbracken  (deleted user)

Add occlusionBaseLineWasSet

Add occlusionBaseLineWasSet

10:05 am

Dara Navaei

10:04 am

jtaylor  (deleted user)

Monday 31 Jul 2023
4:04 pm

Dara Navaei

HD-DEN-15741_Dpi Does Not Stop When Recirculation IS Paused 2
HD-DEN-15741_Dpi Does Not Stop When Recirculation IS Paused 2
3:46 pm

Sean Nash

3:24 pm

jtaylor  (deleted user)

3:09 pm

Dara Navaei and wbracken  (deleted user)

2:31 pm

Dara Navaei

HD-DEN-15858_NO Timer Countdown IS Visible For The Confirmation OF Chemical Flush Sample
HD-DEN-15858_NO Timer Countdown IS Visible For The Confirmation OF Chemical Flush Sample
2:03 pm

Dara Navaei

HD-DEN-15886_Air Pump Pushes Air Into The Heparin Syringe During Dry Self Tests
HD-DEN-15886_Air Pump Pushes Air Into The Heparin Syringe During Dry Self Tests
10:03 am

Dara Navaei

HD-DEN-16016_Bug Unable TO Start The Saline Bolus 3
HD-DEN-16016_Bug Unable TO Start The Saline Bolus 3
Friday 28 Jul 2023
1:11 pm

jtaylor  (deleted user)

9:33 am

wbracken  (deleted user)

Thursday 27 Jul 2023
3:34 pm

dcox  (deleted user)

3:33 pm

dcox  (deleted user)

11:36 am

jtaylor  (deleted user)

9:31 am

jtaylor  (deleted user)

This is a second, separate branch addressing this ticket, and these changes should only be in develop (for testing) at this point. Eventually, this branch should replace the branch you reverted out...

This is a second, separate branch addressing this ticket, and these changes should only be in develop (for testing) at this point. Eventually, this branch should replace the branch you reverted out of staging.

stopDialysis() almost exactly mirrors the four lines I commented out, except the pump "hardstop" routines also manage the control variables that start and stop the PI controllers. This should still make zero difference to the case Nick is investigating since these changes are local to a saline bolus, which is not run at all while active ultra filtration is being run, and only affect the initial bolus state (0), while stopping the pumps. State 1, puts the pumps back into closed loop control, once the valves separate the patient, the blood and the dialysate from the dialyzer.

8:32 am

Dara Navaei

These changes are in staging right now. Do we have to stop dialysis in this state?

These changes are in staging right now. Do we have to stop dialysis in this state?

Wednesday 26 Jul 2023
4:32 pm

Dara Navaei

4:03 pm

Dara Navaei

HD-DEN-15839_Alarm 199 Triggers During Mid Treatment Saline Bolus
HD-DEN-15839_Alarm 199 Triggers During Mid Treatment Saline Bolus
2:31 pm

jtaylor  (deleted user)

11:08 am

wbracken  (deleted user)

9:44 am

Dara Navaei