hdfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 04 Aug 2023
12:55 pm

James Walter Taylor <jtaylor@diality.com>

DEN-15741-dpi-does-not-stop-when-recirculation-is-paused-2

Remove redundant condition.

Options
    • -1
    • +1
    ./TreatmentRecirc.c
12:55 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:55 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:50 pm

Sean Nash

We already know dialysateRecircBlocked != TRUE here - should this just be a simple "else"?

We already know dialysateRecircBlocked != TRUE here - should this just be a simple "else"?

12:50 pm

jtaylor  (deleted user)

Done.

Done.

12:47 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:47 pm

jtaylor  (deleted user)

Done.

Done.

12:46 pm

Sean Nash

This if condition appears to be redundant. rinsebackTimerCtr is set to zero in states where BP is running, so previous if condition would only be TRUE (rinsebackTimerCtr > 0) if BP not running.

This if condition appears to be redundant. rinsebackTimerCtr is set to zero in states where BP is running, so previous if condition would only be TRUE (rinsebackTimerCtr > 0) if BP not running.

12:31 pm

James Walter Taylor <jtaylor@diality.com>

DEN-15994-rinseback-5-minute-timer-does-not-count-down

Timer displayed only during a break in rinseback.

Options
    • -2
    • +6
    ./Rinseback.c
12:04 pm

Dara Navaei

HD-DENBUG-59_FW Duplicate Alarms Occur During Post Treatment Rinseback And Block Workflow
HD-DENBUG-59_FW Duplicate Alarms Occur During Post Treatment Rinseback And Block Workflow
11:04 am

James Walter Taylor <jtaylor@diality.com>

Merge remote-tracking branch 'origin/DEN-15741-dpi-does-not-stop-when-recirculation-is-paused-2' into develop

Options
    • -44
    • +21
    ./TreatmentRecirc.c
11:02 am

James Walter Taylor <jtaylor@diality.com>

DEN-15741-dpi-does-not-stop-when-recirculation-is-paused-2

Simplified. Addressed CR comments.

Options
    • -44
    • +21
    ./TreatmentRecirc.c
11:00 am

jtaylor  (deleted user)

Done.

Done.

10:47 am

jtaylor  (deleted user)

Done.

Done.

10:35 am

jtaylor  (deleted user)

Done.

Done.

10:20 am

jtaylor  (deleted user)

HD-DEN-15994_Rinseback 5 Minute Timer Does Not Count Down
HD-DEN-15994_Rinseback 5 Minute Timer Does Not Count Down
10:03 am

Sean Nash

Keep resume behavior as it was unless Systems is telling you current behavior is wrong. recircResumeRequested flag gets set to TRUE somewhere else and I think that is the only place where the flag ...

Keep resume behavior as it was unless Systems is telling you current behavior is wrong. recircResumeRequested flag gets set to TRUE somewhere else and I think that is the only place where the flag should be set. I see no reason why it should be set here.

9:57 am

jtaylor  (deleted user)

Done.

Done.

9:40 am

jtaylor  (deleted user)

The user stop alarm drops the recirc state machine into the stopped state (stop alarm property is true). To full resume requires that "OK" is pressed, then "Resume", to continue with recirculation....

The user stop alarm drops the recirc state machine into the stopped state (stop alarm property is true). To full resume requires that "OK" is pressed, then "Resume", to continue with recirculation. Is that the behavior we want, or do we want to continue with only the "OK" acknowledgment?

9:33 am

jtaylor  (deleted user)

9:21 am

James Walter Taylor <jtaylor@diality.com>

DEN-15994-rinseback-5-minute-timer-does-not-count-down

Reverted. Test and expected behavior incorrect.

Options
    • -1
    • +1
    ./Rinseback.c
Thursday 03 Aug 2023
4:45 pm

Sean Nash

Resume requested flag gets set elsewhere (from user clearing alarm -> CAN -> AlarmMgmt -> Modes -> this module) and should not be set here.

Resume requested flag gets set elsewhere (from user clearing alarm -> CAN -> AlarmMgmt -> Modes -> this module) and should not be set here.

4:36 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

4:35 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

4:34 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

4:31 pm

Sean Nash

So this is only going to stop pumps/heater if both block recircs are active. I don't think that's what you want. My understanding of what you're trying to do here is this: 1) if dialysate recirc is...

So this is only going to stop pumps/heater if both block recircs are active. I don't think that's what you want.
My understanding of what you're trying to do here is this:
1) if dialysate recirc is blocked by an active alarm (includes user stop alarm), we should stop DPi and HR. Otherwise, we should run DPi and HR.
2) if user stop alarm is active or we are in any state other than recirc state, we should stop BP. Otherwise, we should run BP to recirculate blood side of circuit.

4:23 pm

Sean Nash

I don't think you need to repeat @details Inputs: and @details Outputs:. Only need those for first row. See other functions for example.

I don't think you need to repeat @details Inputs: and @details Outputs:. Only need those for first row. See other functions for example.

3:28 pm

Sean Nash

Blank line before banner comment.

Blank line before banner comment.

3:24 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:24 pm

Sean Nash

Still more here than should be. Trimmer heater is being turned off twice now. DPo should already be stopped. And VBA/VBV should be handled by state machine I would think unless user stop requiremen...

Still more here than should be. Trimmer heater is being turned off twice now. DPo should already be stopped. And VBA/VBV should be handled by state machine I would think unless user stop requirement talks about valves too - and even if so, valves should only close when user stop alarm is active - nothing to do with recirc properties in alarms.