Modes

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-15741-dpi-does-not-stop-when-recirculation-is-paused-2

Remove redundant condition.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

We already know dialysateRecircBlocked != TRUE here - should this just be a simple "else"?

We already know dialysateRecircBlocked != TRUE here - should this just be a simple "else"?

Done.

Done.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

This if condition appears to be redundant. rinsebackTimerCtr is set to zero in states where BP is running, so previous if condition would only be TRUE (rinsebackTimerCtr > 0) if BP not running.

This if condition appears to be redundant. rinsebackTimerCtr is set to zero in states where BP is running, so previous if condition would only be TRUE (rinsebackTimerCtr > 0) if BP not running.

DEN-15994-rinseback-5-minute-timer-does-not-count-down

Timer displayed only during a break in rinseback.

HD-DENBUG-59_FW Duplicate Alarms Occur During Post Treatment Rinseback And Block Workflow
HD-DENBUG-59_FW Duplicate Alarms Occur During Post Treatment Rinseback And Block Workflow
Merge remote-tracking branch 'origin/DEN-15741-dpi-does-not-stop-when-recirculation-is-paused-2' into develop

DEN-15741-dpi-does-not-stop-when-recirculation-is-paused-2

Simplified. Addressed CR comments.

Done.

Done.

Done.

Done.

Done.

Done.

HD-DEN-15994_Rinseback 5 Minute Timer Does Not Count Down
HD-DEN-15994_Rinseback 5 Minute Timer Does Not Count Down
Keep resume behavior as it was unless Systems is telling you current behavior is wrong. recircResumeRequested flag gets set to TRUE somewhere else and I think that is the only place where the flag ...

Keep resume behavior as it was unless Systems is telling you current behavior is wrong. recircResumeRequested flag gets set to TRUE somewhere else and I think that is the only place where the flag should be set. I see no reason why it should be set here.

Done.

Done.

The user stop alarm drops the recirc state machine into the stopped state (stop alarm property is true). To full resume requires that "OK" is pressed, then "Resume", to continue with recirculation....

The user stop alarm drops the recirc state machine into the stopped state (stop alarm property is true). To full resume requires that "OK" is pressed, then "Resume", to continue with recirculation. Is that the behavior we want, or do we want to continue with only the "OK" acknowledgment?

DEN-15994-rinseback-5-minute-timer-does-not-count-down

Reverted. Test and expected behavior incorrect.

Resume requested flag gets set elsewhere (from user clearing alarm -> CAN -> AlarmMgmt -> Modes -> this module) and should not be set here.

Resume requested flag gets set elsewhere (from user clearing alarm -> CAN -> AlarmMgmt -> Modes -> this module) and should not be set here.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

So this is only going to stop pumps/heater if both block recircs are active. I don't think that's what you want. My understanding of what you're trying to do here is this: 1) if dialysate recirc is...

So this is only going to stop pumps/heater if both block recircs are active. I don't think that's what you want.
My understanding of what you're trying to do here is this:
1) if dialysate recirc is blocked by an active alarm (includes user stop alarm), we should stop DPi and HR. Otherwise, we should run DPi and HR.
2) if user stop alarm is active or we are in any state other than recirc state, we should stop BP. Otherwise, we should run BP to recirculate blood side of circuit.

I don't think you need to repeat @details Inputs: and @details Outputs:. Only need those for first row. See other functions for example.

I don't think you need to repeat @details Inputs: and @details Outputs:. Only need those for first row. See other functions for example.

Blank line before banner comment.

Blank line before banner comment.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Still more here than should be. Trimmer heater is being turned off twice now. DPo should already be stopped. And VBA/VBV should be handled by state machine I would think unless user stop requiremen...

Still more here than should be. Trimmer heater is being turned off twice now. DPo should already be stopped. And VBA/VBV should be handled by state machine I would think unless user stop requirement talks about valves too - and even if so, valves should only close when user stop alarm is active - nothing to do with recirc properties in alarms.