Modes

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
These alarms we're demoting from HD fault should have their ranks demoted to 110 (like DG faults).

These alarms we're demoting from HD fault should have their ranks demoted to 110 (like DG faults).

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Condition is not right. Blood leak recover is only relevant in treatment stop state, so we shouldn't care about that state if we're in dialysis.

Condition is not right. Blood leak recover is only relevant in treatment stop state, so we shouldn't care about that state if we're in dialysis.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

Done

Done

The saline bolus state is checked in the below else if

The saline bolus state is checked in the below else if

I think it would be better to reject here if the saline bolus exec is IDLE (indicates there is no saline bolus in progress to abort). I don't want to pend an abort flag (and open pressure limits) w...

I think it would be better to reject here if the saline bolus exec is IDLE (indicates there is no saline bolus in progress to abort).
I don't want to pend an abort flag (and open pressure limits) when no bolus in in progress.

Also reject if in treatment stop state and recovering from blood leak alarm.

Also reject if in treatment stop state and recovering from blood leak alarm.

Why doesn't treatment stop publish saline bolus (like dialysis)?

Why doesn't treatment stop publish saline bolus (like dialysis)?

Do we reject saline bolus request if blood leak recovery is in progress? I think we should. I don't want a saline bolus requesting pending while blood leak recover is happening.

Do we reject saline bolus request if blood leak recovery is in progress? I think we should. I don't want a saline bolus requesting pending while blood leak recover is happening.

Change to "available" properties (e.g. priority low).

Change to "available" properties (e.g. priority low).

Execute TODO.

Execute TODO.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Yes

Yes

Did you remove this reject reason enum?

Did you remove this reject reason enum?

Done

Done

Update comment to remove max.

Update comment to remove max.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Yes, it is removed.

Yes, it is removed.

Changed the code.

Changed the code.

Is this condition right? What if we're in wait for pumps stop state? What state will saline bolus exec be in when we're done? Idle, right? Shouldn't we wait for that?

Is this condition right? What if we're in wait for pumps stop state? What state will saline bolus exec be in when we're done? Idle, right? Shouldn't we wait for that?

Need to check to see if start bolus signal (request) is pending. As written, we will always go to saline bolus state from any other state.

Need to check to see if start bolus signal (request) is pending. As written, we will always go to saline bolus state from any other state.

What are we doing here?

What are we doing here?

The rest of the conditions will be filled up.

The rest of the conditions will be filled up.