hdfirmware / firmware / App / Services

SystemCommMessages.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 06 Oct 2022
10:47 am

Sean Nash

Is this request for DG only? If so, rename enum to MSG_ID_REQUEST_DG_CPLD_STATUS.

Is this request for DG only? If so, rename enum to MSG_ID_REQUEST_DG_CPLD_STATUS.

Wednesday 05 Oct 2022
6:48 pm

wbracken  (deleted user)

BatteryStatusData is also an input

BatteryStatusData is also an input

Tuesday 04 Oct 2022
6:02 pm

Sean Nash

Add 2 blank lines before test support banner.

Add 2 blank lines before test support banner.

6:01 pm

Sean Nash

Remove extra blank lines. Should only be 1 here.

Remove extra blank lines. Should only be 1 here.

6:01 pm

Sean Nash

Cases should be pulled back one indent (4 spaces) to align with others.

Cases should be pulled back one indent (4 spaces) to align with others.

5:59 pm

Sean Nash

Add blank line after declaration.

Add blank line after declaration.

5:59 pm

Sean Nash

Sort of. You will get something between the ms specified and 1 ms less because you don't know where you are in a given ms when you get your start time. Recommend changing this to 2 ms timeout.

Sort of. You will get something between the ms specified and 1 ms less because you don't know where you are in a given ms when you get your start time.
Recommend changing this to 2 ms timeout.

5:53 pm

Sean Nash

Why not checking payload length?

Why not checking payload length?

5:52 pm

Sean Nash

Keep blank line.

Keep blank line.

5:48 pm

Sean Nash

These FPGA registers are obsolete - h/w is no longer in our design. Need to continue to maintain register space since registers after these have not moved. You can think of these obsolete registers...

These FPGA registers are obsolete - h/w is no longer in our design. Need to continue to maintain register space since registers after these have not moved. You can think of these obsolete registers as "reserved" for future purpose.
Dara, I do think we could rename these register fields to something like Reserved1, Reserved2, ...

5:43 pm

Sean Nash

Monitor execs should be before operation modes exec.

Monitor execs should be before operation modes exec.

5:37 pm

Sean Nash

Why was blank line removed?

Why was blank line removed?

5:29 pm

Sean Nash

Align "=".

Align "=".

5:27 pm

Sean Nash

Add another blank line here.

Add another blank line here.

5:22 pm

Sean Nash

Idea is to re-purpose these (instead of adding new alarms to bottom of enum). We prefer not to collapse the table when an alarm ID goes obsolete so other alarm IDs do not change.

Idea is to re-purpose these (instead of adding new alarms to bottom of enum). We prefer not to collapse the table when an alarm ID goes obsolete so other alarm IDs do not change.

11:53 am

wbracken  (deleted user)

Does didTimeout support a 1ms timeout?

Does didTimeout support a 1ms timeout?

11:07 am

wbracken  (deleted user)

What is the significance of (OBSOLETE)? Applies to several blocks.

What is the significance of (OBSOLETE)? Applies to several blocks.

Monday 03 Oct 2022
4:14 pm

Sean Nash

I think battery pack status, battery pack remaining capacity and charger status would be in a separate message sent by a separate "publish" function, but the timing would just be whenever any of th...

I think battery pack status, battery pack remaining capacity and charger status would be in a separate message sent by a separate "publish" function, but the timing would just be whenever any of the 3 registers (or the 3rd of the 3 if they are always next to each other in enum in same order) has been read (call publish function from the cases where we read one of the 3 registers). If you publish after reading any of the 3, you could sometimes get broadcast 250ms apart. If you publish after reading the last of the 3 in a group (i.e. the status_1, remaining_capacity_1, charger_status_1), the spacing of the broadcast will depend on how many enums are between them.

10:58 am

wbracken  (deleted user)

BatteryStatusData is an input.

BatteryStatusData is an input.

10:48 am

wbracken  (deleted user)

fpgaPersistentAlarmGroup is an input.

fpgaPersistentAlarmGroup is an input.

10:44 am

wbracken  (deleted user)

Are all available ALARM_IDs being removed?

Are all available ALARM_IDs being removed?

10:26 am

Steve Jarpe

OK, I see what you wanted. I have a couple of questions: Is logging of the 3 values (remaining charge, battery status, charger status) in a separate message every 750 ms correct? If so, could that ...

OK, I see what you wanted. I have a couple of questions:
Is logging of the 3 values (remaining charge, battery status, charger status) in a separate message every 750 ms correct?
If so, could that be done by calling the publishBatteryStatusData function when the 3rd value (charger status) is read?

Friday 30 Sep 2022
4:38 pm

Sean Nash

Restore alarm when done.

Restore alarm when done.

4:27 pm

Sean Nash

I think we should just be calling one function to do a single read at a time. If you try to read multiple times back-to-back, the bus reports busy and the read fails. I would keep call to getBatter...

I think we should just be calling one function to do a single read at a time. If you try to read multiple times back-to-back, the bus reports busy and the read fails. I would keep call to getBatteryManagementData() function with the large switch statement as it was with everything there and remove getBatteryStatusData() function altogether.

4:24 pm

Sean Nash

Keep multiple reads of remaining capacity and status in the switch as before.

Keep multiple reads of remaining capacity and status in the switch as before.

4:23 pm

Sean Nash

Keep read for battery charger status here before end of list.

Keep read for battery charger status here before end of list.

4:22 pm

Sean Nash

Dong fixed this.

Dong fixed this.

4:22 pm

Sean Nash

Need to save data to dataPtr so calling function gets the data.

Need to save data to dataPtr so calling function gets the data.

4:21 pm

Sean Nash

I think the enum from commit fbb6603 was fine as it was. I still think we should be doing only 1 read per 250ms interval and I think the one function with the large switch statement based on these ...

I think the enum from commit fbb6603 was fine as it was. I still think we should be doing only 1 read per 250ms interval and I think the one function with the large switch statement based on these enums was the way to achieve that - with the multiple status1..5 and remaining capacity1..5 enums spaced out to get them read more frequently.
And I think the individual cases for the higher frequency registers could just call the high frequency broadcast function whenever a new value is read for those registers. And so the slower broadcast could stay at end of list in that switch statement.

9:00 am

Michael Garthwaite

Do we want this checked into staging?

Do we want this checked into staging?