SystemCommMessages.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fixed.

Fixed.

Fixed.

Fixed.

Fixed.

Fixed.

Shouldnt this be set to 0U instead of 0.0F?

Shouldnt this be set to 0U instead of 0.0F?

This should be U32.

This should be U32.

This should be U32.

This should be U32.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

Should we check for stall in bolus & continuous states?

Should we check for stall in bolus & continuous states?

seems odd to create a variable just for it to be returned. Is this value supposed to be overridable?

seems odd to create a variable just for it to be returned. Is this value supposed to be overridable?

Shouldnt this be set to 0U instead of 0.0F?

Shouldnt this be set to 0U instead of 0.0F?

HD-DEN-14906_Dialyzer DE Prime
HD-DEN-14906_Dialyzer DE Prime
Fixed.

Fixed.

Fixed.

Fixed.

This will hard fault the HD. Please change to getTreatmentParameterU32()

This will hard fault the HD. Please change to getTreatmentParameterU32()

This will hard fault the HD. Please change to getTreatmentParameterU32()

This will hard fault the HD. Please change to getTreatmentParameterU32()

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Compiler will align structures to 32-bits by default. Use "#pragma pack(push,1)" above structure declaration and "#pragma pack(pop)" below declaration to tell the compiler to pack/compress structur...

Compiler will align structures to 32-bits by default. Use "#pragma pack(push,1)" above structure declaration and "#pragma pack(pop)" below declaration to tell the compiler to pack/compress structures to 1 byte (8-bit) alignment.

Can you clarify? Is U08 no longer the size of 1 byte?

Can you clarify? Is U08 no longer the size of 1 byte?

Should pack structure to 1 byte so sizeof() gives you 1 byte size.

Should pack structure to 1 byte so sizeof() gives you 1 byte size.

Should pack structure to 1 byte so sizeof() gives you 1 byte size.

Should pack structure to 1 byte so sizeof() gives you 1 byte size.

Remove 2 blank lines.

Remove 2 blank lines.

I think FALSE was more appropriate. Last param indicates whether this ACK msg is an ACK (T) or NAK (F).

I think FALSE was more appropriate. Last param indicates whether this ACK msg is an ACK (T) or NAK (F).

2 lines appropriate around banner separators like this.

2 lines appropriate around banner separators like this.

Extra blank line.

Extra blank line.