SystemCommMessages.h

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Why removed?

Why removed?

Why removed? I thought we needed this for VC?

Why removed? I thought we needed this for VC?

F has been added.

F has been added.

No. Code removed.

No. Code removed.

If no actions handled in this mode, add a comment saying so.

If no actions handled in this mode, add a comment saying so.

Yes, at bottom of exec function above.

Yes, at bottom of exec function above.

Remove blank line.

Remove blank line.

Can we remove this now?

Can we remove this now?

Check NEARLY_ZERO #define. Value should be 0.00000001F. I believe previous review commented indicated that all floating point #defines should have "F" at the end.

Check NEARLY_ZERO #define. Value should be 0.00000001F. I believe previous review commented indicated that all floating point #defines should have "F" at the end.

SW_CONFIG_ENABLE_VALUE should be first in the conditional.

SW_CONFIG_ENABLE_VALUE should be first in the conditional.

Need #define for minimum vRef

Need #define for minimum vRef

Is the data being published elsewhere?

Is the data being published elsewhere?

Is this supposed to have been removed.

Is this supposed to have been removed.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

General comment - nothing to be done. Generally only need F suffix on #defines as they are not inherently typed. RESOLVED in CODE WALKTHROUGH.

General comment - nothing to be done. Generally only need F suffix on #defines as they are not inherently typed. RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

I don't think this does what we want anymore. Need to revisit VC issue.

I don't think this does what we want anymore. Need to revisit VC issue.

Remove blank line.

Remove blank line.

indent of cases looks too small.

indent of cases looks too small.

Looks like exit normal request (below) will take precedence over this request. Is that intended?

Looks like exit normal request (below) will take precedence over this request. Is that intended?

Update input/outputs throughout.

Update input/outputs throughout.

Add blank line before return.

Add blank line before return.