hdfirmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 27 Apr 2021
5:58 pm

Sean Nash

DEN-7605: Moved alarm data type structure definition to common AlarmDefs.h. Extended syringe pump off persistence from 500ms to 1100ms due to 1 sec speed check interval.

Options
    • -11
    • +0
    ./AlarmMgmt.h
  2. … 1 more file in changeset.
10:48 am

Dara Navaei

Monday 26 Apr 2021
10:42 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:41 am

qnguyen  (deleted user)

Done.

Done.

10:39 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:39 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:39 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:38 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:38 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:37 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:37 am

Quang Nguyen <qnguyen@diality.com>

DEN-7347: Addressed code review

Options
    • -1
    • +2
    ./AlarmMgmt.h
  2. … 2 more files in changeset.
10:36 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

Sean Nash

Only reverse when using == operator

Only reverse when using == operator

10:36 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:19 am

Dara Navaei

That is what I meant. Why are we even passing this when we know the target is 0?

That is what I meant. Why are we even passing this when we know the target is 0?

Sunday 25 Apr 2021
10:32 pm

qnguyen  (deleted user)

Added.

Added.

10:32 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7347: Addressed code reviews

Options
    • -0
    • +1
    ./AlarmMgmt.h
  2. … 5 more files in changeset.
10:22 pm

qnguyen  (deleted user)

Changed to return none.

Changed to return none.

10:21 pm

qnguyen  (deleted user)

Done.

Done.

10:21 pm

qnguyen  (deleted user)

Done.

Done.

10:17 pm

qnguyen  (deleted user)

EMPTY_RESERVOIR_VOLUME_ML is defined as 0.

EMPTY_RESERVOIR_VOLUME_ML is defined as 0.

10:14 pm

qnguyen  (deleted user)

Added.

Added.

10:12 pm

qnguyen  (deleted user)

I think the variable will be used in future to detect incorrect direction. Sean Nash Please elaborate more.

I think the variable will be used in future to detect incorrect direction.
Sean Nash Please elaborate more.

10:10 pm

qnguyen  (deleted user)

Done.

Done.

10:10 pm

qnguyen  (deleted user)

Done.

Done.

10:09 pm

qnguyen  (deleted user)

The function has been removed.

The function has been removed.

10:08 pm

qnguyen  (deleted user)

Done.

Done.