hdfirmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 03 May 2021
11:55 am

Sean Nash

DEN-7605: Addressed more code review comments.

Options
    • -12
    • +80
    ./AlarmMgmt.c
11:40 am

Sean Nash

Fixed.

Fixed.

11:38 am

Sean Nash

Fixed.

Fixed.

11:37 am

Sean Nash

Copy and paste error. Fixed.

Copy and paste error. Fixed.

10:47 am

qnguyen  (deleted user)

Same as above.

Same as above.

10:46 am

qnguyen  (deleted user)

Why do we need to subtract from MAX_ALARM_VOLUME_LEVEL?

Why do we need to subtract from MAX_ALARM_VOLUME_LEVEL?

10:44 am

qnguyen  (deleted user)

These functions need doxygen description.

These functions need doxygen description.

10:26 am

Sean Nash

I agree, but sometimes feel it helps readability.

I agree, but sometimes feel it helps readability.

10:25 am

Sean Nash

Yes, you are right. I will use fwcommon code.

Yes, you are right. I will use fwcommon code.

10:21 am

Sean Nash

Fixed.

Fixed.

10:20 am

Sean Nash

What declaration?

What declaration?

10:18 am

Sean Nash

Dara to refactor the POST test for RTC vs. processor timer so that we expect 1000 ms of processor time after RTC second changes. He and I have discussed this needed change.

Dara to refactor the POST test for RTC vs. processor timer so that we expect 1000 ms of processor time after RTC second changes. He and I have discussed this needed change.

10:17 am

Sean Nash

13 was temporary change for full travel test with Mike. I put it back to 11 for now.

13 was temporary change for full travel test with Mike. I put it back to 11 for now.

10:15 am

Sean Nash

I don't have anything I can do in POST so I removed. There are some checks being done at all times and many checks happening in certain states.

I don't have anything I can do in POST so I removed. There are some checks being done at all times and many checks happening in certain states.

10:14 am

Sean Nash

I think it is safer as is. TRUE = 1. If any other value, will be viewed as FALSE and check fails.

I think it is safer as is. TRUE = 1. If any other value, will be viewed as FALSE and check fails.

10:10 am

pmontazemi  (deleted user)

Parentheses unnecessary.

Parentheses unnecessary.

10:09 am

pmontazemi  (deleted user)

== FALSE instead of != TRUE?

== FALSE instead of != TRUE?

10:02 am

pmontazemi  (deleted user)

No more self-test (and associated self-test state machine) for heparin pump?

No more self-test (and associated self-test state machine) for heparin pump?

10:01 am

pmontazemi  (deleted user)

Change comment from 11 ml to 13 ml if 13 ml is the current placeholder.

Change comment from 11 ml to 13 ml if 13 ml is the current placeholder.

9:59 am

pmontazemi  (deleted user)

Fix which test to get 1000 ms?

Fix which test to get 1000 ms?

9:09 am

qnguyen  (deleted user)

Add blank line between declaration and code.

Add blank line between declaration and code.

9:00 am

qnguyen  (deleted user)

Persistence spell error.

Persistence spell error.

8:57 am

qnguyen  (deleted user)

Should all these alarms be using persistent alarm module from fwcommon? Using persistent alarm module will save some dev test time later on.

Should all these alarms be using persistent alarm module from fwcommon? Using persistent alarm module will save some dev test time later on.

Sunday 02 May 2021
3:24 pm

Sean Nash

HD-DEN-7605_HD DG Self Tests
HD-DEN-7605_HD DG Self Tests
Friday 30 Apr 2021
1:14 pm

Dara Navaei

DEN-8030 tested the current override for the HD valves

Options
    • -0
    • +7
    ./SystemComm.c
    • -0
    • +32
    ./SystemCommMessages.c
    • -0
    • +3
    ./SystemCommMessages.h
  4. … 1 more file in changeset.
Thursday 29 Apr 2021
11:35 am

Dara Navaei

DEN-8030 added override functions for the HD valves

Options
    • -11
    • +0
    ./AlarmMgmt.h
  2. … 2 more files in changeset.
11:03 am

Quang Nguyen <qnguyen@diality.com>

Merge branch 'DEN-7347-dg-hd_dev-post-treatment' into staging

Options
    • -12
    • +3
    ./AlarmMgmt.h
10:56 am

qnguyen  (deleted user)

9:45 am

pmontazemi  (deleted user) and Sean Nash

Tuesday 27 Apr 2021
5:58 pm

Sean Nash

DEN-7605: Moved alarm data type structure definition to common AlarmDefs.h. Extended syringe pump off persistence from 500ms to 1100ms due to 1 sec speed check interval.

Options
    • -11
    • +0
    ./AlarmMgmt.h
  2. … 1 more file in changeset.