hdfirmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 29 Apr
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 25 Jul 2021
4:15 pm

Dara Navaei

DEN-9054 initial commit of the switches

Options
    • -0
    • +12
    ./FPGA.c
    • -0
    • +2
    ./FPGA.h
    • -0
    • +8
    ./SystemComm.c
    • -0
    • +91
    ./SystemCommMessages.c
    • -4
    • +14
    ./SystemCommMessages.h
  6. … 4 more files in changeset.
4:10 pm

Dara Navaei

HD-DEN-9054_DG HD Switches
HD-DEN-9054_DG HD Switches
Saturday 24 Jul 2021
4:06 pm

Dara Navaei

Does the payload length does not match with the payload? In the payload, you have 1 U32 and 2 F32s so should not the length be U32 + 2 * F32?

Does the payload length does not match with the payload? In the payload, you have 1 U32 and 2 F32s so should not the length be U32 + 2 * F32?

3:54 pm

Dara Navaei

Do we not need a battery remaining percent override function for testing?

Do we not need a battery remaining percent override function for testing?

3:51 pm

Dara Navaei

The name of the function does not match with the actual name.

The name of the function does not match with the actual name.

3:49 pm

Dara Navaei

Is it safe to stay in while loop until the hardware responds? I understand that you have a timeout but I thought we still should not do that.

Is it safe to stay in while loop until the hardware responds? I understand that you have a timeout but I thought we still should not do that.

3:34 pm

Dara Navaei

How do you get the status of the battery charge in the self test before you check the whether it is in range?

How do you get the status of the battery charge in the self test before you check the whether it is in range?

3:28 pm

Dara Navaei

I recommend to explicitly name the input and output variables.

I recommend to explicitly name the input and output variables.

3:26 pm

Dara Navaei

Reverse the order of the condition.

Reverse the order of the condition.

3:25 pm

Dara Navaei

Why do you need an else here to zero the counter? Do you not need to 0 it anyways?

Why do you need an else here to zero the counter? Do you not need to 0 it anyways?

Friday 23 Jul 2021
3:54 pm

Dara Navaei

DEN-9054 updated the drivers with non-volatile data management, updated POST functions

Options
    • -1
    • +10
    ./SystemComm.c
    • -2
    • +95
    ./SystemCommMessages.c
    • -1
    • +10
    ./SystemCommMessages.h
  4. … 11 more files in changeset.
11:14 am

Sean Nash

DEN-8886: Added overrides for blood prime volumes. Added safety blood prime volume to be published.

Options
    • -4
    • +12
    ./SystemComm.c
    • -0
    • +64
    ./SystemCommMessages.c
    • -0
    • +6
    ./SystemCommMessages.h
  4. … 3 more files in changeset.
Wednesday 21 Jul 2021
10:26 pm

qnguyen  (deleted user)

HD-DEN-8679_HD Dev Treatment Log
HD-DEN-8679_HD Dev Treatment Log
12:05 pm

Quang Nguyen <qnguyen@diality.com>

DEN-8679: Send alarm events to UI

Options
    • -3
    • +18
    ./AlarmMgmt.c
    • -1
    • +34
    ./SystemCommMessages.c
    • -0
    • +3
    ./SystemCommMessages.h
Monday 19 Jul 2021
3:31 pm

Quang Nguyen <qnguyen@diality.com>

DEN-8679: Added alarm rank table checks

Options
    • -7
    • +9
    ./AlarmMgmt.c
  2. … 1 more file in changeset.
Wednesday 07 Jul 2021
5:21 pm

Dara Navaei

10:47 am

qnguyen  (deleted user) and Sean Nash

10:45 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:45 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:44 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:44 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:44 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:37 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Tuesday 06 Jul 2021
10:02 pm

Dara Navaei

I will address this comment in DEN-9054 (switches) branch.

I will address this comment in DEN-9054 (switches) branch.

2:32 pm

Quang Nguyen <qnguyen@diality.com>

DEN-8679: Fixed temperature sensors data handle error

Options
    • -3
    • +4
    ./SystemCommMessages.c
11:54 am

Quang Nguyen <qnguyen@diality.com>

DEN-8679: Updated temperature sensors data payload structure

Options
    • -4
    • +3
    ./SystemCommMessages.c
  2. … 1 more file in changeset.
Monday 05 Jul 2021
9:29 pm

Dara Navaei

DEN-8030 updated the message ID name

Options
    • -1
    • +1
    ./SystemCommMessages.h
7:27 pm

Dara Navaei

Done

Done

3:06 pm

Dara Navaei

DEN-8030 address code review comments

Options
    • -1
    • +1
    ./SystemCommMessages.c
  2. … 2 more files in changeset.
Sunday 04 Jul 2021
2:20 pm

Dara Navaei

I had a similar function for this.

I had a similar function for this.