Services

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-9054 initial commit of the switches

  1. … 4 more files in changeset.
HD-DEN-9054_DG HD Switches
HD-DEN-9054_DG HD Switches
Does the payload length does not match with the payload? In the payload, you have 1 U32 and 2 F32s so should not the length be U32 + 2 * F32?

Does the payload length does not match with the payload? In the payload, you have 1 U32 and 2 F32s so should not the length be U32 + 2 * F32?

Do we not need a battery remaining percent override function for testing?

Do we not need a battery remaining percent override function for testing?

The name of the function does not match with the actual name.

The name of the function does not match with the actual name.

Is it safe to stay in while loop until the hardware responds? I understand that you have a timeout but I thought we still should not do that.

Is it safe to stay in while loop until the hardware responds? I understand that you have a timeout but I thought we still should not do that.

How do you get the status of the battery charge in the self test before you check the whether it is in range?

How do you get the status of the battery charge in the self test before you check the whether it is in range?

I recommend to explicitly name the input and output variables.

I recommend to explicitly name the input and output variables.

Reverse the order of the condition.

Reverse the order of the condition.

Why do you need an else here to zero the counter? Do you not need to 0 it anyways?

Why do you need an else here to zero the counter? Do you not need to 0 it anyways?

DEN-9054 updated the drivers with non-volatile data management, updated POST functions

  1. … 11 more files in changeset.
DEN-8886: Added overrides for blood prime volumes. Added safety blood prime volume to be published.

  1. … 3 more files in changeset.
HD-DEN-8679_HD Dev Treatment Log
HD-DEN-8679_HD Dev Treatment Log
DEN-8679: Send alarm events to UI

DEN-8679: Added alarm rank table checks

  1. … 1 more file in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

I will address this comment in DEN-9054 (switches) branch.

I will address this comment in DEN-9054 (switches) branch.

DEN-8679: Fixed temperature sensors data handle error

DEN-8679: Updated temperature sensors data payload structure

  1. … 1 more file in changeset.
DEN-8030 updated the message ID name

Done

Done

DEN-8030 address code review comments

  1. … 2 more files in changeset.
I had a similar function for this.

I had a similar function for this.