hdfirmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 29 Apr
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 27 Oct 2021
8:53 am

Sean Nash

DEN-9906: Addressed code review comments.

Options
    • -1
    • +1
    ./SystemComm.c
  2. … 5 more files in changeset.
8:49 am

Sean Nash

Fixed.

Fixed.

8:43 am

Sean Nash

Fixed.

Fixed.

8:41 am

Sean Nash

If using a "==" comparison operator, I like to put the literal first so that the compiler will error if I accidentally use "=" instead. Otherwise, I like to put the literal last because it reads be...

If using a "==" comparison operator, I like to put the literal first so that the compiler will error if I accidentally use "=" instead.
Otherwise, I like to put the literal last because it reads better.

8:38 am

Sean Nash

I was thinking 150 was perhaps too fast for UI. But you're right - that only seems to be true at startup. I'll put back to 150.

I was thinking 150 was perhaps too fast for UI. But you're right - that only seems to be true at startup. I'll put back to 150.

8:36 am

Sean Nash

This toggle macro is designed to be generic - so does not assume you are toggling between 0 and 1. Could be toggling between ON and OFF or OPEN and CLOSED, etc... So you have to give the macro the ...

This toggle macro is designed to be generic - so does not assume you are toggling between 0 and 1. Could be toggling between ON and OFF or OPEN and CLOSED, etc... So you have to give the macro the two values that you are toggling between.

8:34 am

Sean Nash

FALSE is simply zero and TRUE is one. In case a boolean is somehow corrupted to something other than 1 or 0, I like to err on the side of safety. So the way I have it now, if isBloodPumpRunning() g...

FALSE is simply zero and TRUE is one. In case a boolean is somehow corrupted to something other than 1 or 0, I like to err on the side of safety.
So the way I have it now, if isBloodPumpRunning() gets corrupted to > 1, it will consider that the pump is not running which is the safer thing to do.

8:30 am

Sean Nash

currentSubMode is already a U32 - no cast needed.

currentSubMode is already a U32 - no cast needed.

Tuesday 26 Oct 2021
10:24 pm

Behrouz NematiPour

Shouldn't be? ( FALSE == isBloodPumpRunning() )

Shouldn't be?

( FALSE == isBloodPumpRunning() )
10:06 pm

Behrouz NematiPour

why here currentMode is casted while currentSubMode didn't? data.opMode = (U32)currentMode; data.subMode = currentSubMode;

why here
currentMode is casted while currentSubMode didn't?

data.opMode = (U32)currentMode;
data.subMode = currentSubMode;
9:45 pm

Behrouz NematiPour

Does a toggle function/macro need the second and third parameters, since whatever value it currently has should be reversed?

Does a toggle function/macro need the second and third parameters, since whatever value it currently has should be reversed?

9:42 pm

Behrouz NematiPour

Could you please explain why the ack timeout increased, is it for POST ack issues or there were other things too?

Could you please explain why the ack timeout increased, is it for POST ack issues or there were other things too?

2:32 pm

hnguyen  (deleted user)

should be if ( TRUE != getRinsebackCompleted() ) for consistency

should be if ( TRUE != getRinsebackCompleted() ) for consistency

2:31 pm

hnguyen  (deleted user)

add last else else { }

add last else
else
{

}

2:31 pm

Sean Nash

Fixed.

Fixed.

2:31 pm

hnguyen  (deleted user)

per MISRA, need the else statement at the end of if { }- else if { } - else if { }- else { }

per MISRA, need the else statement at the end of if { }- else if { } - else if { }- else { }

2:30 pm

hnguyen  (deleted user)

This file is missing a file header

This file is missing a file header

2:29 pm

hnguyen  (deleted user)

Add file header

Add file header

2:29 pm

hnguyen  (deleted user)

Add file header

Add file header

2:29 pm

hnguyen  (deleted user)

Add file header

Add file header

2:28 pm

hnguyen  (deleted user)

Add file header

Add file header

2:10 pm

Sean Nash

Fixed.

Fixed.

2:09 pm

Behrouz NematiPour

Fixed

Fixed

2:09 pm

Behrouz NematiPour

Fixed

Fixed

2:09 pm

Behrouz NematiPour

Fixed

Fixed

2:08 pm

Behrouz NematiPour

Fixed

Fixed

2:08 pm

Behrouz NematiPour

Fixed

Fixed

2:08 pm

Behrouz NematiPour

Fixed

Fixed

2:08 pm

Behrouz NematiPour

Fixed

Fixed

2:03 pm

Behrouz NematiPour

Fixed

Fixed