Activity hdfirmware/firmware/App/Services

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	16
Last Commit:	10 Jun
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Monday 27 Jun 2022

4:14 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
980fb60
changed 2 files
demo_branch, develop and 2 more

Merge remote-tracking branch 'origin/DEN-13141-miscellaneous_hd_issues_bb' into develop

- -1
- +2
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c
… 1 more file in changeset.

Friday 24 Jun 2022

11:39 am

Dara Navaei

More
HD-DEN-12847-1
started review

HD-DEN-12847_SW Dev Sprint 71 Darren

HD-DEN-12847_SW Dev Sprint 71 Darren

Thursday 23 Jun 2022

12:46 pm

Dara Navaei

More
068f4f4
changed 6 files
demo_branch, develop and 2 more

Merged DEN-12931

- -1
- +1
./SystemComm.c
- History
- Source
- Diff
./SystemComm.c
- -103
- +101
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c
… 4 more files in changeset.

Wednesday 22 Jun 2022

4:52 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
f05690e
changed 3 files
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 327 more HD-DEN-13141-6

DEN-13141, DEN-13067 Correct POST messaging for UI.

- -1
- +2
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c
… 2 more files in changeset.

Monday 20 Jun 2022

9:38 am

Dara Navaei

More
b36fc88
changed 4 files
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 330 more HD-DEN-12931-2

DEN-12931 merged staging and resolved the conflicts

- -2
- +2
./FPGA.c
- History
- Source
- Diff
./FPGA.c
- -104
- +102
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c
… 2 more files in changeset.

Saturday 18 Jun 2022

2:40 pm

Dara Navaei

More
88f3fa0
changed 3 files
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 330 more HD-DEN-12931-2

DEN-12931 updated the blood leak driver and FPGA functions

- -15
- +30
./FPGA.c
- History
- Source
- Diff
./FPGA.c
- -2
- +3
./FPGA.h
- History
- Source
- Diff
./FPGA.h
… 1 more file in changeset.

Thursday 16 Jun 2022

5:34 pm

Dara Navaei

More
HD-DEN-12961-1
Closed

5:13 pm

Dara Navaei

More
9051b47
changed 7 files
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 331 more HD-DEN-12847-1 HD-UCOMMITS-19

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./AlarmMgmtSWFaults.h
- History
- Source
- Diff
./AlarmMgmtSWFaults.h
- -1
- +1
./FPGA.c
- History
- Source
- Diff
./FPGA.c
… 5 more files in changeset.

5:08 pm

Dara Navaei and Michael Garthwaite

More
HD-DEN-12961-1
finished reviewing

1:29 pm

Dara Navaei

More
c9e6a09
changed 3 files
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 332 more HD-DEN-12961-1

DEN-12961 addressed VectorCAST issues raised by PiSquare

- -0
- +1
./AlarmMgmtSWFaults.h
- History
- Source
- Diff
./AlarmMgmtSWFaults.h
- -1
- +1
./FPGA.c
- History
- Source
- Diff
./FPGA.c
… 1 more file in changeset.

Wednesday 15 Jun 2022

11:28 am

Dara Navaei

More
c72332b
changed 3 files
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 330 more HD-UCOMMITS-19

DEN-12931 updated the blood leak driver with the latest zero and self test changes

- -0
- +29
./FPGA.c
- History
- Source
- Diff
./FPGA.c
- -0
- +2
./FPGA.h
- History
- Source
- Diff
./FPGA.h
… 1 more file in changeset.

Tuesday 14 Jun 2022

2:30 pm

Dara Navaei

More
bb52809
changed 8 files
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 332 more HD-DEN-12847-1 HD-DEN-12961-1 HD-DEN-12931-2

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
./AlarmMgmt.c
- History
- Source
- Diff
./AlarmMgmt.c
- -1
- +1
./SystemComm.c
- History
- Source
- Diff
./SystemComm.c
- -1
- +1
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c
- -1
- +1
./SystemCommMessages.h
- History
- Source
- Diff
./SystemCommMessages.h
… 4 more files in changeset.

2:23 pm

Dara Navaei

More
HD-DEN-12845-2
Closed

1:30 pm

Michael Garthwaite and Sean Nash

More
HD-DEN-12845-2
finished reviewing

12:48 pm

Dara Navaei

More
585e01a
changed 8 files
demo_branch, develop and 2 more

Merge branch 'DEN-12931-dg_hd_dev-hd_dg_dvt-update' into develop

- -4
- +0
./SystemComm.c
- History
- Source
- Diff
./SystemComm.c
- -0
- +8
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c
… 6 more files in changeset.

12:46 pm

Dara Navaei

More
958b770
changed 2 files
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 330 more HD-DEN-12931-2

DEN-12931 updated the blood leak embedded mode

- -4
- +0
./SystemComm.c
- History
- Source
- Diff
./SystemComm.c
… 1 more file in changeset.

11:09 am

Michael Garthwaite

More
Re: HD-DEN-12845-2
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:59 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:08 am

Dara Navaei

More
6e7270b
changed 3 files
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 333 more HD-DEN-12845-2

DEN-12845 addressed the code review comments

- -8
- +0
./SystemComm.c
- History
- Source
- Diff
./SystemComm.c
- -24
- +0
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c
- -3
- +0
./SystemCommMessages.h
- History
- Source
- Diff
./SystemCommMessages.h

9:49 am

Dara Navaei

More
Re: HD-DEN-12845-2
replied to Sean Nash

Removed the message.

Removed the message.

9:27 am

Sean Nash

More
Re: HD-DEN-12609-2
commented on review

Should probably log ms - so need to multiply by task interval.

Should probably log ms - so need to multiply by task interval.

9:26 am

Sean Nash

More
Re: HD-DEN-12609-2
commented on review

This appears to be a timer counter (task intervals, not ms).

This appears to be a timer counter (task intervals, not ms).

9:24 am

Sean Nash

More
Re: HD-DEN-12609-2
commented on review

These are redundant with above. Keep above definitions as they have the 'F' suffix that we want. Remove these.

These are redundant with above. Keep above definitions as they have the 'F' suffix that we want. Remove these.

9:21 am

Sean Nash

More
Re: HD-DEN-12609-2
commented on review

Add blank line between functions.

Add blank line between functions.

9:20 am

Sean Nash

More
Re: HD-DEN-12609-2
commented on review

Not sure if this is an issue - but looks like this clear alarm condition check can happen even when occlusion level after install hasn't been set yet.

Not sure if this is an issue - but looks like this clear alarm condition check can happen even when occlusion level after install hasn't been set yet.

9:15 am

Sean Nash

More
Re: HD-DEN-12609-2
commented on review

Add space after ifs.

Add space after ifs.

Monday 13 Jun 2022

5:52 pm

Sean Nash

We got recommendation to monitor arterial pressure even when not dialyzing if patient is still connected (so all other treatment mode states other than dialysis when not delivering saline bolus), b...

We got recommendation to monitor arterial pressure even when not dialyzing if patient is still connected (so all other treatment mode states other than dialysis when not delivering saline bolus), but didn't want to apply the user provided limits - just want to monitor for max pressure situation.

3:34 pm

Michael Garthwaite

More
Re: HD-DEN-12845-2
commented on review

Im assuming that this if statement covers sub modes like Saline and Blood Prime. How do we know during blood prime, specifically, that we would not be dealing with an edge case in treatment paramet...

Im assuming that this if statement covers sub modes like Saline and Blood Prime. How do we know during blood prime, specifically, that we would not be dealing with an edge case in treatment parameters for the patient (Ex: -300 mmHg to -270 mmHg) and triggering a false positive alarm?

Note: I dont know actual patient bp values but these are currently acceptable treatment parameters for arterial pressure limits.

11:15 am

Dara Navaei

More
28cd9da
changed 8 files
master, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 333 more HD-DEN-12845-2

Merge branch 'staging' into DEN-12845-sw_dev_sprint_s71_steve

- -2
- +2
./AlarmMgmt.c
- History
- Source
- Diff
./AlarmMgmt.c
- -5
- +11
./SystemComm.c
- History
- Source
- Diff
./SystemComm.c
- -7
- +3
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c
- -4
- +2
./SystemCommMessages.h
- History
- Source
- Diff
./SystemCommMessages.h
… 4 more files in changeset.

11:14 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-06-19 06:14 -0700