Services

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-13460: Attempted fix to DEN-13561 - alarm audio continues after alarm cleared.

Why removed?

Why removed?

Why removed? I thought we needed this for VC?

Why removed? I thought we needed this for VC?

F has been added.

F has been added.

No. Code removed.

No. Code removed.

If no actions handled in this mode, add a comment saying so.

If no actions handled in this mode, add a comment saying so.

Yes, at bottom of exec function above.

Yes, at bottom of exec function above.

Remove blank line.

Remove blank line.

Can we remove this now?

Can we remove this now?

Why?

Why?

Why?

Why?

HD-DEN-13141_Miscellaneous HD Issues BB
HD-DEN-13141_Miscellaneous HD Issues BB
Merged DEN-13460

  1. … 8 more files in changeset.
DEN-13460: Allow alarm minimize in fault or standby modes too.

DEN-13460 updated the code with DVT changes

  1. … 6 more files in changeset.
Check NEARLY_ZERO #define. Value should be 0.00000001F. I believe previous review commented indicated that all floating point #defines should have "F" at the end.

Check NEARLY_ZERO #define. Value should be 0.00000001F. I believe previous review commented indicated that all floating point #defines should have "F" at the end.

SW_CONFIG_ENABLE_VALUE should be first in the conditional.

SW_CONFIG_ENABLE_VALUE should be first in the conditional.

Need #define for minimum vRef

Need #define for minimum vRef

Is the data being published elsewhere?

Is the data being published elsewhere?

Is this supposed to have been removed.

Is this supposed to have been removed.

Merged staging and resolved the conflicts

  1. … 7 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 9 more files in changeset.
DEN-12931: Changed syringe pump calibration to expected DAC voltage. Added verification of calibration.

  1. … 2 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

General comment - nothing to be done. Generally only need F suffix on #defines as they are not inherently typed. RESOLVED in CODE WALKTHROUGH.

General comment - nothing to be done. Generally only need F suffix on #defines as they are not inherently typed. RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.