hdfirmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 29 Apr
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 12 Oct 2022
9:16 am

Sean Nash

This probably warrants a comment.

This probably warrants a comment.

9:12 am

Sean Nash

Is this a TODO? Can we just do it?

Is this a TODO? Can we just do it?

9:11 am

Sean Nash

Why are we checking non-zero here? Seems like we will get stuck here if years really is set to zero.

Why are we checking non-zero here? Seems like we will get stuck here if years really is set to zero.

9:09 am

Michael Garthwaite

This whole block of code ( lines 127 - 178 ) was removed in when staging was merged in and not reflected on crucible.

This whole block of code ( lines 127 - 178 ) was removed in when staging was merged in and not reflected on crucible.

9:01 am

Michael Garthwaite

This whole block of code ( lines 248 - 304 ) was removed in when staging was merged in and not reflected on crucible.

This whole block of code ( lines 248 - 304 ) was removed in when staging was merged in and not reflected on crucible.

8:40 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

8:38 am

Sean Nash

Remove last param.

Remove last param.

8:37 am

Sean Nash

Remove last param.

Remove last param.

8:37 am

Sean Nash

Remove last param.

Remove last param.

8:30 am

Sean Nash

Remove param.

Remove param.

8:29 am

Sean Nash

Add space before last ")"

Add space before last ")"

Monday 10 Oct 2022
1:13 pm

Behrouz NematiPour

12:43 pm

dcox  (deleted user)

Updated to define, added comment.

Updated to define, added comment.

12:41 pm

dcox  (deleted user)

Updated.

Updated.

12:40 pm

dcox  (deleted user)

This enum is HD to UI only. Updated comments.

This enum is HD to UI only. Updated comments.

11:00 am

dcox  (deleted user)

Rotor and motor turn in opposite directions. This ensures true check of motor and rotor speed, regardless of direction. Also, measMotorSpeed is absolute value in this function. Direction check is d...

Rotor and motor turn in opposite directions. This ensures true check of motor and rotor speed, regardless of direction. Also, measMotorSpeed is absolute value in this function. Direction check is done in a different function.

10:59 am

dcox  (deleted user)

Rotor and motor turn in opposite directions. This ensures true check of motor and rotor speed, regardless of direction. Also, measMotorSpeed is absolute value in this function. Direction check is d...

Rotor and motor turn in opposite directions. This ensures true check of motor and rotor speed, regardless of direction. Also, measMotorSpeed is absolute value in this function. Direction check is done in a different function.

10:59 am

dcox  (deleted user)

Rotor and motor turn in opposite directions. This ensures true check of motor and rotor speed, regardless of direction. Also, measMotorSpeed is absolute value in this function. Direction check is d...

Rotor and motor turn in opposite directions. This ensures true check of motor and rotor speed, regardless of direction. Also, measMotorSpeed is absolute value in this function. Direction check is done in a different function.

10:37 am

dcox  (deleted user)

Updated.

Updated.

10:36 am

dcox  (deleted user)

Updated.

Updated.

10:36 am

dcox  (deleted user)

Done.

Done.

10:36 am

dcox  (deleted user)

Updated.

Updated.

10:35 am

dcox  (deleted user)

Comment removed, Ack kept.

Comment removed, Ack kept.

10:35 am

dcox  (deleted user)

done.

done.

10:34 am

dcox  (deleted user)

updated to use pointer.

updated to use pointer.

Friday 07 Oct 2022
10:50 am

Sean Nash

Convention is to put spaces around operators like = and <.

Convention is to put spaces around operators like = and <.

10:50 am

Sean Nash

Convention is to put spaces around operators like = and <.

Convention is to put spaces around operators like = and <.

10:48 am

Sean Nash

request_id is an enum, not a U32. Copy enum to a local U32, then memcpy the local U32. Probably same for other params below - please check.

request_id is an enum, not a U32. Copy enum to a local U32, then memcpy the local U32. Probably same for other params below - please check.

10:35 am

Sean Nash

I think getting here would maybe indicate flush/disinfect ended naturally or faulted out while waiting for confirmation. I think appropriate thing to do is to send a reject back to UI? No alarm.

I think getting here would maybe indicate flush/disinfect ended naturally or faulted out while waiting for confirmation. I think appropriate thing to do is to send a reject back to UI? No alarm.

10:29 am

Sean Nash

Should add a break from loop here.

Should add a break from loop here.