Services

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-14000 Code review updates.

  1. … 2 more files in changeset.
Can we assign request_type here at declaration instead of below?

Can we assign request_type here at declaration instead of below?

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Add // MSG_ID_... comment above prototype.

Add // MSG_ID_... comment above prototype.

Add a /// doxygen comment above this new declaration.

Add a /// doxygen comment above this new declaration.

Remove extra blank line.

Remove extra blank line.

Should say "private definitions".

Should say "private definitions".

Remove extra blank line.

Remove extra blank line.

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

DEN-13903: DIAL-204: code review comments.

  1. … 4 more files in changeset.
This probably warrants a comment.

This probably warrants a comment.

Is this a TODO? Can we just do it?

Is this a TODO? Can we just do it?

Why are we checking non-zero here? Seems like we will get stuck here if years really is set to zero.

Why are we checking non-zero here? Seems like we will get stuck here if years really is set to zero.

This whole block of code ( lines 127 - 178 ) was removed in when staging was merged in and not reflected on crucible.

This whole block of code ( lines 127 - 178 ) was removed in when staging was merged in and not reflected on crucible.

This whole block of code ( lines 248 - 304 ) was removed in when staging was merged in and not reflected on crucible.

This whole block of code ( lines 248 - 304 ) was removed in when staging was merged in and not reflected on crucible.

Remove extra blank line.

Remove extra blank line.

Remove last param.

Remove last param.

Remove last param.

Remove last param.

Remove last param.

Remove last param.

Remove param.

Remove param.

Add space before last ")"

Add space before last ")"

DEN-14000 Merge to develop.

  1. … 2 more files in changeset.
DEN-14000 Refactor Confirm Request to be managed in Operation Mode and allow multiple requests.

  1. … 3 more files in changeset.
Merge branch 'DEN-14000-sw_dev_sprint_80_darren' into develop

  1. … 2 more files in changeset.