hdfirmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 21 Dec 2022
1:12 pm

Dara Navaei

DEN-14307 addressed the code review comments

Options
    • -1
    • +1
    ./AlarmMgmt.c
1:12 pm

Dara Navaei

Done

Done

1:07 pm

Dara Navaei

Data is a local variable but added alarmButtonBlockers

Data is a local variable but added alarmButtonBlockers

12:02 pm

wbracken  (deleted user)

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

12:01 pm

wbracken  (deleted user)

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

11:59 am

wbracken  (deleted user)

data and alarmButtonBlockers?

data and alarmButtonBlockers?

11:57 am

wbracken  (deleted user)

Should alarmButtonBlockers and ALARM_TABLE also be added.

Should alarmButtonBlockers and ALARM_TABLE also be added.

11:55 am

wbracken  (deleted user)

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

11:55 am

wbracken  (deleted user)

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

11:55 am

wbracken  (deleted user)

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

10:02 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:47 am

Sean Nash

DEN-14307: Removed obsolete build switches.

Options
    • -107
    • +0
    ./FPGA.c
    • -5
    • +0
    ./WatchdogMgmt.c
  3. … 4 more files in changeset.
9:31 am

Dara Navaei

DEN-14307 addressed code review comments

Options
    • -7
    • +7
    ./AlarmMgmt.c
    • -2
    • +2
    ./SystemCommMessages.c
  3. … 1 more file in changeset.
9:30 am

Dara Navaei

Done

Done

9:29 am

Dara Navaei

Done

Done

9:28 am

Dara Navaei

I think we still want to keep the comment. It has not been implemented yet.

I think we still want to keep the comment. It has not been implemented yet.

9:27 am

Dara Navaei

Done

Done

9:24 am

Dara Navaei

Done

Done

9:21 am

Dara Navaei

Done

Done

9:19 am

Dara Navaei

Fixed the setServiceTime function. Thanks.

Fixed the setServiceTime function. Thanks.

9:17 am

Dara Navaei

Done.

Done.

Tuesday 20 Dec 2022
3:22 pm

Sean Nash

Agree, though this comment belongs in NVDataMgmt.c where setServiceTime() is lives. That function should return TRUE if successful.

Agree, though this comment belongs in NVDataMgmt.c where setServiceTime() is lives. That function should return TRUE if successful.

3:15 pm

Sean Nash

All of these terms are integers and cast is coming too late (after division). To prevent loss of precision on division, we want to cast both sides of the division as floats.

All of these terms are integers and cast is coming too late (after division). To prevent loss of precision on division, we want to cast both sides of the division as floats.

Monday 19 Dec 2022
6:08 pm

Sean Nash

If we're using air pump (nominal case), we don't need to defer DG fills anymore - can signal these wherever we used to start filling before we added this delay.

If we're using air pump (nominal case), we don't need to defer DG fills anymore - can signal these wherever we used to start filling before we added this delay.

6:01 pm

Sean Nash

Add comment explaining what we're doing here.

Add comment explaining what we're doing here.

6:00 pm

Sean Nash

Agree not necessary, but also no harm. This may have been done in response to a code review comment in early days.

Agree not necessary, but also no harm. This may have been done in response to a code review comment in early days.

5:58 pm

Sean Nash

This new else if would not be necessary I think if the pump were just turned off on way out of closed state (my comment from closed state handler).

This new else if would not be necessary I think if the pump were just turned off on way out of closed state (my comment from closed state handler).

5:57 pm

Sean Nash

Why are we not turning off the air pump here? I do not see any delay in open state where pump is turned off, so we are only delaying by 50 ms. And I don't see any reason why pump should be on while...

Why are we not turning off the air pump here? I do not see any delay in open state where pump is turned off, so we are only delaying by 50 ms. And I don't see any reason why pump should be on while VBT is open.

5:43 pm

Sean Nash

Indent 2nd and 3rd line of if by 2 more spaces.

Indent 2nd and 3rd line of if by 2 more spaces.

5:43 pm

Sean Nash

Capitalize Level and Ctr. Add doxygen comment.

Capitalize Level and Ctr. Add doxygen comment.