hdfirmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 19 Jan 2023
11:36 am

Michael Garthwaite

Merge branch 'DEN-14328-hd-event-issues' into develop

Options
    • -27
    • +27
    ./SystemCommMessages.c
    • -1
    • +1
    ./SystemCommMessages.h
    • -2
    • +14
    ./WatchdogMgmt.c
  4. … 4 more files in changeset.
11:28 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./AlarmMgmt.c
    • -2
    • +2
    ./AlarmMgmt.h
    • -2
    • +2
    ./WatchdogMgmt.c
    • -2
    • +2
    ./WatchdogMgmt.h
  5. … 10 more files in changeset.
11:23 am

Dara Navaei

10:59 am

dcox  (deleted user)

Old transfer was 600mL, new is 300mL. Res 1 should end up with 1500 so added 300 to baseline, Res 2 was previously ending with 500. Do we want it to end R2 with 300?

Old transfer was 600mL, new is 300mL. Res 1 should end up with 1500 so added 300 to baseline, Res 2 was previously ending with 500. Do we want it to end R2 with 300?

10:55 am

dcox  (deleted user)

Updated for only reservoir 2 fill state.

Updated for only reservoir 2 fill state.

10:47 am

wbracken  (deleted user) and Sean Nash

9:27 am

Sean Nash

There are two dialysate prime states. First goes through dialyzer and both DPs are running and we still want 300 rate. Second bypasses dialyzer and only DPi is running and we want 600 rate.

There are two dialysate prime states. First goes through dialyzer and both DPs are running and we still want 300 rate. Second bypasses dialyzer and only DPi is running and we want 600 rate.

9:26 am

Sean Nash

This looks like we're skipping draining of reservoirs before doing any filling if priming disabled. I think we always want to drain both reservoirs first. Also, if we go to fill state like this, wi...

This looks like we're skipping draining of reservoirs before doing any filling if priming disabled. I think we always want to drain both reservoirs first.
Also, if we go to fill state like this, will it do a flush or a normal fill? I think it will do a flush fill since flushed flag is still FALSE.

9:19 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:17 am

Sean Nash

We should initialize these with a loop iterating through each reservoir (in case a reservoir is added/removed at some point).

We should initialize these with a loop iterating through each reservoir (in case a reservoir is added/removed at some point).

9:16 am

Sean Nash

This should probably be 600 since we'll only be transferring 300 to R1 in wet self-tests.

This should probably be 600 since we'll only be transferring 300 to R1 in wet self-tests.

9:02 am

wbracken  (deleted user)

Alignment

Alignment

Wednesday 18 Jan 2023
3:34 pm

Dara Navaei

DEN-14559 updated the code to be able to run POST requested by the Dialin user

Options
    • -0
    • +12
    ./AlarmMgmt.c
    • -0
    • +1
    ./AlarmMgmt.h
    • -0
    • +12
    ./WatchdogMgmt.c
    • -1
    • +2
    ./WatchdogMgmt.h
  5. … 10 more files in changeset.
1:06 pm

Sean Nash

Merge branch 'staging' into DEN-14549-system-fault-after-resuming-heparin-then-starting-saline-bolus-during-treatment

Options
    • -5
    • +7
    ./SystemCommMessages.c
    • -2
    • +2
    ./SystemCommMessages.h
  3. … 2 more files in changeset.
12:38 pm

dcox  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

12:21 pm

Sean Nash

DEN-14549: Added function to see if an alarm condition is detected. Added a function to determine whether A/C power loss condition is detected and used them where needed.

Options
    • -1
    • +38
    ./AlarmMgmt.c
    • -0
    • +1
    ./AlarmMgmt.h
    • -0
    • +1
    ./AlarmMgmtSWFaults.h
  4. … 5 more files in changeset.
11:55 am

dcox  (deleted user)

Yes, may need to be done when merging to Staging. Is this flag used independently anywhere? Or planned to be?

Yes, may need to be done when merging to Staging. Is this flag used independently anywhere? Or planned to be?

11:53 am

dcox  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:50 am

Sean Nash

I don't think I have this bug fix in my branch. Needs to be addressed in a more recent branch.

I don't think I have this bug fix in my branch. Needs to be addressed in a more recent branch.

11:48 am

Sean Nash

Good catch. Updated Voltages.c to behave same as Battery.c (trigger the correction alarm depending on whether in a treatment mode).

Good catch. Updated Voltages.c to behave same as Battery.c (trigger the correction alarm depending on whether in a treatment mode).

11:15 am

dcox  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:13 am

dcox  (deleted user)

This check for _IN_TREATMENT may need to be added to Valves.c ALARM_ID_HD_AC_POWER_LOST check from recent bug fix. Both look to be checked in every case. Is this flag used independently anywhere?

This check for _IN_TREATMENT may need to be added to Valves.c ALARM_ID_HD_AC_POWER_LOST check from recent bug fix. Both look to be checked in every case. Is this flag used independently anywhere?

11:08 am

dcox  (deleted user)

Treatment mode check is not done in Voltages.c, so ALARM_ID_HD_AC_POWER_LOST will be set there in addition to ALARM_ID_HD_AC_POWER_LOST_IN_TREATMENT here. Is this the expected behavior?

Treatment mode check is not done in Voltages.c, so ALARM_ID_HD_AC_POWER_LOST will be set there in addition to ALARM_ID_HD_AC_POWER_LOST_IN_TREATMENT here. Is this the expected behavior?

Tuesday 17 Jan 2023
2:58 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:57 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:56 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:25 pm

dcox  (deleted user)

This config check is unnecessary and should be removed. The vars should always be initialized. Enable/Disable Alarms are done when checking the direction, etc.

This config check is unnecessary and should be removed. The vars should always be initialized. Enable/Disable Alarms are done when checking the direction, etc.

1:05 pm

James Walter Taylor <jtaylor@diality.com>

HD-DEN-14561_Release Preprocessor Flag Specifies Code That Conflicts With SW Config Debug

Corrected _RELEASE_ logic, release build executes the same block as non debug selection

Options
    • -10
    • +11
    ./AlarmMgmt.c
  2. … 3 more files in changeset.
1:04 pm

Sean Nash

They're kind of different. The stop function is fairly straightforward and is part of syringe pump driver. The start function is a lot more complex as it needs to figure out what it should be doing...

They're kind of different. The stop function is fairly straightforward and is part of syringe pump driver. The start function is a lot more complex as it needs to figure out what it should be doing and is part of treatment mode module.

12:13 pm

dcox  (deleted user)

Inconsistent naming here. StopSyringePump, StartHeparinPump. Suggest using same name for both.

Inconsistent naming here. StopSyringePump, StartHeparinPump. Suggest using same name for both.