Services

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-14689: reworked message len checks for it to be grabbed by automation

Why removed?

Why removed?

Merge branch 'DEN-14689-messaging-bugs' into develop

Change cmd to prompt

Change cmd to prompt

How do we wish to handle the output of the automated script? It currently does not handle conditional statements to determine ack requiredness. If set to false, the output is: 0x4A MSG_ID_UI_PATI...

How do we wish to handle the output of the automated script? It currently does not handle conditional statements to determine ack requiredness.

If set to false, the output is:

0x4A MSG_ID_UI_PATIENT_DISCONNECTION_CONFIRM hdfirmware response COMM_BUFFER_OUT_CAN_HD_2_UI ACK_REQUIRED PAYLOAD

which is incorrect to what the code is doing. We have 2 different implementations of calling sendAckResponseMsg()


1. sendAckResponseMsg( (MSG_ID_T)message->hdr.msgID, COMM_BUFFER_OUT_CAN_HD_2_UI, FALSE );

  1. if we dont meet an expected condition. Later in the handler we will call a response message with the response message calling:
    serializeMessage( msg, COMM_BUFFER_OUT_CAN_DG_2_HD, ACK_REQUIRED );


2. sendAckResponseMsg( (MSG_ID_T)message->hdr.msgID, COMM_BUFFER_OUT_CAN_HD_2_UI, result );

  1. a conditional based on?


Please review the FW_Message_list.csv within latest develop & staging builds to understand how the automated script is determining "ack requireness"

DEN-14689: removed dg checkin message as it is no longer needed.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Remove blank line.

Remove blank line.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

FALSE was right.

FALSE was right.

Add space after "(".

Add space after "(".

Remove extra blank line.

Remove extra blank line.

Add blank line before comment.

Add blank line before comment.

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Merge branch 'DEN-14689-messaging-bugs' into develop

DEN-14689: updated active alarm list response to have a payload contained within a struct

  1. … 1 more file in changeset.
Merge branch 'DEN-14689-messaging-bugs' into develop

DEN-14689: fixed compiler warning.

DEN-14689: updated message protocols to be contained within structs. Fixed <32 bit fields to be compiled as their respective byte size.

Merge branch 'staging' into DEN-14689-messaging-bugs

  1. … 3 more files in changeset.
DEN-14763 changed the sizeof of message 0x98 to be able to pick up with the script

Fixed merge conflict.

  1. … 6 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 13 more files in changeset.