hdfirmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 30 Mar 2023
7:06 pm

Dara Navaei

Merge branch 'DEN-14999-alarm-table-updates' into develop

Options
    • -1
    • +11
    ./SystemCommMessages.c
  2. … 1 more file in changeset.
7:06 pm

Dara Navaei

DEN-14999, DEN-15030 fixed the start DG command to only get the acid and bicarb parameters if the HD is sending a start command

Options
    • -3
    • +9
    ./SystemCommMessages.c
7:00 pm

Sean Nash

My branch (and your DG branch) changed this to 10.

My branch (and your DG branch) changed this to 10.

7:00 pm

Sean Nash

Do you have data showing UI disappeared for > 5 seconds? Is this necessary?

Do you have data showing UI disappeared for > 5 seconds? Is this necessary?

6:59 pm

Sean Nash

Change back to 200.

Change back to 200.

5:28 pm

Sean Nash

Merge branch 'DEN-14999-alarm-table-updates' of ssh://dvm-linux02:7999/hd/hdfirmware into DEN-14999-alarm-table-updates

Options
    • -2
    • +4
    ./SystemCommMessages.c
5:28 pm

Sean Nash

DEN-14999: Fixed sending of DG valve settings command.

Options
    • -0
    • +2
    ./SystemCommMessages.c
4:12 pm

Dara Navaei

DEN-14999, DEN-15030 updated the DG start command payload

Options
    • -2
    • +4
    ./SystemCommMessages.c
2:22 pm

Sean Nash

12:23 pm

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

11:33 am

Sean Nash

I don't know. I believe check in msg should have no payload, but it usually does have a u32 of unknown purpose. I have found that the very first check-in after power up has no payload according to ...

I don't know. I believe check in msg should have no payload, but it usually does have a u32 of unknown purpose. I have found that the very first check-in after power up has no payload according to candump and this was causing alarm 46. Until UI sorts this out, I am not going to check payload.

11:26 am

Darren Cox <darren_m@cox.net>

Merge DEN-14860 branch

Options
    • -10
    • +10
    ./Reservoirs.c
10:18 am

Michael Garthwaite

What is the other flavor of UI check in message. If it is a different size, shouldn't it be its own separate message?

What is the other flavor of UI check in message. If it is a different size, shouldn't it be its own separate message?

9:47 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

9:44 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

9:41 am

Sean Nash

DEN-14999: Removed obsolete/redundant alarms. Addressed code review comment.

Options
    • -1
    • +1
    ./SystemComm.c
  2. … 2 more files in changeset.
9:40 am

Sean Nash

Warning (13 min) removed since no longer alarming at 15 min.

Warning (13 min) removed since no longer alarming at 15 min.

9:38 am

Sean Nash

Fixed.

Fixed.

Wednesday 29 Mar 2023
4:30 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

4:11 pm

James Walter Taylor <jtaylor@diality.com>

DEN-15016-system-faults-during-treatment-then-returns-to-the-standby-screen

Increased message ACK timeouts, for both DG and UI.

Options
    • -3
    • +3
    ./SystemComm.c
4:01 pm

Dara Navaei

HD-DEN-15016_System Faults During Treatment Then Returns TO The Standby Screen
HD-DEN-15016_System Faults During Treatment Then Returns TO The Standby Screen
2:29 pm

dcox  (deleted user)

Updated all headers.

Updated all headers.

2:27 pm

Darren Cox <darren_m@cox.net>

DEN-14860 Updated headers per code review comment.

Options
    • -10
    • +10
    ./Reservoirs.c
12:23 pm

wbracken  (deleted user)

Add timeOfLastUICheckin and uiDidCommunicate.

Add timeOfLastUICheckin and uiDidCommunicate.

11:22 am

Sean Nash

Merge branch 'DEN-14999-alarm-table-updates' into develop

Options
    • -10
    • +1
    ./SystemCommMessages.c
11:20 am

Sean Nash

DEN-14999: Removed minimum UF change. Added 250ms of persistence to HD fluid leak alarm. Increased no ack retries from 8 to 10 because UI needed more time at startup. Accept UI check-in message regardless of payload size because UI is sending 2 different flavors of check-in message.

Options
    • -1
    • +2
    ./SystemComm.c
    • -10
    • +1
    ./SystemCommMessages.c
  3. … 2 more files in changeset.
Tuesday 28 Mar 2023
2:23 pm

wbracken  (deleted user)

Does the new code result in one less TRUE comparison? Can rinsebackTimerCtr ever be greater than RINSEBACK_DONE_WARNING_TIME?

Does the new code result in one less TRUE comparison? Can rinsebackTimerCtr ever be greater than RINSEBACK_DONE_WARNING_TIME?

1:22 pm

Darren Cox <darren_m@cox.net>

Merge DEN-14860

Options
    • -47
    • +86
    ./Reservoirs.c
    • -1
    • +1
    ./Reservoirs.h
  3. … 1 more file in changeset.
11:33 am

Sean Nash

9:24 am

Sean Nash

Fixed merge conflicts.

Options
    • -18
    • +146
    ./SystemCommMessages.c
    • -2
    • +17
    ./SystemCommMessages.h
  3. … 8 more files in changeset.