hdfirmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 21 Apr 2023
2:59 pm

James Walter Taylor <jtaylor@diality.com>

DEN-14980-unable-to-resume-after-hd-unit-plugged-back-in-pre-treatment-after-priming

Additional Code review comments addressed.

Options
    • -12
    • +11
    ./AlarmMgmt.c
2:16 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./AlarmMgmt.c
  2. … 8 more files in changeset.
2:06 pm

Sean Nash

1:51 pm

Dara Navaei

1:42 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:41 pm

Sean Nash

This should probably be up top before the outer if (i.e. checked every time) as there is no dependency on the given alarm ID.

This should probably be up top before the outer if (i.e. checked every time) as there is no dependency on the given alarm ID.

1:31 pm

Sean Nash

Comment doesn't seem to match how timer is used (to decide whether to block alarm trigger).

Comment doesn't seem to match how timer is used (to decide whether to block alarm trigger).

12:15 pm

dcox  (deleted user)

12:15 pm

jtaylor  (deleted user)

AlarmMgmt.h reverted. The timer moved to static AlarmMgnt local.

AlarmMgmt.h reverted. The timer moved to static AlarmMgnt local.

12:15 pm

James Walter Taylor <jtaylor@diality.com>

DEN-14980-unable-to-resume-after-hd-unit-plugged-back-in-pre-treatment-after-priming

Moved Alarms blocked timer variable, per review.

Options
    • -6
    • +7
    ./AlarmMgmt.c
    • -1
    • +0
    ./AlarmMgmt.h
11:42 am

Sean Nash

Not needed. Remove.

Not needed. Remove.

11:15 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:14 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:08 am

Sean Nash

DEN-15183: Fixed compiler warning.

Options
    • -0
    • +1
    ./AlarmMgmt.c
11:06 am

Sean Nash

DEN-15183: Addressed code review comments.

Options
    • -2
    • +2
    ./AlarmMgmt.c
  2. … 1 more file in changeset.
11:06 am

Sean Nash

Fixed.

Fixed.

11:04 am

Sean Nash

Fixed.

Fixed.

10:23 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

8:18 am

jtaylor  (deleted user)

Done.

Done.

8:17 am

James Walter Taylor <jtaylor@diality.com>

DEN-14980-unable-to-resume-after-hd-unit-plugged-back-in-pre-treatment-after-priming

Comments updated.

Options
    • -1
    • +1
    ./AlarmMgmt.c
Thursday 20 Apr 2023
2:45 pm

James Walter Taylor <jtaylor@diality.com>

DEN-14980-unable-to-resume-after-hd-unit-plugged-back-in-pre-treatment-after-priming

Updated allowed alarms during PF

Options
    • -1
    • +3
    ./AlarmMgmt.c
11:30 am

James Walter Taylor <jtaylor@diality.com>

DEN-14980-unable-to-resume-after-hd-unit-plugged-back-in-pre-treatment-after-priming

Switched to CPLD power loss function, rather than alarm.

Options
    • -4
    • +5
    ./AlarmMgmt.c
11:25 am

wbracken  (deleted user)

Add alarmStatus to header

Add alarmStatus to header

11:24 am

Sean Nash

DEN-15183: Prevent alarm user options while AC power is out.

Options
    • -1
    • +10
    ./AlarmMgmt.c
11:14 am

wbracken  (deleted user)

Add testStartTime, audioTestStartTime, alarmAudioTestToneRequested and to header

Add testStartTime, audioTestStartTime, alarmAudioTestToneRequested and to header

11:11 am

James Walter Taylor <jtaylor@diality.com>

DEN-14980-unable-to-resume-after-hd-unit-plugged-back-in-pre-treatment-after-priming

Moved block to choke point in activateAlarm2Data. Bock all alarms, rather than sub-rank 10 and above.

Options
    • -61
    • +69
    ./AlarmMgmt.c
11:07 am

wbracken  (deleted user)

Extra blank line.

Extra blank line.

11:02 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:02 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

8:23 am

Sean Nash

Fixed.

Fixed.