hdfirmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 24 Apr 2023
3:21 pm

James Walter Taylor <jtaylor@diality.com>

DEN-14980-unable-to-resume-after-hd-unit-plugged-back-in-pre-treatment-after-priming

Addressed code review comments.

Options
    • -10
    • +10
    ./AlarmMgmt.c
3:20 pm

jtaylor  (deleted user)

Done.

Done.

1:55 pm

Sean Nash

Was expecting you to move if, not else. Doesn't make sense to check alarm (line 359..361) before validating alarm (line 364).

Was expecting you to move if, not else.
Doesn't make sense to check alarm (line 359..361) before validating alarm (line 364).

12:25 pm

jtaylor  (deleted user)

Thank you - corrected.

Thank you - corrected.

12:25 pm

James Walter Taylor <jtaylor@diality.com>

DEN-14980-unable-to-resume-after-hd-unit-plugged-back-in-pre-treatment-after-priming

Addressed paren typo from code review

Options
    • -4
    • +4
    ./AlarmMgmt.c
9:41 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:40 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:40 am

Sean Nash

This if should be the outermost if (before the if above) so that the else with the s/w fault aligns with it.

This if should be the outermost if (before the if above) so that the else with the s/w fault aligns with it.

Friday 21 Apr 2023
3:03 pm

jtaylor  (deleted user)

Alarm checks re-ordered.

Alarm checks re-ordered.

3:01 pm

jtaylor  (deleted user)

Comment corrected.

Comment corrected.

2:59 pm

James Walter Taylor <jtaylor@diality.com>

DEN-14980-unable-to-resume-after-hd-unit-plugged-back-in-pre-treatment-after-priming

Additional Code review comments addressed.

Options
    • -12
    • +11
    ./AlarmMgmt.c
2:16 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./AlarmMgmt.c
  2. … 8 more files in changeset.
2:06 pm

Sean Nash

1:51 pm

Dara Navaei

1:42 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:41 pm

Sean Nash

This should probably be up top before the outer if (i.e. checked every time) as there is no dependency on the given alarm ID.

This should probably be up top before the outer if (i.e. checked every time) as there is no dependency on the given alarm ID.

1:31 pm

Sean Nash

Comment doesn't seem to match how timer is used (to decide whether to block alarm trigger).

Comment doesn't seem to match how timer is used (to decide whether to block alarm trigger).

12:15 pm

dcox  (deleted user)

12:15 pm

jtaylor  (deleted user)

AlarmMgmt.h reverted. The timer moved to static AlarmMgnt local.

AlarmMgmt.h reverted. The timer moved to static AlarmMgnt local.

12:15 pm

James Walter Taylor <jtaylor@diality.com>

DEN-14980-unable-to-resume-after-hd-unit-plugged-back-in-pre-treatment-after-priming

Moved Alarms blocked timer variable, per review.

Options
    • -6
    • +7
    ./AlarmMgmt.c
    • -1
    • +0
    ./AlarmMgmt.h
11:42 am

Sean Nash

Not needed. Remove.

Not needed. Remove.

11:15 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:14 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:08 am

Sean Nash

DEN-15183: Fixed compiler warning.

Options
    • -0
    • +1
    ./AlarmMgmt.c
11:06 am

Sean Nash

DEN-15183: Addressed code review comments.

Options
    • -2
    • +2
    ./AlarmMgmt.c
  2. … 1 more file in changeset.
11:06 am

Sean Nash

Fixed.

Fixed.

11:04 am

Sean Nash

Fixed.

Fixed.

10:23 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

8:18 am

jtaylor  (deleted user)

Done.

Done.

8:17 am

James Walter Taylor <jtaylor@diality.com>

DEN-14980-unable-to-resume-after-hd-unit-plugged-back-in-pre-treatment-after-priming

Comments updated.

Options
    • -1
    • +1
    ./AlarmMgmt.c