Services

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Done.

Done.

Done.

Done.

Done.

Done.

Let's discuss how test config is being used in this case. It seems like it's all over the place to me.

Let's discuss how test config is being used in this case. It seems like it's all over the place to me.

Remove extra blank line.

Remove extra blank line.

Add recircEndTreatmentRequested to header.

Add recircEndTreatmentRequested to header.

Add txEndAlarmEndTreatmentRequested to header.

Add txEndAlarmEndTreatmentRequested to header.

Add endTreatmentRequested to header

Add endTreatmentRequested to header

HD-DEN-14262_Vba Homing Fails When Cartridge IS Loaded ON Device
HD-DEN-14262_Vba Homing Fails When Cartridge IS Loaded ON Device
HD-DEN-15199_FW DN Sprint 95 Part 2
HD-DEN-15199_FW DN Sprint 95 Part 2
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

Was expecting you to move if, not else. Doesn't make sense to check alarm (line 359..361) before validating alarm (line 364).

Was expecting you to move if, not else.
Doesn't make sense to check alarm (line 359..361) before validating alarm (line 364).

Thank you - corrected.

Thank you - corrected.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

This if should be the outermost if (before the if above) so that the else with the s/w fault aligns with it.

This if should be the outermost if (before the if above) so that the else with the s/w fault aligns with it.

Alarm checks re-ordered.

Alarm checks re-ordered.

Comment corrected.

Comment corrected.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

This should probably be up top before the outer if (i.e. checked every time) as there is no dependency on the given alarm ID.

This should probably be up top before the outer if (i.e. checked every time) as there is no dependency on the given alarm ID.

Comment doesn't seem to match how timer is used (to decide whether to block alarm trigger).

Comment doesn't seem to match how timer is used (to decide whether to block alarm trigger).