hdfirmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 5
Total Committers: 16
Last Commit: 10 Jun
Commits this week: 5

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 06 Jun 2023
1:22 pm

wbracken  (deleted user)

Add disinfectCancelReqID, currentStandbyState, currentDGCleaningMode

Add disinfectCancelReqID, currentStandbyState, currentDGCleaningMode

1:20 pm

wbracken  (deleted user)

Isn't currentStandbyState an output?

Isn't currentStandbyState an output?

1:18 pm

wbracken  (deleted user)

Add disinfectCancelReqID

Add disinfectCancelReqID

Sunday 04 Jun 2023
3:46 pm

jtaylor  (deleted user) and wbracken  (deleted user)

Friday 02 Jun 2023
6:27 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:54 pm

jtaylor  (deleted user)

Done.

Done.

5:21 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:20 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:20 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:08 pm

jtaylor  (deleted user)

Done.

Done.

5:07 pm

jtaylor  (deleted user)

Oops. DeMorganized and done.

Oops. DeMorganized and done.

4:58 pm

jtaylor  (deleted user)

Done.

Done.

4:53 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:51 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

4:51 pm

Sean Nash

Remove space between ().

Remove space between ().

4:49 pm

Sean Nash

Add blank line between declaration and code. Prefer we not assume bool and BOOL are the same. Use if statement and explicit assignment of TRUE to result if all conditions are true. First conditio...

Add blank line between declaration and code.

Prefer we not assume bool and BOOL are the same. Use if statement and explicit assignment of TRUE to result if all conditions are true.

First condition seems backward.

Second and third conditions seem problematic. You will never trigger an AC power loss alarm. Should remove them I think.

4:41 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:40 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:39 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:39 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:36 pm

Sean Nash

Restore blank line. Should be 2 blank lines above and below test support banner.

Restore blank line. Should be 2 blank lines above and below test support banner.

4:34 pm

Sean Nash

Remove blank line.

Remove blank line.

4:20 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:16 pm

jtaylor  (deleted user)

Done. Error propagration.

Done. Error propagration.

4:11 pm

jtaylor  (deleted user)

Use power loss to reset the out of position counter for the valves. CPLD and isACPowerLost used to give the valves time to settle before checking.

Use power loss to reset the out of position counter for the valves. CPLD and isACPowerLost used to give the valves time to settle before checking.

4:05 pm

jtaylor  (deleted user)

Done.

Done.

4:01 pm

jtaylor  (deleted user)

Done.

Done.

3:40 pm

Sean Nash

3:12 pm

jtaylor  (deleted user)

Done.

Done.

3:07 pm

Sean Nash

Needs an else to zero out of range counter.

Needs an else to zero out of range counter.