Services

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Add comment explaining what we're doing here.

Add comment explaining what we're doing here.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Moved it to OperationModes

Moved it to OperationModes

For other confirmations, an executive (e.g. alarm mgmt monitor or standby mode exec) is responsible for checking confirmation status and we don't call specific handlers from here. Why can't we foll...

For other confirmations, an executive (e.g. alarm mgmt monitor or standby mode exec) is responsible for checking confirmation status and we don't call specific handlers from here. Why can't we follow that design pattern for this confirmation?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2 blank lines above/below test banner.

2 blank lines above/below test banner.

Done

Done

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Last condition is wrong (dialysate recirc blocked). Should be no rinseback.

Last condition is wrong (dialysate recirc blocked). Should be no rinseback.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

These alarms we're demoting from HD fault should have their ranks demoted to 110 (like DG faults).

These alarms we're demoting from HD fault should have their ranks demoted to 110 (like DG faults).

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Condition is not right. Blood leak recover is only relevant in treatment stop state, so we shouldn't care about that state if we're in dialysis.

Condition is not right. Blood leak recover is only relevant in treatment stop state, so we shouldn't care about that state if we're in dialysis.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

Done

Done

The saline bolus state is checked in the below else if

The saline bolus state is checked in the below else if

I think it would be better to reject here if the saline bolus exec is IDLE (indicates there is no saline bolus in progress to abort). I don't want to pend an abort flag (and open pressure limits) w...

I think it would be better to reject here if the saline bolus exec is IDLE (indicates there is no saline bolus in progress to abort).
I don't want to pend an abort flag (and open pressure limits) when no bolus in in progress.

Also reject if in treatment stop state and recovering from blood leak alarm.

Also reject if in treatment stop state and recovering from blood leak alarm.

Why doesn't treatment stop publish saline bolus (like dialysis)?

Why doesn't treatment stop publish saline bolus (like dialysis)?

Do we reject saline bolus request if blood leak recovery is in progress? I think we should. I don't want a saline bolus requesting pending while blood leak recover is happening.

Do we reject saline bolus request if blood leak recovery is in progress? I think we should. I don't want a saline bolus requesting pending while blood leak recover is happening.

Change to "available" properties (e.g. priority low).

Change to "available" properties (e.g. priority low).

Execute TODO.

Execute TODO.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.