hdfirmware / firmware / App

Tasks

Clone Tools

Stats

Commits this week: 0
Total Committers: 11
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 12 Oct 2022
2:05 pm

Dara Navaei

DEN-13834 addressed the code review comments

Options
    • -3
    • +3
    ./TaskGeneral.c
  2. … 4 more files in changeset.
1:38 pm

Dara Navaei

Done. The ranks will be redefined.

Done. The ranks will be redefined.

1:36 pm

Dara Navaei

Done.

Done.

1:31 pm

Dara Navaei

Done.

Done.

1:30 pm

Dara Navaei

Done.

Done.

1:30 pm

Dara Navaei

Done.

Done.

1:29 pm

Dara Navaei

Done.

Done.

1:25 pm

Dara Navaei

This event is used for NV data management events. HD_EVENT_NO_EVENT is not currently in use.

This event is used for NV data management events. HD_EVENT_NO_EVENT is not currently in use.

1:21 pm

Dara Navaei

Done.

Done.

1:20 pm

Dara Navaei

I am waiting for HDD to be updated to reserved so I can rename them.

I am waiting for HDD to be updated to reserved so I can rename them.

1:19 pm

Dara Navaei

Done.

Done.

1:18 pm

Dara Navaei

Done.

Done.

1:16 pm

Dara Navaei

Done.

Done.

1:16 pm

Dara Navaei

Done.

Done.

1:12 pm

Dara Navaei

Done.

Done.

9:16 am

Sean Nash

This probably warrants a comment.

This probably warrants a comment.

9:12 am

Sean Nash

Is this a TODO? Can we just do it?

Is this a TODO? Can we just do it?

9:11 am

Sean Nash

Why are we checking non-zero here? Seems like we will get stuck here if years really is set to zero.

Why are we checking non-zero here? Seems like we will get stuck here if years really is set to zero.

Tuesday 11 Oct 2022
2:19 pm

Dong Nguyen <dnguyen@diality.com>

Updated time to send command to battery.

Options
    • -1
    • +2
    ./TaskBG.c
  2. … 1 more file in changeset.
Thursday 06 Oct 2022
3:42 pm

wbracken  (deleted user)

Does this need to handle lowercase hex characters and invalid characters?

Does this need to handle lowercase hex characters and invalid characters?

Wednesday 05 Oct 2022
6:48 pm

wbracken  (deleted user)

BatteryStatusData is also an input

BatteryStatusData is also an input

Tuesday 04 Oct 2022
6:02 pm

Sean Nash

Add 2 blank lines before test support banner.

Add 2 blank lines before test support banner.

6:01 pm

Sean Nash

Remove extra blank lines. Should only be 1 here.

Remove extra blank lines. Should only be 1 here.

6:01 pm

Sean Nash

Cases should be pulled back one indent (4 spaces) to align with others.

Cases should be pulled back one indent (4 spaces) to align with others.

5:59 pm

Sean Nash

Add blank line after declaration.

Add blank line after declaration.

5:59 pm

Sean Nash

Sort of. You will get something between the ms specified and 1 ms less because you don't know where you are in a given ms when you get your start time. Recommend changing this to 2 ms timeout.

Sort of. You will get something between the ms specified and 1 ms less because you don't know where you are in a given ms when you get your start time.
Recommend changing this to 2 ms timeout.

5:53 pm

Sean Nash

Why not checking payload length?

Why not checking payload length?

5:52 pm

Sean Nash

Keep blank line.

Keep blank line.

5:48 pm

Sean Nash

These FPGA registers are obsolete - h/w is no longer in our design. Need to continue to maintain register space since registers after these have not moved. You can think of these obsolete registers...

These FPGA registers are obsolete - h/w is no longer in our design. Need to continue to maintain register space since registers after these have not moved. You can think of these obsolete registers as "reserved" for future purpose.
Dara, I do think we could rename these register fields to something like Reserved1, Reserved2, ...

5:43 pm

Sean Nash

Monitor execs should be before operation modes exec.

Monitor execs should be before operation modes exec.