hdfirmware / firmware / App

Tasks

Clone Tools

Stats

Commits this week: 0
Total Committers: 11
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 23 Nov 2022
9:25 am

Michael Garthwaite

DEN-14344: Air Pump updates. moved to task general. removal of monitor functions. code review changes. Reworked setting motor to be more direct while debugging.

Options
    • -0
    • +3
    ./TaskGeneral.c
  2. … 3 more files in changeset.
9:19 am

Michael Garthwaite

Do we have an alternative to reading if we successfully set the pin high/low?

Do we have an alternative to reading if we successfully set the pin high/low?

Tuesday 22 Nov 2022
9:40 am

Sean Nash

Ok. Not sure how HALCoGen got ahead of generated code for a time. RESOLVED in CODE WALKTHROUGH.

Ok. Not sure how HALCoGen got ahead of generated code for a time.
RESOLVED in CODE WALKTHROUGH.

9:30 am

Sean Nash

Oh, ok. Then somebody removed a blank line previously and should not have. RESOLVED in CODE WALKTHROUGH.

Oh, ok. Then somebody removed a blank line previously and should not have.
RESOLVED in CODE WALKTHROUGH.

9:27 am

Sean Nash

Not sure how we would test pump other than in pre-treatment when we do pressure leak test (bad pump will fail to pressurize venous side). Remove function unless there is some way to test pump direc...

Not sure how we would test pump other than in pre-treatment when we do pressure leak test (bad pump will fail to pressurize venous side). Remove function unless there is some way to test pump directly.

9:25 am

Sean Nash

How would you check motor is running? Not clear to me that we need a monitor. Can move broadcast to control exec.

How would you check motor is running? Not clear to me that we need a monitor. Can move broadcast to control exec.

9:24 am

Sean Nash

Ok to have this function - just wondering where it would be used? If not needed, remove function and make pump state enum private.

Ok to have this function - just wondering where it would be used? If not needed, remove function and make pump state enum private.

9:22 am

Sean Nash

This pin is an output (or it should be), so I don't think a get function makes sense. Where is this function used?

This pin is an output (or it should be), so I don't think a get function makes sense. Where is this function used?

9:21 am

Sean Nash

Put constant on right side of compare operator. State should be < num of states.

Put constant on right side of compare operator. State should be < num of states.

9:21 am

Sean Nash

Put constant on right side of compare operator. State should be < num of states.

Put constant on right side of compare operator. State should be < num of states.

9:21 am

Sean Nash

Remove space before "state".

Remove space before "state".

9:18 am

Sean Nash

Remove extra blank lines. Add function headers.

Remove extra blank lines. Add function headers.

9:17 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:16 am

Sean Nash

Add doxygen comment to top of structs and enums.

Add doxygen comment to top of structs and enums.

9:16 am

Sean Nash

Align comments.

Align comments.

9:15 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:15 am

Sean Nash

Add blank line after separator.

Add blank line after separator.

9:14 am

Sean Nash

What is there to monitor?

What is there to monitor?

9:13 am

Sean Nash

Need a doxygen module comment here.

Need a doxygen module comment here.

9:12 am

Sean Nash

Add blank line after separator.

Add blank line after separator.

9:12 am

Sean Nash

Add blank line before separator.

Add blank line before separator.

9:12 am

Michael Garthwaite

This code was auto-generated by HALCoGen to link PIN 36. Did you want me to revert the auto-generated code?

This code was auto-generated by HALCoGen to link PIN 36. Did you want me to revert the auto-generated code?

9:12 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:12 am

Michael Garthwaite

This code was auto-generated by HALCoGen. Did you want me to revert the auto-generated code?

This code was auto-generated by HALCoGen. Did you want me to revert the auto-generated code?

9:11 am

Sean Nash

There are 2 available msg IDs above that should be used before adding new ones.

There are 2 available msg IDs above that should be used before adding new ones.

9:10 am

Sean Nash

Align comment.

Align comment.

9:09 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:09 am

Sean Nash

Need function header.

Need function header.

9:08 am

Sean Nash

Need function header.

Need function header.

9:06 am

Sean Nash

What happened here? Why changed?

What happened here? Why changed?