Tasks

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 30 more files in changeset.
DEN-14999 updated the alarms table

  1. … 20 more files in changeset.
RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Has 0 persistence on trigger. I'll remove.

Has 0 persistence on trigger. I'll remove.

where?

where?

Isn't the ALARM_ID_HD_AC_POWE_LOST already cleared?

Isn't the ALARM_ID_HD_AC_POWE_LOST already cleared?

Interested in return value?

Interested in return value?

HD-DEN-14999_Alarm Table Updates Part 2
HD-DEN-14999_Alarm Table Updates Part 2
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 10 more files in changeset.
Merge branch 'staging' into DEN-14344-sw-s85-mg-air-pump

  1. … 8 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 105 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

For a release build, looks like we would do nothing and get stuck in this state.

For a release build, looks like we would do nothing and get stuck in this state.

Add doxygen comment for persistence. Try to capture thinking on why this is such a brief period.

Add doxygen comment for persistence. Try to capture thinking on why this is such a brief period.

Fixed. Thanks!

Fixed. Thanks!

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

The only time we would be adding more states is if we are no longer on HIGH/LOW control, like switching to PWM. That would be such a significant change that this would be reviewed.

The only time we would be adding more states is if we are no longer on HIGH/LOW control, like switching to PWM. That would be such a significant change that this would be reviewed.

Would rather you set a BOOL based on state and then pass the BOOL to persistent alarm function. I'm afraid we could add more states later and forget about this.

Would rather you set a BOOL based on state and then pass the BOOL to persistent alarm function. I'm afraid we could add more states later and forget about this.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

It can only be 0 or 1 in a U32 for the time being. I can cast it as a bool

It can only be 0 or 1 in a U32 for the time being. I can cast it as a bool

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.