hdfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 22 Mar 2021
4:40 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Addressed code review

Options
    • -1
    • +1
    ./Modes/ModePreTreat.c
    • -1
    • +1
    ./Modes/OperationModes.c
    • -4
    • +13
    ./Modes/SampleWater.c
    • -1
    • +1
    ./Modes/SampleWater.h
    • -97
    • +86
    ./Modes/SelfTests.c
3:44 pm

qnguyen  (deleted user)

Wrong valve state. Fixed.

Wrong valve state. Fixed.

3:44 pm

qnguyen  (deleted user)

Fixed.

Fixed.

3:44 pm

qnguyen  (deleted user)

Fixed. Now the BP pump should be off when the test is done.

Fixed. Now the BP pump should be off when the test is done.

3:43 pm

qnguyen  (deleted user)

The valves were not correct. It should be back to the previous state when the BP is off. The pressure should be back with in 5 mmHg with the first pressure measurements before we run BP. Added 2 se...

The valves were not correct. It should be back to the previous state when the BP is off.
The pressure should be back with in 5 mmHg with the first pressure measurements before we run BP.
Added 2 seconds time out for pressure to be normalized.

3:41 pm

qnguyen  (deleted user)

Fixed.

Fixed.

3:36 pm

qnguyen  (deleted user)

Fixed.

Fixed.

3:36 pm

qnguyen  (deleted user)

Fixed.

Fixed.

3:35 pm

qnguyen  (deleted user)

Fixed.

Fixed.

3:35 pm

Sean Nash

Then I would rename the function/state to something less bubble detector and more used cartridge check 2.

Then I would rename the function/state to something less bubble detector and more used cartridge check 2.

3:35 pm

Sean Nash

Then I would rename the function/state to something less bubble detector and more used cartridge check 1.

Then I would rename the function/state to something less bubble detector and more used cartridge check 1.

3:35 pm

qnguyen  (deleted user)

Fixed.

Fixed.

3:34 pm

qnguyen  (deleted user)

Fixed.

Fixed.

3:32 pm

qnguyen  (deleted user)

Fixed.

Fixed.

3:32 pm

qnguyen  (deleted user)

The reservoir should be settled for the first verify already. There is no need to wait for another settle to start second displacement. Removed the check for settle time in second displacement setup.

The reservoir should be settled for the first verify already. There is no need to wait for another settle to start second displacement.
Removed the check for settle time in second displacement setup.

3:31 pm

Sean Nash

Probably should be fabs() here. And change 1 to 1.0.

Probably should be fabs() here. And change 1 to 1.0.

3:31 pm

Sean Nash

Probably should be fabs() here. and change 1 to 1.0.

Probably should be fabs() here. and change 1 to 1.0.

3:30 pm

Sean Nash

Why fabs() here?

Why fabs() here?

3:23 pm

Sean Nash

Should set settleStartTime here.

Should set settleStartTime here.

3:21 pm

Sean Nash

Pressure should be float. Add .0 to end of value.

Pressure should be float. Add .0 to end of value.

3:20 pm

Sean Nash

These volumes (4 of them) should be floats so we should add .0 to end of set value.

These volumes (4 of them) should be floats so we should add .0 to end of set value.

3:18 pm

Sean Nash

Why using fabs() here? Reservoir 1 should have gone down and reservoir 2 should have gone up. If opposite happened, we should not pass the test.

Why using fabs() here? Reservoir 1 should have gone down and reservoir 2 should have gone up. If opposite happened, we should not pass the test.

3:13 pm

Sean Nash

Should be 0.0.

Should be 0.0.

3:04 pm

Sean Nash

Valve positions same so pull out of if-else.

Valve positions same so pull out of if-else.

2:42 pm

qnguyen  (deleted user)

This test is more about the cartridge should be dry. Sensors' faults should be part of POST or no cartridge self-tests.

This test is more about the cartridge should be dry.
Sensors' faults should be part of POST or no cartridge self-tests.

2:42 pm

qnguyen  (deleted user)

This test is more about the cartridge should be dry. Sensors' faults should be part of POST or no cartridge self-tests.

This test is more about the cartridge should be dry.
Sensors' faults should be part of POST or no cartridge self-tests.

2:18 pm

Sean Nash

Shouldn't we turn BP off when we're done using it for test?

Shouldn't we turn BP off when we're done using it for test?

2:14 pm

Sean Nash

Is use of fabs() here appropriate? Do we really not care which pressure is larger? It looks like previous readings are with VBA/VBV closed and BP off while current readings are with BP on and valve...

Is use of fabs() here appropriate? Do we really not care which pressure is larger? It looks like previous readings are with VBA/VBV closed and BP off while current readings are with BP on and valves open.

2:02 pm

Sean Nash

Air trap was already closed - why closing it again?

Air trap was already closed - why closing it again?

2:01 pm

Sean Nash

Add blank line here. Also add comment for these if statements to describe the conditions. Looks like first if for when to end the test and second if is pass/fail criteria.

Add blank line here.
Also add comment for these if statements to describe the conditions. Looks like first if for when to end the test and second if is pass/fail criteria.