hdfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 22 Mar 2021
11:17 pm

Dara Navaei

DEN-5980 addressed code review comments and merged staging

Options
    • -31
    • +28
    ./Controllers/BloodFlow.c
    • -28
    • +22
    ./Controllers/DialInFlow.c
    • -11
    • +13
    ./HDCommon.h
    • -0
    • +6
    ./Modes/ModeInitPOST.c
    • -122
    • +453
    ./Modes/ModeTreatment.c
    • -2
    • +18
    ./Services/AlarmMgmt.h
    • -0
    • +27
    ./Services/SystemComm.c
    • -59
    • +488
    ./Services/SystemCommMessages.c
    • -17
    • +56
    ./Services/SystemCommMessages.h
    • -4
    • +5
    ./Tasks/TaskBG.c
    • -3
    • +2
    ./Tasks/TaskGeneral.c
    • -1
    • +5
    ./Tasks/TaskPriority.c
  13. … 1 more file in changeset.
11:15 pm

Dara Navaei

Done

Done

11:14 pm

Dara Navaei

Done

Done

11:13 pm

Dara Navaei

It is a Diality board but it is treated as an eval board since there is nothing attached to it.

It is a Diality board but it is treated as an eval board since there is nothing attached to it.

11:13 pm

Sean Nash

Rename this. This build switch for was eval board. No longer used.

Rename this. This build switch for was eval board. No longer used.

11:08 pm

Sean Nash

Just delete this case.

Just delete this case.

11:06 pm

Sean Nash

Are you really running this on an eval board? I removed this build switch a while back as nobody was using it anymore.

Are you really running this on an eval board? I removed this build switch a while back as nobody was using it anymore.

10:47 pm

Sean Nash

DEN-7117: Addressed code review feedback.

Options
    • -8
    • +1
    ./Controllers/BloodFlow.c
    • -1
    • +1
    ./Controllers/SyringePump.c
10:44 pm

Sean Nash

Agreed. Tricky because delta is signed, but it works the way I need it to.

Agreed. Tricky because delta is signed, but it works the way I need it to.

10:35 pm

Sean Nash

Added TODO for now.

Added TODO for now.

10:23 pm

Dara Navaei

DEN-5980 addressed code review comments

Options
    • -1
    • +1
    ./Controllers/BloodFlow.c
    • -9
    • +0
    ./Controllers/DGInterface.h
    • -4
    • +4
    ./Controllers/PresOccl.c
    • -1
    • +2
    ./HDCommon.h
    • -0
    • +4
    ./Modes/ModeInitPOST.c
    • -11
    • +3
    ./Modes/ModePreTreat.c
    • -12
    • +12
    ./Modes/ModeTreatment.c
    • -4
    • +0
    ./Services/SystemComm.c
    • -30
    • +1
    ./Services/SystemCommMessages.c
    • -3
    • +0
    ./Services/SystemCommMessages.h
    • -3
    • +4
    ./Tasks/TaskBG.c
    • -10
    • +15
    ./Tasks/TaskGeneral.c
    • -3
    • +5
    ./Tasks/TaskPriority.c
10:21 pm

Dara Navaei

fwcommon had to be updated with latest changes. It is un-commented.

fwcommon had to be updated with latest changes. It is un-commented.

10:21 pm

Dara Navaei

fwcommon had to be updated with latest changes. They are un-commented.

fwcommon had to be updated with latest changes. They are un-commented.

10:17 pm

Dara Navaei

I just need to run NVDataMgmt POST and nothing else. I added a build switch.

I just need to run NVDataMgmt POST and nothing else. I added a build switch.

10:13 pm

Dara Navaei

I am not sure. I un-commented it.

I am not sure. I un-commented it.

10:11 pm

Dara Navaei

Done.

Done.

10:05 pm

Dara Navaei

Done

Done

10:04 pm

Dara Navaei

Done

Done

10:02 pm

Dara Navaei

Done

Done

9:53 pm

Dara Navaei

To be able to run the code on a board with no hardware. I added a build switch.

To be able to run the code on a board with no hardware. I added a build switch.

9:50 pm

Dara Navaei

To be able to run the code on a board with no hardware attached. I added a build switch.

To be able to run the code on a board with no hardware attached. I added a build switch.

9:46 pm

Dara Navaei

To be able to run the code on a board with no hardware attached. I added a build switch.

To be able to run the code on a board with no hardware attached. I added a build switch.

9:41 pm

Dara Navaei

Done

Done

9:39 pm

Dara Navaei

Done

Done

9:38 pm

Dara Navaei

Done

Done

9:36 pm

Dara Navaei

Done

Done

9:35 pm

Dara Navaei

Yes it is part of fwcommon. To review fwcommon, please review DG-DEN-5980 code review.

Yes it is part of fwcommon. To review fwcommon, please review DG-DEN-5980 code review.

9:34 pm

Dara Navaei

The calibration data is validated in NVDataMgmt driver.

The calibration data is validated in NVDataMgmt driver.

8:45 pm

qnguyen  (deleted user)

HD-DEN-7347_DG HD Dev Post
HD-DEN-7347_DG HD Dev Post
8:41 pm

qnguyen  (deleted user)

Added specific fault for each check.

Added specific fault for each check.