hdfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 30 Jul 2021
1:35 pm

Dara Navaei

DEN-9054 removed the FPGA power check

Options
    • -13
    • +0
    ./Services/FPGA.c
    • -1
    • +0
    ./Services/FPGA.h
10:51 am

Sean Nash

Why was this moved?

Why was this moved?

10:50 am

Sean Nash

The message parameter is not used or needed in this function.

The message parameter is not used or needed in this function.

10:47 am

Sean Nash

Can we move these 2 lines of code down where the other ADC channels are being read and converted?

Can we move these 2 lines of code down where the other ADC channels are being read and converted?

10:45 am

Sean Nash

Do we need a debounce on the switch before changing state?

Do we need a debounce on the switch before changing state?

10:44 am

Sean Nash

Caps?

Caps?

10:42 am

Sean Nash

Should initialize the other elements of the override structure too. Most importantly, the override flag should be off.

Should initialize the other elements of the override structure too. Most importantly, the override flag should be off.

Thursday 29 Jul 2021
8:27 pm

Dara Navaei

DEN-9054 added a check for the switch IDs

Options
    • -3
    • +11
    ./Controllers/Switches.c
5:26 pm

Dara Navaei

DEN-9054 addressed the code review comments

Options
    • -4
    • +4
    ./Controllers/Switches.c
    • -8
    • +1
    ./Controllers/Switches.h
    • -0
    • +1
    ./Services/AlarmMgmtSWFaults.h
1:08 pm

Dara Navaei

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

1:06 pm

Dara Navaei

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

1:06 pm

Dara Navaei

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

1:05 pm

Dara Navaei

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

1:05 pm

Dara Navaei

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

1:04 pm

Dara Navaei

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

1:04 pm

Dara Navaei

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

1:03 pm

qnguyen  (deleted user)

Added additional functions.

Added additional functions.

1:03 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:54 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:54 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:53 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:53 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:53 pm

Quang Nguyen <qnguyen@diality.com>

DEN-8679: Addressed code review

Options
    • -0
    • +3
    ./Modes/ModePostTreat.c
    • -1
    • +1
    ./Modes/Rinseback.c
12:53 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:51 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:41 pm

qnguyen  (deleted user)

Done.

Done.

12:41 pm

qnguyen  (deleted user)

Done.

Done.

12:41 pm

Quang Nguyen <qnguyen@diality.com>

DEN-8679: Addressed code review

Options
    • -2
    • +2
    ./Services/SystemCommMessages.c
12:36 pm

qnguyen  (deleted user)

It is both in develop branch and staging branch for fwcommon.

It is both in develop branch and staging branch for fwcommon.

11:39 am

Dara Navaei

DEN-9054 updated the build history log

Options
    • -1
    • +1
    ./Controllers/Switches.c
  2. … 1 more file in changeset.