Activity hdfirmware/firmware/App

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	17
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Friday 30 Jul 2021

4:36 pm

Dara Navaei

More
9978c11
changed 12 files
demo_branch, develop and 2 more

Merged DEN-9054_HD DG switches

- -17
- +71
./Controllers/BloodFlow.c
- History
- Source
- Diff
./Controllers/BloodFlow.c
- -16
- +70
./Controllers/DialInFlow.c
- History
- Source
- Diff
./Controllers/DialInFlow.c
- -2
- +0
./Controllers/DialInFlow.h
- History
- Source
- Diff
./Controllers/DialInFlow.h
- -2
- +84
./Controllers/SyringePump.c
- History
- Source
- Diff
./Controllers/SyringePump.c
- -2
- +3
./HDCommon.h
- History
- Source
- Diff
./HDCommon.h
- -18
- +14
./Modes/ModeInitPOST.c
- History
- Source
- Diff
./Modes/ModeInitPOST.c
- -0
- +14
./Services/FPGA.c
- History
- Source
- Diff
./Services/FPGA.c
- -0
- +3
./Services/FPGA.h
- History
- Source
- Diff
./Services/FPGA.h
- -1
- +18
./Services/SystemComm.c
- History
- Source
- Diff
./Services/SystemComm.c
- -2
- +186
./Services/SystemCommMessages.c
- History
- Source
- Diff
./Services/SystemCommMessages.c
- -5
- +24
./Services/SystemCommMessages.h
- History
- Source
- Diff
./Services/SystemCommMessages.h
- -5
- +9
./Tasks/TaskGeneral.c
- History
- Source
- Diff
./Tasks/TaskGeneral.c

2:14 pm

Dara Navaei

More
Re: HD-DEN-9054-1
replied to Sean Nash

Done.

Done.

2:09 pm

Dara Navaei

More
Re: HD-DEN-9054-1
replied to Sean Nash

That is right. I removed the parameter.

That is right. I removed the parameter.

2:05 pm

Dara Navaei

More
Re: HD-DEN-9054-1
replied to Sean Nash

I moved it up so it will be run first with respect to the other exec functions. The epoch function is used to set an epoch value to the calibration records that failed but we set them the benign va...

I moved it up so it will be run first with respect to the other exec functions. The epoch function is used to set an epoch value to the calibration records that failed but we set them the benign values.

1:58 pm

Sean Nash

More
40b3705
changed 6 files
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 348 more HD-DEN-8886-1

DEN-8886: Added FPGA voltage monitoring and data publication.

- -0
- +13
./Controllers/Voltages.c
- History
- Source
- Diff
./Controllers/Voltages.c
- -0
- +6
./Controllers/Voltages.h
- History
- Source
- Diff
./Controllers/Voltages.h
- -1
- +0
./HDCommon.h
- History
- Source
- Diff
./HDCommon.h
- -5
- +68
./Services/FPGA.c
- History
- Source
- Diff
./Services/FPGA.c
- -0
- +4
./Services/FPGA.h
- History
- Source
- Diff
./Services/FPGA.h
- -11
- +0
./Services/SystemCommMessages.c
- History
- Source
- Diff
./Services/SystemCommMessages.c

1:57 pm

Dara Navaei

More
Re: HD-DEN-8679-1
replied to qnguyen (deleted user)

I moved this enum to DGDefs.h in HD-DEN-9054.

I moved this enum to DGDefs.h in HD-DEN-9054.

1:35 pm

Dara Navaei

More
abc9d65
changed 2 files
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 351 more HD-DEN-9054-1

DEN-9054 removed the FPGA power check

- -13
- +0
./Services/FPGA.c
- History
- Source
- Diff
./Services/FPGA.c
- -1
- +0
./Services/FPGA.h
- History
- Source
- Diff
./Services/FPGA.h

10:51 am

Sean Nash

More
Re: HD-DEN-9054-1
commented on review

Why was this moved?

Why was this moved?

10:50 am

Sean Nash

More
Re: HD-DEN-9054-1
commented on review

The message parameter is not used or needed in this function.

The message parameter is not used or needed in this function.

10:47 am

Sean Nash

More
Re: HD-DEN-9054-1
commented on review

Can we move these 2 lines of code down where the other ADC channels are being read and converted?

Can we move these 2 lines of code down where the other ADC channels are being read and converted?

10:45 am

Sean Nash

More
Re: HD-DEN-9054-1
commented on review

Do we need a debounce on the switch before changing state?

Do we need a debounce on the switch before changing state?

10:44 am

Sean Nash

More
Re: HD-DEN-9054-1
commented on review

Caps?

Caps?

10:42 am

Sean Nash

More
Re: HD-DEN-9054-1
commented on review

Should initialize the other elements of the override structure too. Most importantly, the override flag should be off.

Should initialize the other elements of the override structure too. Most importantly, the override flag should be off.

Thursday 29 Jul 2021

8:27 pm

Dara Navaei

More
ed94e22
changed 1 file
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 351 more HD-DEN-9054-1

DEN-9054 added a check for the switch IDs

- -3
- +11
./Controllers/Switches.c
- History
- Source
- Diff
./Controllers/Switches.c

5:26 pm

Dara Navaei

More
9fdd42e
changed 3 files
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 351 more HD-DEN-9054-1

DEN-9054 addressed the code review comments

- -4
- +4
./Controllers/Switches.c
- History
- Source
- Diff
./Controllers/Switches.c
- -8
- +1
./Controllers/Switches.h
- History
- Source
- Diff
./Controllers/Switches.h
- -0
- +1
./Services/AlarmMgmtSWFaults.h
- History
- Source
- Diff
./Services/AlarmMgmtSWFaults.h

1:08 pm

Dara Navaei

More
Re: HD-DEN-8679-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

1:06 pm

Dara Navaei

More
Re: HD-DEN-8679-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

1:06 pm

Dara Navaei

More
Re: HD-DEN-8679-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

1:05 pm

Dara Navaei

More
Re: HD-DEN-8679-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

1:05 pm

Dara Navaei

More
Re: HD-DEN-8679-1
replied to Sean Nash

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

1:04 pm

Dara Navaei

More
Re: HD-DEN-8679-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

1:04 pm

Dara Navaei

More
Re: HD-DEN-8679-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

1:03 pm

qnguyen (deleted user)

More
Re: HD-DEN-8679-1
replied to Dara Navaei

Added additional functions.

Added additional functions.

1:03 pm

Sean Nash

More
Re: HD-DEN-8679-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:54 pm

Sean Nash

More
Re: HD-DEN-8679-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:54 pm

Sean Nash

More
Re: HD-DEN-8679-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:53 pm

Sean Nash

More
Re: HD-DEN-8679-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:53 pm

Sean Nash

More
Re: HD-DEN-8679-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:53 pm

Quang Nguyen <qnguyen@diality.com>

More
30a8d95
changed 2 files
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 350 more HD-DEN-8679-1 HD-DEN-8886-1

DEN-8679: Addressed code review

- -0
- +3
./Modes/ModePostTreat.c
- History
- Source
- Diff
./Modes/ModePostTreat.c
- -1
- +1
./Modes/Rinseback.c
- History
- Source
- Diff
./Modes/Rinseback.c

12:53 pm

Sean Nash

More
Re: HD-DEN-8679-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-04-06 23:56 -0700