hdfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 15 Nov 2021
4:54 pm

Sean Nash

DEN-9906: Addressed code review feedback.

Options
    • -3
    • +3
    ./Controllers/BloodFlow.c
    • -4
    • +0
    ./Controllers/DialInFlow.c
    • -1
    • +1
    ./Controllers/PresOccl.c
    • -4
    • +4
    ./Controllers/SyringePump.c
    • -11
    • +11
    ./Controllers/Voltages.c
4:49 pm

Sean Nash

Done.

Done.

4:48 pm

Sean Nash

Done.

Done.

4:46 pm

Sean Nash

Done.

Done.

4:46 pm

Sean Nash

Done.

Done.

4:44 pm

Sean Nash

Removed.

Removed.

3:04 pm

Dara Navaei

Adjust the space before the equal signs.

Adjust the space before the equal signs.

3:01 pm

Sean Nash

I adjusted spaces "before" the equal sign.

I adjusted spaces "before" the equal sign.

2:59 pm

Sean Nash

Our coding standard does not require MISRA compliance and I don't think our coding standard includes this if else rule. If you think it should be added to our standard, let's discuss.

Our coding standard does not require MISRA compliance and I don't think our coding standard includes this if else rule.
If you think it should be added to our standard, let's discuss.

2:58 pm

Sean Nash

Added comment.

Added comment.

2:56 pm

Sean Nash

I wasn't sure what flow sensor "response" registers were - moot now that sensors are gone. Still unsure what to do with processor/pc error counts - will resolve this in a future branch.

I wasn't sure what flow sensor "response" registers were - moot now that sensors are gone.
Still unsure what to do with processor/pc error counts - will resolve this in a future branch.

2:19 pm

Dara Navaei

Why there are TBDs in the comments?

Why there are TBDs in the comments?

1:45 pm

hnguyen  (deleted user)

Outputs: Alarm may be activated

Outputs: Alarm may be activated

1:04 pm

hnguyen  (deleted user)

Some of local variables are not used in this function, consider removing them.

Some of local variables are not used in this function, consider removing them.

1:01 pm

Dara Navaei

This should be an F64.

This should be an F64.

12:58 pm

Dara Navaei

This should an F64.

This should an F64.

12:48 pm

hnguyen  (deleted user)

Inputs: should be None Outputs: Alarm may triggered

Inputs: should be None
Outputs: Alarm may triggered

12:38 pm

hnguyen  (deleted user)

Add variable in line 386 to @detail Inputs & Outputs

Add variable in line 386 to @detail Inputs & Outputs

10:58 am

Sean Nash

DEN-9906: Fixed doxygen comments in BloodFlow module.

Options
    • -4
    • +10
    ./Controllers/BloodFlow.c
Friday 12 Nov 2021
4:50 pm

Dara Navaei

DEN-9906 updated the code to support events

Options
    • -5
    • +9
    ./Modes/ModeFault.c
    • -1
    • +1
    ./Modes/ModeFault.h
    • -14
    • +51
    ./Modes/ModeInitPOST.c
    • -1
    • +1
    ./Modes/ModeInitPOST.h
    • -2
    • +4
    ./Modes/ModePostTreat.c
    • -1
    • +1
    ./Modes/ModePostTreat.h
    • -2
    • +4
    ./Modes/ModePreTreat.c
    • -1
    • +1
    ./Modes/ModePreTreat.h
    • -2
    • +4
    ./Modes/ModeService.c
    • -1
    • +1
    ./Modes/ModeService.h
    • -2
    • +4
    ./Modes/ModeStandby.c
    • -1
    • +1
    ./Modes/ModeStandby.h
    • -2
    • +4
    ./Modes/ModeTreatment.c
    • -1
    • +1
    ./Modes/ModeTreatment.h
    • -2
    • +4
    ./Modes/ModeTreatmentParams.c
  16. … 4 more files in changeset.
11:37 am

Sean Nash

Finished implementing the TBD here.

Finished implementing the TBD here.

9:54 am

Sean Nash

DEN-9906: Fixed merge conflicts from staging.

Options
    • -6
    • +6
    ./Controllers/AirTrap.c
    • -6
    • +6
    ./Controllers/AirTrap.h
    • -6
    • +6
    ./Controllers/BloodFlow.c
    • -6
    • +6
    ./Controllers/BloodFlow.h
    • -5
    • +5
    ./Controllers/BloodLeak.c
    • -5
    • +5
    ./Controllers/BloodLeak.h
    • -5
    • +5
    ./Controllers/Bubble.c
    • -5
    • +5
    ./Controllers/Bubble.h
    • -6
    • +6
    ./Controllers/Buttons.c
    • -6
    • +6
    ./Controllers/Buttons.h
    • -11
    • +63
    ./Controllers/DGInterface.c
    • -6
    • +8
    ./Controllers/DGInterface.h
    • -5
    • +5
    ./Controllers/DialInFlow.c
    • -6
    • +6
    ./Controllers/DialInFlow.h
    • -6
    • +6
    ./Controllers/DialOutFlow.c
  16. … 47 more files in changeset.
9:04 am

Sean Nash

DEN-9906: Added new volume checks to saline bolus, rinseback and blood prime deliveries.

Options
    • -0
    • +12
    ./Controllers/BloodFlow.c
    • -1
    • +2
    ./Controllers/BloodFlow.h
    • -3
    • +7
    ./Modes/BloodPrime.c
    • -19
    • +23
    ./Modes/Dialysis.c
    • -7
    • +6
    ./Modes/Rinseback.c
Thursday 11 Nov 2021
3:43 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
3:43 pm

Dara Navaei

Merged staging and resolved merge conflicts

Options
    • -2
    • +2
    ./Controllers/BloodFlow.c
    • -2
    • +2
    ./Controllers/DialInFlow.c
    • -1
    • +1
    ./Controllers/Fans.c
    • -2
    • +2
    ./Controllers/PresOccl.c
    • -2
    • +2
    ./Controllers/Temperatures.c
    • -33
    • +25
    ./Controllers/Valves.c
    • -2
    • +3
    ./HDCommon.h
    • -10
    • +8
    ./Modes/ModeInitPOST.c
    • -2
    • +6
    ./Services/SystemComm.c
    • -2
    • +24
    ./Services/SystemCommMessages.c
    • -2
    • +5
    ./Services/SystemCommMessages.h
11:23 am

Dara Navaei

11:10 am

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
11:10 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Controllers/BloodFlow.c
    • -2
    • +2
    ./Controllers/DialInFlow.c
    • -1
    • +1
    ./Controllers/Fans.c
    • -2
    • +2
    ./Controllers/PresOccl.c
    • -2
    • +2
    ./Controllers/Temperatures.c
    • -2
    • +2
    ./Controllers/Valves.c
    • -2
    • +2
    ./HDCommon.h
    • -2
    • +2
    ./Modes/ModeInitPOST.c
    • -2
    • +2
    ./Services/SystemComm.c
    • -2
    • +2
    ./Services/SystemCommMessages.c
    • -2
    • +2
    ./Services/SystemCommMessages.h
  12. … 1 more file in changeset.
10:48 am

Sean Nash and hnguyen  (deleted user)

10:45 am

hnguyen  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH