Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-11750 addressed the code review comments

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

DEN-11750 addressed the code review comments

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

DEN-11750 addressed the code review comments

    • -98
    • +102
    ./Services/SystemCommMessages.c
Done.

Done.

Done.

Done.

Done.

Done.

No, this should be removed. If this is in an else, in a release build it is not going to compile sine the if will be ignored.

No, this should be removed. If this is in an else, in a release build it is not going to compile sine the if will be ignored.

These appear to be Dialin message functions. They should be down in the Dialin section below the TEST SUPPORT FUNCTIONS banner.

These appear to be Dialin message functions. They should be down in the Dialin section below the TEST SUPPORT FUNCTIONS banner.

Check payload length is at least 12.

Check payload length is at least 12.

Remove extra blank line.

Remove extra blank line.

This can be uninitialized. It is initialized in the init function below.

This can be uninitialized. It is initialized in the init function below.

Should this be in an else below?

Should this be in an else below?

There should be 2 blank lines above and below the TEST SUPPORT FUNCTIONS banner below.

There should be 2 blank lines above and below the TEST SUPPORT FUNCTIONS banner below.

Done.

Done.

Can leave uninitialized here. It is initialized in init function below.

Can leave uninitialized here. It is initialized in init function below.

Done.

Done.

It has been removed.

It has been removed.

Add TODO to remove later.

Add TODO to remove later.

Add TODO to remove.

Add TODO to remove.