hdfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 30 Jun 2022
6:24 pm

Darren Cox <darren_m@cox.net>

DEN-12847 code review comment refactor of drift check.

Options
    • -31
    • +19
    ./Modes/Dialysis.c
2:47 pm

dcox  (deleted user)

No. Removed.

No. Removed.

2:47 pm

dcox  (deleted user)

updated.

updated.

2:46 pm

Sean Nash

DEN-12931: Fixed comment.

Options
    • -1
    • +1
    ./Modes/TreatmentEnd.c
2:46 pm

dcox  (deleted user)

Added index variable and removed duplication of code.

Added index variable and removed duplication of code.

2:44 pm

dcox  (deleted user)

No. Removed.

No. Removed.

2:44 pm

dcox  (deleted user)

Update

Update

2:43 pm

dcox  (deleted user)

Updated

Updated

2:37 pm

Darren Cox <darren_m@cox.net>

DEN-12847 code review comments update.

Options
    • -73
    • +45
    ./Modes/Dialysis.c
2:18 pm

dcox  (deleted user)

Per conversation with Sean: It is a DG Fault generated that the HD is identifying.

Per conversation with Sean: It is a DG Fault generated that the HD is identifying.

2:13 pm

dcox  (deleted user)

Leave as is per conversation w Sean. Reported by HD, but actually a DG generated problem.

Leave as is per conversation w Sean. Reported by HD, but actually a DG generated problem.

12:45 pm

wbracken  (deleted user)

General comment: Should floating point values be of the format N.NF? What is the coding standard? My experience has been that it's best to always specify the "F".

General comment: Should floating point values be of the format N.NF? What is the coding standard? My experience has been that it's best to always specify the "F".

10:09 am

Dara Navaei

10:02 am

Sean Nash

This has the rank of a fault and I think it should be an HD fault - so set the T/F properties same as the alarm above (FPGA clock speed check).

This has the rank of a fault and I think it should be an HD fault - so set the T/F properties same as the alarm above (FPGA clock speed check).

9:44 am

Sean Nash

Maybe change param name to final (i.e. final or start).

Maybe change param name to final (i.e. final or start).

9:42 am

Sean Nash

I think we can handle both reservoirs with same code (no need for else). Probably just need to add a macro somewhere that converts a reservoir ID and primary/backup selection into a loadcell ID.

I think we can handle both reservoirs with same code (no need for else). Probably just need to add a macro somewhere that converts a reservoir ID and primary/backup selection into a loadcell ID.

9:39 am

Sean Nash

I think this whole condition should be removed. If we are taking baseline reading for a reservoir, it is not time to do the drift check yet. Just need to save the readings here.

I think this whole condition should be removed. If we are taking baseline reading for a reservoir, it is not time to do the drift check yet. Just need to save the readings here.

9:37 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:37 am

Sean Nash

Remove blank line.

Remove blank line.

9:37 am

Sean Nash

I think this alarm should be an HD fault for now (no recovery).

I think this alarm should be an HD fault for now (no recovery).

9:34 am

Sean Nash

Do an explicit condition here. i.e. if ( TRUE == reservoirFull )

Do an explicit condition here. i.e. if ( TRUE == reservoirFull )

9:27 am

Sean Nash

It's not so much empty and full - neither is empty - it's more like start and final weights. Consider renaming these. Also, consider moving these declarations to top of module. Nothing wrong with t...

It's not so much empty and full - neither is empty - it's more like start and final weights. Consider renaming these.
Also, consider moving these declarations to top of module. Nothing wrong with them being here, but the style for this code base has been to declare everything at top of module.

9:19 am

Sean Nash

Use FALSE, not false.

Use FALSE, not false.

9:18 am

Sean Nash

Use TRUE (not true).

Use TRUE (not true).

9:13 am

Sean Nash

Is fabs() appropriate here?

Is fabs() appropriate here?

9:12 am

Sean Nash

Is fabs() appropriate here?

Is fabs() appropriate here?

Wednesday 29 Jun 2022
4:10 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-12974, DEN-13149 Add configuration check around HD pump direction status error.

Options
    • -3
    • +8
    ./Controllers/DialOutFlow.c
4:10 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-12974, DEN-13149 Add configuration check around HD pump direction status error.

Options
    • -3
    • +6
    ./Controllers/DialOutFlow.c
Tuesday 28 Jun 2022
3:50 pm

Darren Cox <darren_m@cox.net>

DEN-12847 Code review comment updates.

Options
    • -4
    • +1
    ./Modes/Dialysis.c
2:31 pm

Darren Cox <darren_m@cox.net>

DEN12847 Code review comments update 1.

Options
    • -0
    • +1
    ./Controllers/DGInterface.h
    • -1
    • +0
    ./Modes/Dialysis.c