Activity hdfirmware/firmware/App

1:35 pm

Michael Garthwaite

More
2ed9aef
changed 3 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 306 more HD-DEN-13801-1

Merge branch 'staging' into DEN-13801-sw_dev-sprint-79_mg

- -127
- +53
./Controllers/PresOccl.c
- History
- Source
- Diff
./Controllers/PresOccl.c
- -9
- +21
./Drivers/Battery.c
- History
- Source
- Diff
./Drivers/Battery.c
- -19
- +17
./Modes/SelfTests.c
- History
- Source
- Diff
./Modes/SelfTests.c

11:01 am

Steve Jarpe <sjarpe@diality.com>

More
ffa216b
changed 2 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 312 more HD-DEN-14001-1

DEN-14001-hd-battery-driver-update. Made recommended changes in label naming. Split logging data into two groups--battery status data which is published more frequently, and battery manager data which is published less frequently.

- -218
- +218
./Drivers/Battery.c
- History
- Source
- Diff
./Drivers/Battery.c
- -32
- +37
./Drivers/Battery.h
- History
- Source
- Diff
./Drivers/Battery.h

9:00 am

Michael Garthwaite

More
Re: HD-DEN-13834-1
commented on review

Do we want this checked into staging?

5:17 pm

Sean Nash

These are defined in the Code Composer project for DG and HD firmware respectively. You can only have one defined and you must have one defined.

5:06 pm

Sean Nash

More
Re: HD-DEN-13834-1
commented on review

What is the purpose of this "no event" event?

5:06 pm

Sean Nash

More
Re: HD-DEN-13834-1
commented on review

What is the purpose of this "no event" event?

5:04 pm

Sean Nash

More
Re: HD-DEN-13834-1
commented on review

No stop property for a high priority alarm? PRS 754 says dialysate temperature alarms are low priority. Temp too low = rank 902. Temp too high = rank 901.

No stop property for a high priority alarm?
PRS 754 says dialysate temperature alarms are low priority. Temp too low = rank 902. Temp too high = rank 901.

4:54 pm

Sean Nash

More
Re: HD-DEN-13834-1
commented on review

Why no stop?

4:53 pm

Sean Nash

More
Re: HD-DEN-13834-1
commented on review

Why no stop?

4:52 pm

Sean Nash

More
Re: HD-DEN-13834-1
commented on review

For DG faults, let's be consistent. DG fault = TRUE Clear Immediate = TRUE (alarm condition moot because DG going to fault mode) Stops = TRUE (HD pauses treatment for alarm) No Clear = FALSE (so HD...

For DG faults, let's be consistent.
DG fault = TRUE
Clear Immediate = TRUE (alarm condition moot because DG going to fault mode)
Stops = TRUE (HD pauses treatment for alarm)
No Clear = FALSE (so HD can clear alarm when user selects option)
No Resume = TRUE (cannot resume treatment w/o functioning DG)
No Rinseback = FALSE (no reason to prevent patient getting their blood back just because DG failed)
No End Treatment = FALSE (should try to end treatment as normally as possible w/o DG - won't be able to drain reservoirs though)
No Blood Recirc = FALSE (why not recirc blood?)
No Dialysate Recirc = TRUE (may not be possible depending on what's wrong w/ DG)
Clear Only = FALSE

4:45 pm

Sean Nash

More
Re: HD-DEN-13834-1
commented on review

Faults (HD and DG) should probably be consistent on clear immediate concept. I think faults should be TRUE on clear immediate (going to fault mode anyway, so alarm condition isn't relevant after th...

Faults (HD and DG) should probably be consistent on clear immediate concept. I think faults should be TRUE on clear immediate (going to fault mode anyway, so alarm condition isn't relevant after that).

4:44 pm