hdfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 07 Nov 2022
10:52 am

Dong Nguyen <dnguyen@diality.com>

DEN-14150: Update DialInFlow.c

Options
    • -1
    • +0
    ./Controllers/DialInFlow.c
10:48 am

Dong Nguyen

Removed.

Removed.

10:45 am

Dong Nguyen

I already removed the test code (at line 116). I just checked and it was removed in my local version. I already pushed DEN-14150. Please pull it gain to see if the test code is still there. Thank you.

I already removed the test code (at line 116).
I just checked and it was removed in my local version. I already pushed DEN-14150.
Please pull it gain to see if the test code is still there.
Thank you.

10:44 am

Sean Nash

Why is this in utilities module? Doesn't it make more sense in fpga module?

Why is this in utilities module? Doesn't it make more sense in fpga module?

10:43 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:42 am

Sean Nash

Remove blank line.

Remove blank line.

10:41 am

Sean Nash

None of these structures appear to require packing - all 32-bit fields.

None of these structures appear to require packing - all 32-bit fields.

10:40 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:40 am

Sean Nash

If this message is for DG CPLD only, should change enum to "MSG_ID_DG_CPLD_...".

If this message is for DG CPLD only, should change enum to "MSG_ID_DG_CPLD_...".

10:39 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:34 am

Dara Navaei

DEN-14175 addressed the code review comments

Options
    • -2
    • +0
    ./Modes/ModePreTreat.c
    • -2
    • +3
    ./Modes/TreatmentEnd.c
10:28 am

Michael Garthwaite

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:26 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:25 am

Sean Nash

Remove test code.

Remove test code.

10:25 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:25 am

Sean Nash

Remove test code.

Remove test code.

10:25 am

wbracken  (deleted user)

RESOLVED IN CODE WLAKTHROUGH

RESOLVED IN CODE WLAKTHROUGH

10:21 am

wbracken  (deleted user)

Looks like blank line is still there.

Looks like blank line is still there.

9:48 am

Dong Nguyen <dnguyen@diality.com>

DEN-14150: Update DialInFlow.c

Options
    • -2
    • +5
    ./Controllers/DialInFlow.c
9:37 am

Dara Navaei

Done.

Done.

9:33 am

Dara Navaei

Done.

Done.

8:53 am

Dong Nguyen

Done.

Done.

Saturday 05 Nov 2022
12:18 pm

Behrouz NematiPour

I know all the FW code is written in this style but it is always interesting to me, 1 - why don't just say if ( isSyringePumpPreLoaded() ) the function is a boolean why compare to TRUE to get a bo...

I know all the FW code is written in this style but it is always interesting to me,
1 - why don't just say 

if ( isSyringePumpPreLoaded() )

the function is a boolean why compare to TRUE to get a bool expression?
if it was returning an int it made sense to have something like this:

if ( isSyringePumpPreLoaded() != 0 )

Which is still unnecessary in some cases.
2 - even if we want to use TRUE, why to put it at the beginning of the expression and don't put it at the end, like 

if ( isSyringePumpPreLoaded() == TRUE )

So the first thing developer sees would be the important part which is the function not always a TRUE or FALSE.

Friday 04 Nov 2022
4:46 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

4:25 pm

Sean Nash

If we want to do that for consistency, that's fine but let's handle that as a bulk update and going forward kind of thing rather than keep commenting individually on code reviews.

If we want to do that for consistency, that's fine but let's handle that as a bulk update and going forward kind of thing rather than keep commenting individually on code reviews.

4:23 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:23 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:22 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:21 pm

Sean Nash

I think the else can end right after ramp. Ok to do checks I would think.

I think the else can end right after ramp. Ok to do checks I would think.