hdfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 12 Jan 2023
3:19 pm

James Walter Taylor <jtaylor@diality.com>

DEN-14457-reservoir-drains-before-treatment-with-pre-treatment-build-flags-off

Removed unused fill volume case.

Options
    • -13
    • +0
    ./Modes/ModePreTreat.c
3:12 pm

Sean Nash

Should we have an else for this if where we zero the positionOUtOfRangeCounter?

Should we have an else for this if where we zero the positionOUtOfRangeCounter?

2:55 pm

James Walter Taylor <jtaylor@diality.com>

DEN-14457-reservoir-drains-before-treatment-with-pre-treatment-build-flags-off

Cleaned up logic between _RELEASE preprocessor and SW_CONFIG flags

Options
    • -16
    • +32
    ./Modes/ModePreTreat.c
    • -2
    • +2
    ./Modes/SelfTests.c
11:39 am

Sean Nash

DEN-14549: cosmetic changes to ModeStandby.h.

Options
    • -4
    • +0
    ./Modes/ModeStandby.h
10:21 am

Sean Nash

DEN-14549: Updates to reasons to reject start treatment request at standby mode.

Options
    • -1
    • +1
    ./Controllers/DGInterface.c
    • -1
    • +1
    ./Controllers/DGInterface.h
    • -0
    • +12
    ./Modes/ModeInitPOST.c
    • -0
    • +1
    ./Modes/ModeInitPOST.h
    • -37
    • +55
    ./Modes/ModeStandby.c
    • -4
    • +5
    ./Services/AlarmMgmt.c
    • -0
    • +24
    ./Services/SystemCommMessages.c
    • -1
    • +4
    ./Services/SystemCommMessages.h
Wednesday 11 Jan 2023
5:01 pm

Dara Navaei

HD-DEN-14559_DG HD Dev HD DG Dvt Update Part 8
HD-DEN-14559_DG HD Dev HD DG Dvt Update Part 8
2:21 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
2:21 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Controllers/BloodLeak.c
    • -2
    • +2
    ./Modes/ModeFault.c
    • -2
    • +2
    ./Modes/ModeInitPOST.c
    • -2
    • +2
    ./Modes/ModeService.c
    • -2
    • +2
    ./Modes/SelfTests.c
    • -1
    • +1
    ./Services/SystemCommMessages.c
    • -1
    • +1
    ./Services/SystemCommMessages.h
2:14 pm

Dara Navaei

1:54 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
1:52 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
1:24 pm

Sean Nash

1:24 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:21 pm

Dara Navaei

DEN-14497 addressed the code review comments

Options
    • -24
    • +24
    ./Services/SystemCommMessages.c
1:21 pm

Dara Navaei

Done

Done

10:55 am

Sean Nash

There are many of these - not just this one.

There are many of these - not just this one.

10:30 am

Sean Nash

DEN-14549: Added buttons and safety line to HD events to be logged.

Options
    • -1
    • +11
    ./Controllers/Buttons.c
    • -0
    • +1
    ./Drivers/SafetyShutdown.c
9:19 am

Dara Navaei

DEN-14497 addressed the code review comment

Options
    • -1
    • +1
    ./Services/SystemCommMessages.c
9:18 am

Dara Navaei

Done

Done

9:14 am

Sean Nash

Why are these changed back to ACK_NOT_REQUIRED?

Why are these changed back to ACK_NOT_REQUIRED?

9:12 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:51 am

Dara Navaei

Merge branch 'staging' into DEN-14497-dg_hd_dev-hd_dg_dvt-update-part-7

Options
    • -1
    • +1
    ./Controllers/BloodLeak.c
    • -1
    • +1
    ./Modes/ModeFault.c
    • -1
    • +1
    ./Modes/ModeInitPOST.c
    • -1
    • +1
    ./Modes/ModeService.c
    • -28
    • +90
    ./Modes/SelfTests.c
    • -2
    • +61
    ./Services/SystemCommMessages.c
    • -3
    • +10
    ./Services/SystemCommMessages.h
8:51 am

Dara Navaei

DEN-14497 addressed the code review comments

Options
    • -35
    • +36
    ./Controllers/BloodLeak.c
    • -1
    • +1
    ./Services/SystemCommMessages.c
8:41 am

Dara Navaei

Done

Done

Tuesday 10 Jan 2023
5:45 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
5:01 pm

Dara Navaei

HD-DEN-14310_Unable Resume After HD Unit Plugged Back IN
HD-DEN-14310_Unable Resume After HD Unit Plugged Back IN
4:51 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:46 pm

Dara Navaei

Done

Done

4:43 pm

James Walter Taylor <jtaylor@diality.com>

HD-DEN-14457_Reservoir Drains Before Treatment With Pre Treatment Build Flags Off

Converted DISABLE_PRIMING tests to positive logic, and moved default behavior (RELEASE) outside conditional compilation

Options
    • -6
    • +6
    ./Modes/ModePreTreat.c
    • -1
    • +1
    ./Modes/Prime.c
4:27 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h