hdfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 17 Jan 2023
3:53 pm

James Walter Taylor <jtaylor@diality.com>

DEN-14457-reservoir-drains-before-treatment-with-pre-treatment-build-flags-off

DEN-14457-reservoir-drains-before-treatment-with-pre-treatment-build-flags-off dragged into current branch

Options
    • -4
    • +4
    ./Modes/ModePreTreat.c
2:58 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:57 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:56 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:25 pm

dcox  (deleted user)

This config check is unnecessary and should be removed. The vars should always be initialized. Enable/Disable Alarms are done when checking the direction, etc.

This config check is unnecessary and should be removed. The vars should always be initialized. Enable/Disable Alarms are done when checking the direction, etc.

1:05 pm

James Walter Taylor <jtaylor@diality.com>

HD-DEN-14561_Release Preprocessor Flag Specifies Code That Conflicts With SW Config Debug

Corrected _RELEASE_ logic, release build executes the same block as non debug selection

Options
    • -3
    • +3
    ./Controllers/BloodFlow.c
    • -1
    • +1
    ./Controllers/SyringePump.c
    • -3
    • +3
    ./Modes/SelfTests.c
    • -10
    • +11
    ./Services/AlarmMgmt.c
1:04 pm

Sean Nash

They're kind of different. The stop function is fairly straightforward and is part of syringe pump driver. The start function is a lot more complex as it needs to figure out what it should be doing...

They're kind of different. The stop function is fairly straightforward and is part of syringe pump driver. The start function is a lot more complex as it needs to figure out what it should be doing and is part of treatment mode module.

12:13 pm

dcox  (deleted user)

Inconsistent naming here. StopSyringePump, StartHeparinPump. Suggest using same name for both.

Inconsistent naming here. StopSyringePump, StartHeparinPump. Suggest using same name for both.

11:35 am

Sean Nash

Done.

Done.

11:35 am

Sean Nash

DEN-14549: Addressed code review comments.

Options
    • -3
    • +3
    ./Modes/SelfTests.c
11:32 am

Sean Nash

Done.

Done.

11:32 am

Sean Nash

Done.

Done.

11:19 am

Sean Nash

DEN-14549: maintain blood flow rate when alarm w/ blood recirc property pauses treatment. maintain Heparin dispense when blood recirc is occurring during alarm pause of treatment. include blood prime state in checks for inline pressure range.

Options
    • -24
    • +4
    ./Controllers/PresOccl.c
    • -3
    • +1
    ./Modes/Dialysis.c
    • -0
    • +1
    ./Modes/Dialysis.h
    • -18
    • +24
    ./Modes/TreatmentStop.c
11:01 am

Dara Navaei

HD-DEN-14328_HD Event Issues
HD-DEN-14328_HD Event Issues
9:57 am

wbracken  (deleted user)

Add pressureSelfTestNormalizedStartTime to header.

Add pressureSelfTestNormalizedStartTime to header.

9:55 am

wbracken  (deleted user)

Add pressureSelfTestPreNormalStartTime to header.

Add pressureSelfTestPreNormalStartTime to header.

9:54 am

wbracken  (deleted user)

Add pressureSelfTestPreNormalStartTime to header.

Add pressureSelfTestPreNormalStartTime to header.

9:44 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

9:30 am

Sean Nash

DEN-14549: Misc updates to dry self-tests in pre-treatment.

Options
    • -3
    • +3
    ./Controllers/PresOccl.c
    • -34
    • +59
    ./Modes/SelfTests.c
    • -1
    • +1
    ./Services/SystemComm.c
    • -8
    • +3
    ./Services/SystemCommMessages.c
Monday 16 Jan 2023
3:50 pm

James Walter Taylor <jtaylor@diality.com>

HD-DEN-14457_Reservoir Drains Before Treatment With Pre Treatment Build Flags Off

Reverted volume changes. Using a lower volume appeared to cause flowmeter test errors. Volumes match the original code, now.

Options
    • -6
    • +7
    ./Modes/ModePreTreat.c
3:01 pm

Dara Navaei

HD-DEN-14561_Release Preprocessor Flag Specifies Code That Conflicts With SW Config Debug
HD-DEN-14561_Release Preprocessor Flag Specifies Code That Conflicts With SW Config Debug
Saturday 14 Jan 2023
2:15 pm

Sean Nash

DEN-14549: Fixed issue where door open alarm would have condition cleared repeatedly in standby start state. Made top alarm determination done from scratch each time.

Options
    • -8
    • +8
    ./Modes/ModeStandby.c
    • -8
    • +10
    ./Services/AlarmMgmt.c
1:30 pm

Sean Nash

DEN-14549: Removed obsolete internal ADC channel. Updates internal ADC channel transfer functions. Misc pre-tx state optimizations.

Options
    • -4
    • +4
    ./Drivers/InternalADC.c
    • -1
    • +1
    ./Drivers/InternalADC.h
    • -11
    • +7
    ./Modes/ConsumableSelfTest.c
    • -25
    • +16
    ./Modes/ModePreTreat.c
    • -2
    • +6
    ./Modes/SampleWater.c
    • -6
    • +2
    ./Modes/SelfTests.c
    • -3
    • +2
    ./Services/AlarmMgmt.c
    • -0
    • +1
    ./Services/AlarmMgmtSWFaults.h
Friday 13 Jan 2023
2:00 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
2:00 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Controllers/Valves.c
1:58 pm

dcox  (deleted user)

1:17 pm

Dara Navaei

12:09 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
8:46 am

Sean Nash

It is in the header under Outputs.

It is in the header under Outputs.

8:42 am

Sean Nash

DEN-14549: Removed some obsolete code.

Options
    • -61
    • +37
    ./Controllers/DGInterface.c
    • -2
    • +0
    ./Controllers/DGInterface.h
    • -3
    • +0
    ./Modes/Dialysis.c