Activity hdfirmware/firmware/App

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	17
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Friday 20 Jan 2023

11:27 am

Michael Garthwaite

More
393fa8c
changed 2 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 289 more HD-DEN-14011-1

DEN-14011: created handleDrySelfTestStartState. code review comments.

- -1
- +1
./Controllers/PresOccl.c
- History
- Source
- Diff
./Controllers/PresOccl.c
- -20
- +40
./Modes/SelfTests.c
- History
- Source
- Diff
./Modes/SelfTests.c

10:36 am

dcox (deleted user)

More
Re: HD-DEN-14561-1
replied to Sean Nash

Updated to 600.

Updated to 600.

10:30 am

Darren Cox <darren_m@cox.net>

More
c7f4ad0
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 282 more HD-DEN-14561-1

DEN-14561 Update PRE_TREATMENT_FILL_RESERVOIR_TWO_VOLUME_ML per code review comment.

- -1
- +1
./Modes/ModePreTreat.c
- History
- Source
- Diff
./Modes/ModePreTreat.c

9:13 am

Sean Nash

More
Re: HD-DEN-14011-1
commented on review

Should this be moved into "if" body? Doesn't appear to need setting until we resume.

Should this be moved into "if" body? Doesn't appear to need setting until we resume.

9:11 am

Sean Nash

More
Re: HD-DEN-14011-1
commented on review

Should this 10 seconds only start once latch is locked?

Should this 10 seconds only start once latch is locked?

9:07 am

Sean Nash

More
Re: HD-DEN-14011-1
commented on review

Not sure exception for treatment stop state still makes sense. We can be running BP in that state now depending on alarm. Should still alarm on occlusion.

Not sure exception for treatment stop state still makes sense. We can be running BP in that state now depending on alarm. Should still alarm on occlusion.

Thursday 19 Jan 2023

3:47 pm

Sean Nash

More
Re: HD-DEN-14561-1
replied to dcox (deleted user)

So R2 fill was 1100 and you say it ended up at 500. Would be 800 if keep same at 1100. If we change to 600, would end around 300 as you say - I think that's right.

So R2 fill was 1100 and you say it ended up at 500. Would be 800 if keep same at 1100. If we change to 600, would end around 300 as you say - I think that's right.

3:43 pm

Sean Nash

More
Re: HD-DEN-14561-1
replied to dcox (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:33 pm

Dara Navaei

More
5af5fb5
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 289 more

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
./HDCommon.h
- History
- Source
- Diff
./HDCommon.h

3:32 pm

Dara Navaei

More
1f91b5a
changed 12 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 289 more HD-DEN-14549-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./Modes/ConsumableSelfTest.c
- History
- Source
- Diff
./Modes/ConsumableSelfTest.c
- -2
- +2
./Modes/Dialysis.c
- History
- Source
- Diff
./Modes/Dialysis.c
- -2
- +2
./Modes/ModePostTreat.c
- History
- Source
- Diff
./Modes/ModePostTreat.c
- -2
- +2
./Modes/ModeTreatmentParams.c
- History
- Source
- Diff
./Modes/ModeTreatmentParams.c
- -2
- +2
./Modes/PreTreatmentRecirc.c
- History
- Source
- Diff
./Modes/PreTreatmentRecirc.c
- -2
- +2
./Modes/Prime.c
- History
- Source
- Diff
./Modes/Prime.c
- -2
- +2
./Modes/Rinseback.c
- History
- Source
- Diff
./Modes/Rinseback.c
- -2
- +2
./Modes/SampleWater.c
- History
- Source
- Diff
./Modes/SampleWater.c
- -2
- +2
./Modes/SelfTests.c
- History
- Source
- Diff
./Modes/SelfTests.c
- -2
- +2
./Modes/TreatmentEnd.c
- History
- Source
- Diff
./Modes/TreatmentEnd.c
- -2
- +2
./Modes/TreatmentRecirc.c
- History
- Source
- Diff
./Modes/TreatmentRecirc.c
- -2
- +2
./Modes/TreatmentStop.c
- History
- Source
- Diff
./Modes/TreatmentStop.c

3:30 pm

Michael Garthwaite

More
HD-DEN-14328-1
Closed

3:16 pm

Dara Navaei

More
HD-DEN-14011-1
started review

HD-DEN-14011_Occulsion Alarm When Reseating

HD-DEN-14011_Occulsion Alarm When Reseating

3:12 pm

Dara Navaei

More
40bf3e7
changed 1 file
develop

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
./HDCommon.h
- History
- Source
- Diff
./HDCommon.h

2:01 pm

Michael Garthwaite

More
221f2d3
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 289 more HD-DEN-14011-1

DEN-14011: added condition to check if BP is running while we do occlusion checks.

- -3
- +5
./Controllers/PresOccl.c
- History
- Source
- Diff
./Controllers/PresOccl.c

1:50 pm

Sean Nash and Dara Navaei

More
HD-DEN-14328-1
finished reviewing

1:50 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:49 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:49 pm

Michael Garthwaite

More
1e7652b
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 289 more HD-DEN-14011-1

DEN-14011: dry self test transitions to DRY_SELF_TESTS_START_STATE on dry self retries instead of DRY_SELF_WAIT_FOR_DOOR_CLOSE_STATE.

- -1
- +1
./Modes/SelfTests.c
- History
- Source
- Diff
./Modes/SelfTests.c

1:49 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:49 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:48 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:25 pm

Michael Garthwaite

More
Re: HD-DEN-14328-1
replied to Sean Nash

Fixed. Thanks!

Fixed. Thanks!

1:25 pm

Michael Garthwaite

More
Re: HD-DEN-14328-1
replied to Sean Nash

Fixed. Thanks!

Fixed. Thanks!

1:25 pm

Michael Garthwaite

More
Re: HD-DEN-14328-1
replied to Sean Nash

Fixed. Thanks!

Fixed. Thanks!

1:25 pm

Michael Garthwaite

More
Re: HD-DEN-14328-1
replied to Sean Nash

Fixed. Thanks!

Fixed. Thanks!

1:25 pm

Michael Garthwaite

More
Re: HD-DEN-14328-1
replied to Sean Nash

Fixed. Thanks!

Fixed. Thanks!

1:25 pm

Michael Garthwaite

More
bcdf52a
changed 5 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 290 more HD-DEN-14328-1

DEN-14414: addressed code reviews.

- -0
- +1
./Modes/Prime.c
- History
- Source
- Diff
./Modes/Prime.c
- -1
- +3
./Modes/Rinseback.c
- History
- Source
- Diff
./Modes/Rinseback.c
- -1
- +2
./Modes/TreatmentEnd.c
- History
- Source
- Diff
./Modes/TreatmentEnd.c
- -1
- +2
./Modes/TreatmentRecirc.c
- History
- Source
- Diff
./Modes/TreatmentRecirc.c
- -0
- +1
./Modes/TreatmentStop.c
- History
- Source
- Diff
./Modes/TreatmentStop.c

1:16 pm

Sean Nash

More
Re: HD-DEN-14328-1
commented on review

Add blank line between declaration and code.

Add blank line between declaration and code.

1:16 pm

Sean Nash

More
Re: HD-DEN-14328-1
commented on review

Put this (and blank line after) at top of function.

Put this (and blank line after) at top of function.

1:15 pm

Sean Nash

More
Re: HD-DEN-14328-1
commented on review

Put this (and blank line after) at top of function.

Put this (and blank line after) at top of function.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-02-13 11:42 -0800