Activity hdfirmware/firmware/App

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	17
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Wednesday 15 Mar 2023

6:17 pm

Steve Jarpe <sjarpe@diality.com>

More
5721841
changed 1 file
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 253 more HD-DEN-14906-1

DEN-14906-dialyzer-de-prime. Corrected a major error and cleaned up function headers

- -9
- +10
./Modes/Dialysis.c
- History
- Source
- Diff
./Modes/Dialysis.c

6:07 pm

Steve Jarpe <sjarpe@diality.com>

More
1b1cb46
changed 2 files
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 253 more HD-DEN-14906-1

DEN-14906-dialyzer-de-prime. First round of addressing code review comments.

- -0
- +1
./HDCommon.h
- History
- Source
- Diff
./HDCommon.h
- -66
- +104
./Modes/Dialysis.c
- History
- Source
- Diff
./Modes/Dialysis.c

4:11 pm

Sean Nash

More
f93726a
changed 1 file
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 253 more HD-DEN-14906-1

DEN-14906: pause dialysate use during re-prime.

- -1
- +1
./Services/Reservoirs.c
- History
- Source
- Diff
./Services/Reservoirs.c

3:53 pm

Sean Nash

More
3b16960
changed 1 file
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 253 more HD-DEN-14906-1

Merge branch 'DEN-14906-dialyzer-de-prime' of ssh://dvm-linux02:7999/hd/hdfirmware into DEN-14906-dialyzer-de-prime

- -10
- +4
./Modes/Dialysis.c
- History
- Source
- Diff
./Modes/Dialysis.c

3:53 pm

Sean Nash

More
425d3c1
changed 2 files
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 253 more HD-DEN-14906-1

DEN-14906: pause dialysate use during re-prime.

- -2
- +1
./Modes/Dialysis.c
- History
- Source
- Diff
./Modes/Dialysis.c
- -4
- +7
./Services/Reservoirs.c
- History
- Source
- Diff
./Services/Reservoirs.c

3:28 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:25 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:24 pm

Sean Nash

More
Re: HD-DEN-14906-1
replied to wbracken (deleted user)

Doesn't look like it.

Doesn't look like it.

3:22 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:12 pm

wbracken (deleted user)

More
Re: HD-DEN-14860-1
replied to dcox (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

2:01 pm

wbracken (deleted user)

More
Re: HD-DEN-14906-1
commented on review

Is dialysisState used in this function?

Is dialysisState used in this function?

1:54 pm

wbracken (deleted user)

More
Re: HD-DEN-14906-1
commented on review

Space before ")"

Space before ")"

11:58 am

Steve Jarpe

More
Re: HD-DEN-14906-1
replied to Sean Nash

Done

Done

11:53 am

Steve Jarpe

More
Re: HD-DEN-14906-1
replied to Sean Nash

Done.

Done.

11:52 am

Sean Nash

More
ed4f6eb
changed 4 files
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 261 more HD-DEN-14888-1

DEN-14888: Increased minimum UF rate from zero to 100 mL/hour.

- -9
- +8
./Modes/Dialysis.c
- History
- Source
- Diff
./Modes/Dialysis.c
- -1
- +1
./Modes/ModeTreatment.c
- History
- Source
- Diff
./Modes/ModeTreatment.c
- -1
- +1
./Modes/ModeTreatmentParams.c
- History
- Source
- Diff
./Modes/ModeTreatmentParams.c
- -0
- +1
./Modes/ModeTreatmentParams.h
- History
- Source
- Diff
./Modes/ModeTreatmentParams.h

11:48 am

Sean Nash

Will do.

Will do.

11:47 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:47 am

Sean Nash

Just wondering whether a reset function was needed for reprime. Looks like you've added one. RESOLVED in CODE WALKTHROUGH.

Just wondering whether a reset function was needed for reprime. Looks like you've added one.
RESOLVED in CODE WALKTHROUGH.

11:43 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:39 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:39 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:37 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:36 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:36 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:34 am

Sean Nash

I think it would make more sense to set DPi rate to zero, set re-prime in progress flag to FALSE, and set state to dialysate pumps off which will then handle the ramp down and transition to reprime...

I think it would make more sense to set DPi rate to zero, set re-prime in progress flag to FALSE, and set state to dialysate pumps off which will then handle the ramp down and transition to reprime state.

11:27 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:22 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:20 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:19 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:16 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-04-22 22:32 -0700